[GitHub] nifi issue #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be used by ...

2018-04-26 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on the issue: https://github.com/apache/nifi/pull/2003 @mattyb149 Looks like a lot has changed in the last 9 months. The code I added here leveraged classes related to Schema registries, but those classes have been moved into a more Avro

[GitHub] nifi issue #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be used by ...

2018-04-26 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on the issue: https://github.com/apache/nifi/pull/2003 While I think @markap14 and I agree on the correct long-term solution of adding a new "String Column Names" schema registry, I've never got around to taking on that task. Shifting priorities

[GitHub] nifi issue #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be used by ...

2018-04-26 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2003 @Wesley-Lawrence is this ready for "final" review? If so, do you mind rebasing this PR against the latest master? There are some conflicts listed above. Please and thanks! ---

[GitHub] nifi issue #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be used by ...

2017-09-08 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2003 @Wesley-Lawrence I definitely think that's a reasonable approach. Sorry, just going through old PR's to make sure that I've followed up on everything. I like what's been outlined above. ---

[GitHub] nifi issue #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be used by ...

2017-08-17 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on the issue: https://github.com/apache/nifi/pull/2003 Yea, I think we're on the same page. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be used by ...

2017-08-17 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2003 @Wesley-Lawrence sorry - i must have missed the email that you'd commented on the PR. Sorry I didn't notice until now. So I think that what you're proposing here is that we should have a property

[GitHub] nifi issue #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be used by ...

2017-07-25 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on the issue: https://github.com/apache/nifi/pull/2003 @markap14 @mattyb149 Is there any other feedback you'd two like me to address? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] nifi issue #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be used by ...

2017-07-13 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on the issue: https://github.com/apache/nifi/pull/2003 @markap14 Good points. I actually considered adding a schema registry at first, but thought it might be too much for just making CSV in/out easier. I think using schemas falls into

[GitHub] nifi issue #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be used by ...

2017-07-13 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2003 @Wesley-Lawrence I definitely agree that having to build up an entire Avro schema can be a pain -- especially if you're not already familiar with Avro schemas. And I absolutely love that you saw