[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2016 @trixpan Similar to #2018, I took the liberty of taking over this PR into #2704. By cherry-picking your commits into my branch, so that we can respect your work and, when mine is merged, this PR will be closed properly. I've rebased with the latest master, check unit tests and expand the proxy supports to other AWS processors, such as DynamoDB, Kinesis and Lambda there. @trixpan @ottobackwards @pvillard31 Please keep reviewing these stuffs at #2704. It's ready for finalizing review process. Thanks! ---
[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2016 @trixpan can you de-conflict? ---
[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2016 in https://github.com/apache/nifi/pull/2588 I have done this as well, but only in my processor ( scope ). I would like to see this land. What can be done to move this forward? ---
[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2016 How can these be tested? ---
[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/2016 @pvillard31 will rebase and resubmit... ---
[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2016 Thanks @trixpan, what about my comment on ``displayName``? I know this is kind of cosmetic but when using proper ``name``, it makes things easier when moving templates from one environment to another and that values should be changed in the process. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/2016 hopefully fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2016 Hey @trixpan, regarding ``.displayName`` and ``.name``, I tend to think that we should use both for new properties in a processor, even though it is not the case for legacy properties. Besides, some tests are now failing: Failed tests: TestDeleteS3Object.testGetPropertyDescriptors:144 size should be eq expected:<20> but was:<22> TestFetchS3Object.testGetPropertyDescriptors:181 size should be eq expected:<14> but was:<16> TestListS3.testGetPropertyDescriptors:197 size should be eq expected:<15> but was:<17> TestPutS3Object.testGetPropertyDescriptors:153 size should be eq expected:<28> but was:<30> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/2016 Please note the displayName settings were not added as most of the AWS related processors lack these --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
