[GitHub] nifi issue #2023: NIFI-4206: Proxy instructions in Admin Guide

2017-08-10 Thread alopresto
Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/2023
  
I fixed a few formatting issues (see 
[e091b8f](https://github.com/alopresto/nifi/commit/e091b8fff5e8a6090b07cd8084bf4f7f76bc9424))
 but other than that it looks good to me. Ran `contrib-check` and all tests 
pass. +1, merging. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #2023: NIFI-4206: Proxy instructions in Admin Guide

2017-07-20 Thread mcgilman
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2023
  
@bond- Another commit has been pushed which includes a brief example for 
NiFi specific configuration. I am not super familiar with proxy configurations 
so if you have any additional suggestions that should be added just let me 
know. If you wanted to supply a patch with specific details based on your 
experience thus far, I'd be happy to include it in this PR. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---