Github user zenfenan commented on the issue:
https://github.com/apache/nifi/pull/2056
Pulled it and built it locally. Ran the template attached in
[NIFI-4028](https://issues.apache.org/jira/browse/NIFI-4028) and verified it to
be working as expected. Thanks @pvillard31 @markap14
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2056
@pvillard31 the code looks good to me, though I'm not in a state to easily
switch over my branch and merge. I'll try to get to it fairly soon but if
anyone else has the review cycles, then please
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2056
Rebased against master
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2056
Hey @markap14, I rebased against master and followed your recommandations.
Let me know if I missed something! Thanks for the review!
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2056
Done, thanks @mattyb149 !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2056
Mind rebasing this against the latest master? I made some changes in
MergeContent and I think that is causing it not to merge cleanly. Thanks in
advance!
---
If your project is set up for it, you
