[GitHub] nifi issue #2420: NIFI-4731

2018-10-04 Thread lsh-0 
Github user lsh-0 commented on the issue:

https://github.com/apache/nifi/pull/2420
  
I've just taken a look at the other two tickets and it looks like #3019 is 
the most recent one but is lacking the conversation/ticket history. As an 
outsider I can see that's three open tickets for one feature with a chain like 
#2420 -> #2682 -> #3019 .

I think at the very least this ticket (#2420) can be closed as it's quite 
definitely superceded.


---

[GitHub] nifi issue #2420: NIFI-4731

2018-10-04 Thread danieljimenez 
Github user danieljimenez commented on the issue:

https://github.com/apache/nifi/pull/2420
  
There are two other PRs that supersede this one.


---

[GitHub] nifi issue #2420: NIFI-4731

2018-10-04 Thread MikeThomsen 
Github user MikeThomsen commented on the issue:

https://github.com/apache/nifi/pull/2420
  
> May I ask what is currently blocking it?

@nologic appears to have not addressed all of the review feedback.

@joewitt I can rebase and address the author tags. If the tests run, I can 
merge myself. You want to do that?


---

[GitHub] nifi issue #2420: NIFI-4731

2018-10-03 Thread lsh-0 
Github user lsh-0 commented on the issue:

https://github.com/apache/nifi/pull/2420
  
hi guys - I've just introduced NiFi at work, [found and built 
this](https://github.com/sand0id/nifi-bigquery-bundle), discovered it's many 
limitations and was about to rewrite it when I found this ticket!

May I ask what is currently blocking it? 


---

[GitHub] nifi issue #2420: NIFI-4731

2018-02-22 Thread joewitt 
Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/2420
  
please address the author tags.

On Feb 22, 2018 8:57 PM, "nologic"  wrote:

> cool, all checks have passed. Is there anything else you need need before
> this thing gets scheduled for a merge?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> , or mute
> the thread
> 

> .
>



---

[GitHub] nifi issue #2420: NIFI-4731

2018-02-22 Thread nologic 
Github user nologic commented on the issue:

https://github.com/apache/nifi/pull/2420
  
cool, all checks have passed. Is there anything else you need need before 
this thing gets scheduled for a merge?


---

[GitHub] nifi issue #2420: NIFI-4731

2018-02-02 Thread joewitt 
Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/2420
  
It is 164 violations but all very easy things to fix.  It is possible there 
was some newline issues in generating the PR or just some IDE formatting thing 
can be run.  But it should be super easy to fixup


---

[GitHub] nifi issue #2420: NIFI-4731

2018-02-02 Thread MikeThomsen 
Github user MikeThomsen commented on the issue:

https://github.com/apache/nifi/pull/2420
  
It's whack-a-mole. To see many/all of them at once do this from the source 
root:

`mvn clean install -Pcontrib-check :nifi-gcp-processors`

(I didn't look closely. I'm assuming `nifi-gcp-processors` was the maven 
module that was failing. It needs to be the failing maven module's maven name + 
`:` at the start to tell Maven to only build that one module w/ the full 
contrib-check profile)

Then you just keep changing until you make stylecheck happy.


---

[GitHub] nifi issue #2420: NIFI-4731

2018-02-01 Thread nologic 
Github user nologic commented on the issue:

https://github.com/apache/nifi/pull/2420
  
@MikeThomsen seems like a lot of violations, what's the best way to clear 
these up?


---

[GitHub] nifi issue #2420: NIFI-4731

2018-01-22 Thread MikeThomsen 
Github user MikeThomsen commented on the issue:

https://github.com/apache/nifi/pull/2420
  
@nologic Log said you have 164 checkstyle violations in nifi-gcp-processors.


---