Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2477
+1. Just a remark: the version of commons-io does not need to be specified
in the toolkit-cli pom file as it's already defined in the root pom. Will take
care of it while merging. Thanks for the
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2477
Will have a final review today.
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2477
@pvillard31 since you tested this out a bit, would you be able to give a
final review & merge?
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2477
Fixed the issue with returning the appropriate exit code in standalone
mode. An example of testing this would be running a script like the following:
```
#!/bin/sh
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2477
@bbende agree with your points: we can keep things as-is for now and have a
larger effort for documentation with follow-up JIRAs.
@aperepel I *really* believe that online documentation
Github user aperepel commented on the issue:
https://github.com/apache/nifi/pull/2477
@pvillard31 we were discussing a modular design for commands with dynamic
discovery/loading (e.g. via Java's ServiceLoader mechanism). This is to support
the idea that we should try to incorporate
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2477
@pvillard31 thanks for the feedback! Regarding the docs...
Long-term I do agree that our admin guide has become quite lengthy and hard
to find information, and we should probably spin-off a
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2477
Played a bit with the cli and it's really cool. Amazing job @bbende &
@aperepel!
Can we consider adding an online documentation for it (in addition to the
README)? I think @andrewmlim is
Github user fcntl commented on the issue:
https://github.com/apache/nifi/pull/2477
+1 this is a very useful module to automate things like Nifi integration
with the Registry.
---
