Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2497
@mosermw Looks great! Thanks, this has been merged to master.
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2497
Hi @mcgilman I made the suggested changes, rebased from master, and force
pushed to this branch. What do you think?
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2497
@mosermw Didn't really have a great option... so the suggestion was
ultimately a compromise. The idea was that About returns information about this
instance of NiFi. This could include some configura
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2497
@mcgilma @markap14 I'm not sure I was able to fully grok "add a ConfigDTO
which is set on the AboutDTO" but I gave it a shot. Rebased from master and
pushed a new commit. Let me know what you think,
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2497
@mosermw @markap14 It's kind of a gray area. I suggested an endpoint like
the /nifi-api/flow/about because that seemed like the best fit currently and
was obviously trying to avoid requiring another
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2497
@markap14 and @mcgilman I did consider that backpressure settings didn't
really belong in AboutDTO. The BannerDTO also pulls information from
nifi.properties, but I didn't think backpressure fit there
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2497
@mosermw I think this is a pretty reasonable change. The only thing that
gives me pause is putting this information into AboutDTO. To me, it doesn't
feel like the right place for this kind of informa
