[GitHub] nifi issue #2601: NIFI-3576 Support for QueryInfo relationship, useful for n...
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2601 Thanks for the review time! ---
[GitHub] nifi issue #2601: NIFI-3576 Support for QueryInfo relationship, useful for n...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2601 Tested it out with a live instance of ElasticSearch and it behaved the way I expected it. Though there appears to be a bug in the pagination itself with getPage, but that's a separate Jira ticket from what I can tell. ---
[GitHub] nifi issue #2601: NIFI-3576 Support for QueryInfo relationship, useful for n...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2601 Unit test failures: ``` [ERROR] testQueryElasticsearchOnTrigger_NoHits_NoHits(org.apache.nifi.processors.elasticsearch.TestQueryElasticsearchHttpNoHits) Time elapsed: 0.001 s <<< ERROR! java.lang.IllegalArgumentException: No enum constant org.apache.nifi.processors.elasticsearch.QueryElasticsearchHttp.QueryInfoRouteStrategy.noHits at org.apache.nifi.processors.elasticsearch.TestQueryElasticsearchHttpNoHits.testQueryElasticsearchOnTrigger_NoHits_NoHits(TestQueryElasticsearchHttpNoHits.java:75) [ERROR] testQueryElasticsearchOnTrigger_Hits_Always(org.apache.nifi.processors.elasticsearch.TestQueryElasticsearchHttpNoHits) Time elapsed: 0.002 s <<< ERROR! java.lang.IllegalArgumentException: No enum constant org.apache.nifi.processors.elasticsearch.QueryElasticsearchHttp.QueryInfoRouteStrategy.always at org.apache.nifi.processors.elasticsearch.TestQueryElasticsearchHttpNoHits.testQueryElasticsearchOnTrigger_Hits_Always(TestQueryElasticsearchHttpNoHits.java:185) [ERROR] testQueryElasticsearchOnTrigger_Hits_NoHits(org.apache.nifi.processors.elasticsearch.TestQueryElasticsearchHttpNoHits) Time elapsed: 0.001 s <<< ERROR! java.lang.IllegalArgumentException: No enum constant org.apache.nifi.processors.elasticsearch.QueryElasticsearchHttp.QueryInfoRouteStrategy.noHits at org.apache.nifi.processors.elasticsearch.TestQueryElasticsearchHttpNoHits.testQueryElasticsearchOnTrigger_Hits_NoHits(TestQueryElasticsearchHttpNoHits.java:141) ``` ---
[GitHub] nifi issue #2601: NIFI-3576 Support for QueryInfo relationship, useful for n...
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2601 bump ---
[GitHub] nifi issue #2601: NIFI-3576 Support for QueryInfo relationship, useful for n...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2601 @ottobackwards Follow up from your reference to this in the `QuerySolr` PR... If you've got a use case where you need to get stats from ES, check out `JsonQueryElasticsearch`. It uses the JSON DSL and has relationships for aggregations so you can run them and split them up into separate JSON documents. ---
[GitHub] nifi issue #2601: NIFI-3576 Support for QueryInfo relationship, useful for n...
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2601 @MikeThomsen This isn't my use case. I am just helping with the work. Please refer to the jira ---
[GitHub] nifi issue #2601: NIFI-3576 Support for QueryInfo relationship, useful for n...
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2601 Added checkstyle fixes ---
[GitHub] nifi issue #2601: NIFI-3576 Support for QueryInfo relationship, useful for n...
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2601 I apologize, I had thought I ran contrib-check, but I obviously didn't ---
[GitHub] nifi issue #2601: NIFI-3576 Support for QueryInfo relationship, useful for n...
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2601 Reviewing... ---