[GitHub] nifi issue #2604: NIFI-5027 Adding pg-get-services command

2018-04-04 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2604 Just did some more testing and it looks good to me. Thanks for all the improvements. Just a note about the response code: it's equal to 255 on my Mac, but as long as it's not equal to 0, it's good

[GitHub] nifi issue #2604: NIFI-5027 Adding pg-get-services command

2018-04-04 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/2604 @pvillard31 I just rebased and forced push, can you give this another try? The main changes since what you last tried this morning are the following... - In standalone you can use -verbose t

[GitHub] nifi issue #2604: NIFI-5027 Adding pg-get-services command

2018-04-04 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2604 Thanks @bbende. With your last changes: #> nifi pg-enable-services -pgid &2 -u http://localhost:8080 Using a positional back-reference for 'Test 2 - Misconfigured CS' C

[GitHub] nifi issue #2604: NIFI-5027 Adding pg-get-services command

2018-04-03 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/2604 @pvillard31 thanks for the very thorough review, I'll take a look at some of these tomorrow and see what improvements can be made. Regarding the lack of feedback on some commands... T

[GitHub] nifi issue #2604: NIFI-5027 Adding pg-get-services command

2018-04-03 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2604 Did multiple tests with different scenarios (I attached to the JIRA a template to test each scenario - cannot attached an XML file here). **Test 1** - Normal case, processors relying on a s

[GitHub] nifi issue #2604: NIFI-5027 Adding pg-get-services command

2018-04-03 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2604 Giving it a try... ---