[GitHub] nifi issue #2605: NIFI-4862: Keep incoming flowfile attributes in outgoing f...

2018-04-09 Thread ijokarumawak 
Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/2605
  
@mattyb149 Thanks for the fix. I confirmed the attributes in the incoming 
FlowFile are carried to the outgoing FlowFiles. Two FlowFiles were created by 
SelectHiveQL in the flow below, from 1 incoming FlowFile. NiFi provenance 
events look correct. I was able to render following graph with Atlas.


![image](https://user-images.githubusercontent.com/1107620/38484186-b66e3a74-3c10-11e8-8924-5b0d40f18003.png)


![image](https://user-images.githubusercontent.com/1107620/38484739-8577ef58-3c12-11e8-8e90-dffccbab104d.png)


![image](https://user-images.githubusercontent.com/1107620/38484149-931fb034-3c10-11e8-92fd-0931bf05df48.png)

LGTM +1, merging to master.


---

[GitHub] nifi issue #2605: NIFI-4862: Keep incoming flowfile attributes in outgoing f...

2018-04-06 Thread ijokarumawak 
Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/2605
  
@mattyb149 I'm going to review it, thanks!


---

[GitHub] nifi issue #2605: NIFI-4862: Keep incoming flowfile attributes in outgoing f...

2018-04-04 Thread mattyb149 
Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/2605
  
@ijokarumawak Mind taking a look at this one? It changed the order of 
provenance events so it touched your code for emitting a FETCH-FORK (now it's a 
FORK-FETCH). Just want to make sure the provenance chain is clear, simple, and 
complete. Thanks in advance!


---