[GitHub] nifi issue #2609: NIFI-5047 Fixed a bug in PutMongo that prevented it from w...

2018-04-06 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2609 +1, merging to master, thanks @MikeThomsen ---

[GitHub] nifi issue #2609: NIFI-5047 Fixed a bug in PutMongo that prevented it from w...

2018-04-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2609 mvn install with contrib-check runs fine, tests look good. +1 ( fwiw) ---

[GitHub] nifi issue #2609: NIFI-5047 Fixed a bug in PutMongo that prevented it from w...

2018-04-06 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2609 NP. ---

[GitHub] nifi issue #2609: NIFI-5047 Fixed a bug in PutMongo that prevented it from w...

2018-04-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2609 I apologize, I miss read it as a test for one thing, not multiple. I missed the top part. Please excuse me ---

[GitHub] nifi issue #2609: NIFI-5047 Fixed a bug in PutMongo that prevented it from w...

2018-04-06 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2609 That's what the unit test is supposed to provide. ---

[GitHub] nifi issue #2609: NIFI-5047 Fixed a bug in PutMongo that prevented it from w...

2018-04-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2609 Should there be a test for just the INSERT mode that corresponds to the problem too? ---

[GitHub] nifi issue #2609: NIFI-5047 Fixed a bug in PutMongo that prevented it from w...

2018-04-06 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2609 I tested this with a unit test and a flow that exercised all three options for PutMongo separately, so it should be good now. ---