[GitHub] nifi issue #2782: NIFI-5292 Renamed ElasticSearch client service impl to sho...

2018-07-06 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2782 @zenfenan can you review? It's mostly copy pasta from the ES v5 client. ---

[GitHub] nifi issue #2782: NIFI-5292 Renamed ElasticSearch client service impl to sho...

2018-06-14 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2782 @markap14 I cleaned it up and got most of what I suggested done. Couldn't figure out a good way to detect the protocol ranges, but this should do. ---

[GitHub] nifi issue #2782: NIFI-5292 Renamed ElasticSearch client service impl to sho...

2018-06-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2782 @markap14 Ok, that's fair. I think the general issue has to be addressed, but the easy route is obviously blocked. So what I'm going to do to try to head this is off is: 1. Rip out the ch

[GitHub] nifi issue #2782: NIFI-5292 Renamed ElasticSearch client service impl to sho...

2018-06-12 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2782 Hey @MikeThomsen when we discussed the renaming on the mailing list, I was under the impression that the Elasticsearch Client Service was new for 1.7.0. But it appears that it already has been releas

[GitHub] nifi issue #2782: NIFI-5292 Renamed ElasticSearch client service impl to sho...

2018-06-11 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2782 @markap14 can you review? @joewitt can you review the L&N? I took a stab at updating the v6 client's NOTICE, but am not sure if it's right. ---

[GitHub] nifi issue #2782: NIFI-5292 Renamed ElasticSearch client service impl to sho...

2018-06-11 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2782 Looked over the transitive dependencies and HdrHistogram ([license info; appears public domain](https://github.com/HdrHistogram/HdrHistogram/blob/master/LICENSE.txt)) and SnakeYaml (ASL, unknown