[GitHub] nifi issue #2830: NIFI-4889: Logout not working properly with OIDC
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2830 Looks good @Trojan295. Thanks! This has been merged to master. ---
[GitHub] nifi issue #2830: NIFI-4889: Logout not working properly with OIDC
Github user Trojan295 commented on the issue: https://github.com/apache/nifi/pull/2830 I added a fallback to simply redirect back to NiFi in case the end session endpoint isn't present. Tricky thing is, that NiFi automatically starts an login attempt, when an unauthenticated user accesses NiFi. In case of an IDP like Keycloak, which has the end session endpoint, then after logout the user is redirected back to Keycloaks login page. In case of Google OpenID he gets redirected to them and the SSO mechanism logs the user again... ---
[GitHub] nifi issue #2830: NIFI-4889: Logout not working properly with OIDC
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2830 @Trojan295 Thanks for the PR! The code looks good but I ran into an issue when attempting to log out. Despite being a required field in the openid spec [1], it appears that at least in practice [2] the `end_session_endpoint` field is not guaranteed to be present. I think we may need to account for this possibility in the logout endpoint. [1] https://openid.net/specs/openid-connect-session-1_0.html#OPMetadata [2] https://accounts.google.com/.well-known/openid-configuration ---
[GitHub] nifi issue #2830: NIFI-4889: Logout not working properly with OIDC
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2830 Will review... ---
[GitHub] nifi issue #2830: NIFI-4889: Logout not working properly with OIDC
Github user Trojan295 commented on the issue: https://github.com/apache/nifi/pull/2830 Rebased from current master ---
[GitHub] nifi issue #2830: NIFI-4889: Logout not working properly with OIDC
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2830 @Trojan295 - NiFi 1.7.0 has been released, I'd recommend you to rebase against master (so that all the pom files are updated to 1.8.0-SNAPSHOT) and do a full build to have a clean local maven repo (you shouldn't have 1.7.0-SNAPSHOT anymore). All the Travis builds are OK for your PR so it sounds OK to me. Regarding the PR itself, I'll let someone like @mcgilman having a look ;) ---
[GitHub] nifi issue #2830: NIFI-4889: Logout not working properly with OIDC
Github user Trojan295 commented on the issue: https://github.com/apache/nifi/pull/2830 When running the test suite locally I have problems with an dependency: ``` [ERROR] Failed to execute goal on project nifi-hive-processors: Could not resolve dependencies for project org.apache.nifi:nifi-hive-processors:jar:1.7.0-SNAPSHOT: Could not find artifact org.pentaho:pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde in central (https://repo1.maven.org/maven2) -> [Help 1] ``` I had to add an additional repository to make it work, although I didn't commit it: ``` spring-plugins http://repo.spring.io/plugins-release false true ``` Could it be, that the artifact was in Maven Central and was moved, but the CI on Travis as it cached in the local repo? ---
