[GitHub] nifi issue #3156: NIFI-5780 Add pre and post statements to ExecuteSQL and Ex...

2018-11-15 Thread patricker 
Github user patricker commented on the issue:

https://github.com/apache/nifi/pull/3156
  
+1 Looks good. Built and tested. I ran into one issue that I might submit a 
seperate enhancement for (allowing `;` in the SQL string if they are surrounded 
by `'` or `"`).


---

[GitHub] nifi issue #3156: NIFI-5780 Add pre and post statements to ExecuteSQL and Ex...

2018-11-15 Thread patricker 
Github user patricker commented on the issue:

https://github.com/apache/nifi/pull/3156
  
Sorry for the delay, been having issues with a bug that just got fixed in 
NIFI-5822. Will wrap up testing.


---

[GitHub] nifi issue #3156: NIFI-5780 Add pre and post statements to ExecuteSQL and Ex...

2018-11-09 Thread yjhyjhyjh0 
Github user yjhyjhyjh0 commented on the issue:

https://github.com/apache/nifi/pull/3156
  
Thanks for the suggestion.
Update description to be more precise in ExecuteSQL, ExecuteSQLRecord, 
SelectHiveQL.
Squash the this commit.


---