[GitHub] nifi issue #362: NIFI-1769: added support for SSE-KMS and signature s3v4 aut...

2016-10-11 Thread miquillo
Github user miquillo commented on the issue: https://github.com/apache/nifi/pull/362 @jvwing OUCH! that's painfull to see it's exactly similar to what we've build.. :( I reviewed the code and it seems that it is more mature than our solution and VERY similar :) I'll leave my

[GitHub] nifi issue #362: NIFI-1769: added support for SSE-KMS and signature s3v4 aut...

2016-10-10 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/362 @miquillo, I'll take another look at the SSE change, but I would like to keep this PR focused on just SSE. We'll need additional tickets and PRs for additional changes. Also, you might take

[GitHub] nifi issue #362: NIFI-1769: added support for SSE-KMS and signature s3v4 aut...

2016-10-10 Thread miquillo
Github user miquillo commented on the issue: https://github.com/apache/nifi/pull/362 @jvwing So it has been a bit silent here, but we continued last week and now we've merged the current master branch into this project. This is where I realized you've implemented the S3v4 (along with