[GitHub] nifi issue #675: LSB Adherence

[michalklempa]

Github user michalklempa commented on the issue:

https://github.com/apache/nifi/pull/675
  
@trixpan regarding any "defaultCharset" issues, I guess, that author was 
thinking about what Java process sees as the default charset of the system it 
runs on. I have seen it couple of times, that Java developers tend to set the 
charset (see http://stackoverflow.com/a/31644153). It is mainly because Java 
writers let those methods like String.getBytes() to behave not statically -> 
said in documentation it will return always UTF-8 transformation to bytes, but 
these argless functions behave 'system-dependent' way - Java tries to figure 
out the Locale on the system it is running... you know. It causes o lot of 
headaches, mainly for Java newbies.
But if NiFi is coded properly, and every such function call is used only in 
argument-aware version, default charset is not even used inside JVM at runtime, 
nobody simply ask for it by calling Charset.defaultCharset or String.getBytes 
or other Java gotchas String>byte manipulation function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #675: LSB Adherence

[PuspenduBanerjee]

Github user PuspenduBanerjee commented on the issue:

https://github.com/apache/nifi/pull/675
  
closing as commented to have already been resolved by:

- LSB compliant exit codes -> 99d3c39
- SSH restart hangs -> 88d1251


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #675: LSB Adherence

[trixpan]

Github user trixpan commented on the issue:

https://github.com/apache/nifi/pull/675
  
@PuspenduBanerjee 

The following commits seem to solve some this issues:

* LSB compliant exit codes -> 99d3c397481a98a5b3d2d4e44b84516fc0e3675e
* SSH restart hangs -> 88d125137e3bf3faf80b522edf5cf14f99419d60

Wonder if there's any further issue holding us from closing this PR?

Back in the JIRA ticket, @evega mentions that :

> The defaultCharset / locale isnt being set correct

But I am not sure what the issue is? 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #675: LSB Adherence

[michalklempa]

Github user michalklempa commented on the issue:

https://github.com/apache/nifi/pull/675
  
This approach is too complicated. Why clutter with grepping output when we 
can fix the RunNifi.java


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #675: LSB Adherence

[PuspenduBanerjee]

Github user PuspenduBanerjee commented on the issue:

https://github.com/apache/nifi/pull/675
  
taking care of a personal emergency at my native place in India and will
not be available till 17th Oct. Sorry for any inconvenience.


Thanks & Regards,
Puspendu Banerjee

On Thu, Oct 6, 2016 at 9:07 AM, trixpan  wrote:

> @apiri  have a look on
>
> #1092 
>
> and
>
> #1093 
>
> Which are essentially addressing a number of the issues discussed here.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #675: LSB Adherence

[trixpan]

Github user trixpan commented on the issue:

https://github.com/apache/nifi/pull/675
  
@apiri have a look on 

https://github.com/apache/nifi/pull/1092

and

https://github.com/apache/nifi/pull/1093

Which are essentially addressing a number of the issues discussed here.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #675: LSB Adherence

[apiri]

Github user apiri commented on the issue:

https://github.com/apache/nifi/pull/675
  
It was my understanding there were to be some modifications based on the 
last review and then we would commit that to capture the effort already done 
with follow on work to get completely there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #675: LSB Adherence

[trixpan]

Github user trixpan commented on the issue:

https://github.com/apache/nifi/pull/675
  
@PuspenduBanerjee From what I understand from the trail, we can close PR?

Best regards


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #675: LSB Adherence

[PuspenduBanerjee]

Github user PuspenduBanerjee commented on the issue:

https://github.com/apache/nifi/pull/675
  
Agreed. That sounds like a plan!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #675: LSB Adherence

[apiri]

Github user apiri commented on the issue:

https://github.com/apache/nifi/pull/675
  
Hey @PuspenduBanerjee, in the interest of wrapping this up, maybe we can 
just take your changes as presented with the adjustments mentioned above and 
then create a new JIRA to explore addressing the needs of the service from the 
standpoint of the actual start of the application itself.  These changes 
certainly provide some nice utility that, even in the case the app would not 
start, would be able to help the CM tools carry out their function on a 
successive pass/health check.

Let me know your thoughts!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #675: LSB Adherence

[PuspenduBanerjee]

Github user PuspenduBanerjee commented on the issue:

https://github.com/apache/nifi/pull/675
  
Thanks @apiri . Please let me know in case there is any gap.

Thanks & Regards,
Puspendu Banerjee

On Jul 24, 2016 6:07 PM, "Aldrin Piri"  wrote:

Hey @PuspenduBanerjee , sorry for the
delay. Will scope this out in the next day or so.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
, or mute
the thread


.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #675: LSB Adherence

[apiri]

Github user apiri commented on the issue:

https://github.com/apache/nifi/pull/675
  
Hey @PuspenduBanerjee, sorry for the delay.  Will scope this out in the 
next day or so.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---