[GitHub] nifi pull request #1001: NIFI-2750 Add Optional Column Name Quoting to Conve...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1001 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1001: NIFI-2750
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1001#discussion_r83530556 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java --- @@ -254,6 +264,9 @@ public void onTrigger(final ProcessContext context, final ProcessSession session final boolean failUnmappedColumns = FAIL_UNMATCHED_COLUMN.getValue().equalsIgnoreCase(context.getProperty(UNMATCHED_COLUMN_BEHAVIOR).getValue()); final boolean warningUnmappedColumns = WARNING_UNMATCHED_COLUMN.getValue().equalsIgnoreCase(context.getProperty(UNMATCHED_COLUMN_BEHAVIOR).getValue()); +//Escape column names? +final boolean escapeColumnNames = "true".equalsIgnoreCase(context.getProperty(QUOTED_IDENTIFIERS).getValue()); --- End diff -- nice way of assigning the value! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1001: Nifi 2750
GitHub user patricker opened a pull request: https://github.com/apache/nifi/pull/1001 Nifi 2750 Adds quoted identifier support to ConvertJSONToSQL; enabled through an optional property, false by default. You can merge this pull request into a Git repository by running: $ git pull https://github.com/patricker/nifi NIFI-2750 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1001.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1001 commit 29c6a77d7655eaed220aa878141564467c815274 Author: Peter Wicks Date: 2016-09-10T03:10:26Z NIFI-2750 commit ab3b9173f340f7b58eb4e8380bcb376b9808be8a Author: Peter Wicks Date: 2016-09-10T04:45:53Z NIFI-2750 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
