[GitHub] nifi pull request #2070: NIFI-4275 Adding support for specifying the timesta...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2070 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #2070: NIFI-4275 Adding support for specifying the timesta...
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2070#discussion_r132390344
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java
---
@@ -58,6 +60,16 @@
protected static final PropertyDescriptor ROW_FIELD_NAME = new
PropertyDescriptor.Builder()
.name("Row Identifier Field Name")
.description("Specifies the name of a record field whose value
should be used as the row id for the given record.")
+.required(true)
+.expressionLanguageSupported(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+
+protected static final PropertyDescriptor TIMESTAMP_FIELD_NAME = new
PropertyDescriptor.Builder()
+.name("Timestamp Field Name")
--- End diff --
+ displayName
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2070: NIFI-4275 Adding support for specifying the timesta...
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2070#discussion_r132390001
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java
---
@@ -317,18 +333,34 @@ protected PutFlowFile createPut(ProcessContext
context, Record record, RecordSch
final byte[] fam = clientService.toBytes(columnFamily);
+final Long timestamp;
+if (!StringUtils.isBlank(timestampFieldName)) {
+try {
+timestamp = record.getAsLong(timestampFieldName);
--- End diff --
Could the record be null here? (I assume it could since we're checking the
record is not null few lines below)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2070: NIFI-4275 Adding support for specifying the timesta...
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2070#discussion_r132390262
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/AbstractPutHBase.java
---
@@ -98,6 +98,12 @@
.expressionLanguageSupported(true)
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
+protected static final PropertyDescriptor TIMESTAMP = new
PropertyDescriptor.Builder()
+.name("Timestamp")
--- End diff --
+ displayName
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2070: NIFI-4275 Adding support for specifying the timesta...
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/2070 NIFI-4275 Adding support for specifying the timestamp on PutHBase pro⦠â¦cessors You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende/nifi NIFI-4275 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2070.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2070 commit 73a3ffc650a4a3a6936757ce8f9f2310eee3bf5c Author: Bryan Bende Date: 2017-08-09T18:01:19Z NIFI-4275 Adding support for specifying the timestamp on PutHBase processors --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
