[GitHub] nifi pull request #2391: NIFI-4747 - Removed directory existence check in Ge...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2391


---

[GitHub] nifi pull request #2391: NIFI-4747 - Removed directory existence check in Ge...

[pvillard31]

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2391#discussion_r162701033
  
--- Diff: 
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFS.java
 ---
@@ -220,16 +220,6 @@
 .explanation(MIN_AGE.getName() + " cannot be greater 
than " + MAX_AGE.getName()).build());
 }
 
-try {
--- End diff --

you're absolutely right, thanks! reverted this and added a unit test for 
the expected use case.


---

[GitHub] nifi pull request #2391: NIFI-4747 - Removed directory existence check in Ge...

[bbende]

Github user bbende commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2391#discussion_r162655242
  
--- Diff: 
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFS.java
 ---
@@ -220,16 +220,6 @@
 .explanation(MIN_AGE.getName() + " cannot be greater 
than " + MAX_AGE.getName()).build());
 }
 
-try {
--- End diff --

I'm not sure we should remove this, see this JIRA: 
https://issues.apache.org/jira/browse/NIFI-2553


---

[GitHub] nifi pull request #2391: NIFI-4747 - Removed directory existence check in Ge...

[bbende]

Github user bbende commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2391#discussion_r162655326
  
--- Diff: 
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/test/java/org/apache/nifi/processors/hadoop/GetHDFSTest.java
 ---
@@ -224,17 +224,6 @@ public void testDirectoryUsesValidEL() throws 
IOException {
 
assertTrue(receiveEvent.getTransitUri().endsWith("13545423550275052.zip"));
 }
 
-@Test
-public void testDirectoryUsesUnrecognizedEL() throws IOException {
--- End diff --

Same as previous comment


---

[GitHub] nifi pull request #2391: NIFI-4747 - Removed directory existence check in Ge...

[pvillard31]

GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/2391

NIFI-4747 - Removed directory existence check in GetHDFS

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-4747

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2391.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2391


commit a57ce704015e34de68e36916f4dff5c65c0bd30f
Author: Pierre Villard 
Date:   2018-01-09T16:45:51Z

NIFI-4747 - Removed directory existence check in GetHDFS




---