[GitHub] nifi pull request #2470: NIFI-4864 Fixing additional resources property poin...

2018-03-13 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2470


---

[GitHub] nifi pull request #2470: NIFI-4864 Fixing additional resources property poin...

2018-02-16 Thread zenfenan 
Github user zenfenan commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2470#discussion_r168821276
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
 ---
@@ -3447,11 +3448,32 @@ public void startReportingTask(final 
ReportingTaskNode reportingTaskNode) {
 if (isTerminated()) {
 throw new IllegalStateException("Cannot start reporting task " 
+ reportingTaskNode.getIdentifier() + " because the controller is terminated");
 }
-
+validateAdditionalResourcesFingerprint(reportingTaskNode);
 reportingTaskNode.verifyCanStart();
 processScheduler.schedule(reportingTaskNode);
 }
 
+private void validateAdditionalResourcesFingerprint(ReportingTaskNode 
reportingTaskNode){
--- End diff --

Point. Also needed to handle edge case on 
ClassLoaderUtils.generateAdditionalUrlsFingerprint(). Added that change as well.


---

[GitHub] nifi pull request #2470: NIFI-4864 Fixing additional resources property poin...

2018-02-15 Thread bbende 
Github user bbende commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2470#discussion_r168568930
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
 ---
@@ -3447,11 +3448,32 @@ public void startReportingTask(final 
ReportingTaskNode reportingTaskNode) {
 if (isTerminated()) {
 throw new IllegalStateException("Cannot start reporting task " 
+ reportingTaskNode.getIdentifier() + " because the controller is terminated");
 }
-
+validateAdditionalResourcesFingerprint(reportingTaskNode);
 reportingTaskNode.verifyCanStart();
 processScheduler.schedule(reportingTaskNode);
 }
 
+private void validateAdditionalResourcesFingerprint(ReportingTaskNode 
reportingTaskNode){
--- End diff --

It seems like this method is very similar to the code needed in the 
controller service provider and the standard process group... since all three 
node types extend from AbstractConfiguredComponent, would it be possible to 
create a single method there like `void reloadIfNecessary()` (or some better 
name) ? 

The logic for calculating the fingerprint, comparing to the existing one, 
and reloading if different should all be able to implemented generically for 
any AbstractConfiguredComponent since the existing fingerprint is already 
stored there.


---

[GitHub] nifi pull request #2470: NIFI-4864 Fixing additional resources property poin...

2018-02-14 Thread zenfenan 
GitHub user zenfenan opened a pull request:

https://github.com/apache/nifi/pull/2470

NIFI-4864 Fixing additional resources property pointing to directory won't 
find new resources

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zenfenan/nifi NIFI-4864

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2470.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2470


commit d1290d03e68cac77e6e1f332368bbadc8ced9043
Author: zenfenaan 
Date:   2018-01-12T17:15:13Z

NIFI-4770 ListAzureBlobStorage now properly writes azure.container flowfile 
attribute

commit 615f3ebc10d94f37c7463ae2d240582397e6ce8c
Author: zenfenan 
Date:   2018-01-23T16:30:38Z

Merge branch 'master' of https://github.com/apache/nifi

commit f597a9b7aa11a48ff46931b73da216c8426542e4
Author: zenfenan 
Date:   2018-01-26T04:42:32Z

Merge remote-tracking branch 'nifi/master'

commit b546f22cfe103eca83f2e32b71d0011927a7f0ce
Author: zenfenan 
Date:   2018-01-29T09:53:35Z

Merge remote-tracking branch 'nifi/master'

commit d0b14da7ab85006a9f8ea1c936e2fdfe18966f7e
Author: zenfenan 
Date:   2018-02-12T15:09:48Z

Merge remote-tracking branch 'nifi/master'

commit f3ced742604924964926e5ee2c4ce271fb5bb9bf
Author: zenfenan 
Date:   2018-02-14T16:09:04Z

NIFI-4864 Fixing Additional Resources property pointing at a directory 
won't find new JARs




---