[GitHub] nifi pull request #2776: NIFI-5284: Added JSON_TYPE support to RunMongoAggre...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2776 ---
[GitHub] nifi pull request #2776: NIFI-5284: Added JSON_TYPE support to RunMongoAggre...
Github user zenfenan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2776#discussion_r194246883
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
---
@@ -275,4 +303,13 @@ protected void writeBatch(String payload, FlowFile
parent, ProcessContext contex
session.getProvenanceReporter().receive(flowFile, getURI(context));
session.transfer(flowFile, rel);
}
+
+protected void configureMapper(String setting) {
--- End diff --
@MikeThomsen I again went through the link @joewitt shared. Anyway, we are
configuring `objectMapper` before using it, at least in this case. That
guarantees thread safety. https://stackoverflow.com/a/3909846/2973446. Anyway I
have marked it synchronized. Let me know, if there are any concerns.
@joewitt If you see something odd with this one, please share it over here.
---
[GitHub] nifi pull request #2776: NIFI-5284: Added JSON_TYPE support to RunMongoAggre...
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2776#discussion_r194235387
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
---
@@ -275,4 +303,13 @@ protected void writeBatch(String payload, FlowFile
parent, ProcessContext contex
session.getProvenanceReporter().receive(flowFile, getURI(context));
session.transfer(flowFile, rel);
}
+
+protected void configureMapper(String setting) {
--- End diff --
I don't think this is thread-safe based on the PR for your JSON validator.
We should move the mapper into onTrigger to be safe.
---
[GitHub] nifi pull request #2776: NIFI-5284: Added JSON_TYPE support to RunMongoAggre...
GitHub user zenfenan opened a pull request: https://github.com/apache/nifi/pull/2776 NIFI-5284: Added JSON_TYPE support to RunMongoAggregation Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zenfenan/nifi NIFI-5284 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2776.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2776 commit b963fb76b96edd383e6fda1568ea21fd49a69990 Author: zenfenan Date: 2018-06-09T12:05:59Z NIFI-5284: Added JSON_TYPE support to RunMongoAggregation ---
