Re: [PR] NIFI-15692 Use standard GitLab files API instead of raw file endpoint [nifi]
pvillard31 closed pull request #10991: NIFI-15692 Use standard GitLab files API instead of raw file endpoint URL: https://github.com/apache/nifi/pull/10991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] NIFI-15692 Use standard GitLab files API instead of raw file endpoint [nifi]
pvillard31 commented on PR #10991: URL: https://github.com/apache/nifi/pull/10991#issuecomment-4033832688 Will close and we can follow up with the reporter on the JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] NIFI-15692 Use standard GitLab files API instead of raw file endpoint [nifi]
exceptionfactory commented on PR #10991: URL: https://github.com/apache/nifi/pull/10991#issuecomment-4033806985 Thanks @pvillard31, with smaller volume in general, I agree that buffering the bytes of the content is not necessarily a major issue. As it stands, the current implementation should avoid the extra intermediate copy of the content, instead reading the bytes when parsing the response to an object. Thus the change is not great, but probably not the worst case scenario. It seems best to get more understanding of the reverse proxy configuration before going forward. The proxy server has the ability to control response headers and status codes, so it is not yet clear from either the Jira issue, or the linked GitLab library issue, which this requires changing the retrieval strategy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] NIFI-15692 Use standard GitLab files API instead of raw file endpoint [nifi]
pvillard31 commented on PR #10991: URL: https://github.com/apache/nifi/pull/10991#issuecomment-4033626308 Both are fair points. I don't think buffering the whole flow in memory is really a problem given that versioned flows are in NiFi's memory anyway (if the process group is on the canvas we have the object already). Regarding the proxy configuration, I won't be able to comment for the author of the JIRA but it does seem to be a source of issue with the client library we use in the Github issue linked in the JIRA with what seems to be some redirect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] NIFI-15692 Use standard GitLab files API instead of raw file endpoint [nifi]
pvillard31 opened a new pull request, #10991: URL: https://github.com/apache/nifi/pull/10991 # Summary NIFI-15692 Use standard GitLab files API instead of raw file endpoint # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` - [ ] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
