[jira] [Commented] (MINIFICPP-454) Builds don't effectively pull system OpenSSL for rpi

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439847#comment-16439847
 ] 

ASF GitHub Bot commented on MINIFICPP-454:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/299


> Builds don't effectively pull system OpenSSL for rpi
> 
>
> Key: MINIFICPP-454
> URL: https://issues.apache.org/jira/browse/MINIFICPP-454
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>Priority: Blocker
> Fix For: 0.5.0
>
>
> Builds don't effectively pull system OpenSSLfor rpi



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MINIFICPP-454) Builds don't effectively pull system OpenSSL for rpi

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439836#comment-16439836
 ] 

ASF GitHub Bot commented on MINIFICPP-454:
--

Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/299
  
Was able to verify in a docker container, looks good.


> Builds don't effectively pull system OpenSSL for rpi
> 
>
> Key: MINIFICPP-454
> URL: https://issues.apache.org/jira/browse/MINIFICPP-454
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>Priority: Blocker
> Fix For: 0.5.0
>
>
> Builds don't effectively pull system OpenSSLfor rpi



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MINIFICPP-454) Builds don't effectively pull system OpenSSL for rpi

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439795#comment-16439795
 ] 

ASF GitHub Bot commented on MINIFICPP-454:
--

Github user apiri commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/299#discussion_r181833527
  
--- Diff: debian.sh ---
@@ -31,11 +27,12 @@ bootstrap_cmake(){
   sudo apt-get -y install cmake
 }
 build_deps(){
+  sudo apt-get -y update 
   ## need to account for debian
-  sudo apt-get install libssl1.0-dev > /dev/null
+  sudo apt-get install -y libssl1.0-dev > /dev/null
   RETVAL=$?
-  if ["$RETVAL" -ne "0"]; then  
- sudo apt-get install libssl-dev > /dev/null
+  if [ "$RETVAL" -ne "0"]; then  
--- End diff --

Missing a space before the closing bracket


> Builds don't effectively pull system OpenSSL for rpi
> 
>
> Key: MINIFICPP-454
> URL: https://issues.apache.org/jira/browse/MINIFICPP-454
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>Priority: Blocker
> Fix For: 0.5.0
>
>
> Builds don't effectively pull system OpenSSLfor rpi



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MINIFICPP-454) Builds don't effectively pull system OpenSSL for rpi

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439790#comment-16439790
 ] 

ASF GitHub Bot commented on MINIFICPP-454:
--

Github user minifirocks commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/299
  
@phrocker looks good, please merge to 1 commit


> Builds don't effectively pull system OpenSSL for rpi
> 
>
> Key: MINIFICPP-454
> URL: https://issues.apache.org/jira/browse/MINIFICPP-454
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>Priority: Blocker
> Fix For: 0.5.0
>
>
> Builds don't effectively pull system OpenSSLfor rpi



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MINIFICPP-454) Builds don't effectively pull system OpenSSL for rpi

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437695#comment-16437695
 ] 

ASF GitHub Bot commented on MINIFICPP-454:
--

GitHub user phrocker opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/299

MINIFICPP-454: Fix apt-get install statement

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-454

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/299.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #299


commit 16fb5a145998311f1ccbed8a6b41b52f31419be7
Author: Marc Parisi 
Date:   2018-04-13T18:17:53Z

MINIFICPP-454: Fix apt-get install statement




> Builds don't effectively pull system OpenSSL for rpi
> 
>
> Key: MINIFICPP-454
> URL: https://issues.apache.org/jira/browse/MINIFICPP-454
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>Priority: Blocker
> Fix For: 0.5.0
>
>
> Builds don't effectively pull system OpenSSLfor rpi



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)