[jira] [Commented] (NIFI-1295) Add UI option to interrupt a running processor
[ https://issues.apache.org/jira/browse/NIFI-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453036#comment-16453036 ] ASF GitHub Bot commented on NIFI-1295: -- Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2607 @mcgilman this is a great feature that I think will make a lot of people's lives easier. Thanks for updating the UI to support this! Also thanks to @scottyaslan and @moranr for your feedback and testing. Everything looks good at this point, so I've merged to master. > Add UI option to interrupt a running processor > -- > > Key: NIFI-1295 > URL: https://issues.apache.org/jira/browse/NIFI-1295 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Affects Versions: 0.4.0 >Reporter: Oleg Zhurakousky >Assignee: Matt Gilman >Priority: Major > Fix For: 1.7.0 > > > Basically we need an expose option to a user to kill Processors that can't be > shut down the usual way (see NIFI-78 for more details). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-1295) Add UI option to interrupt a running processor
[ https://issues.apache.org/jira/browse/NIFI-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453032#comment-16453032 ] ASF subversion and git services commented on NIFI-1295: --- Commit af2513adf843f26b4e80a1526e67095a69d85adf in nifi's branch refs/heads/master from [~mcgilman] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=af2513a ] NIFI-1295: - Adding UI controls for terminating hung threads. - Showing current number of terminated threads. - Fixing issue when replicating terminate threads request throughout the cluster. This closes #2607. Signed-off-by: Mark Payne > Add UI option to interrupt a running processor > -- > > Key: NIFI-1295 > URL: https://issues.apache.org/jira/browse/NIFI-1295 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Affects Versions: 0.4.0 >Reporter: Oleg Zhurakousky >Assignee: Matt Gilman >Priority: Major > > Basically we need an expose option to a user to kill Processors that can't be > shut down the usual way (see NIFI-78 for more details). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-1295) Add UI option to interrupt a running processor
[ https://issues.apache.org/jira/browse/NIFI-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453034#comment-16453034 ] ASF GitHub Bot commented on NIFI-1295: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2607 > Add UI option to interrupt a running processor > -- > > Key: NIFI-1295 > URL: https://issues.apache.org/jira/browse/NIFI-1295 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Affects Versions: 0.4.0 >Reporter: Oleg Zhurakousky >Assignee: Matt Gilman >Priority: Major > > Basically we need an expose option to a user to kill Processors that can't be > shut down the usual way (see NIFI-78 for more details). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-1295) Add UI option to interrupt a running processor
[ https://issues.apache.org/jira/browse/NIFI-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432557#comment-16432557 ] ASF GitHub Bot commented on NIFI-1295: -- Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/2607 Looks good! > Add UI option to interrupt a running processor > -- > > Key: NIFI-1295 > URL: https://issues.apache.org/jira/browse/NIFI-1295 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Affects Versions: 0.4.0 >Reporter: Oleg Zhurakousky >Assignee: Matt Gilman >Priority: Major > > Basically we need an expose option to a user to kill Processors that can't be > shut down the usual way (see NIFI-78 for more details). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-1295) Add UI option to interrupt a running processor
[ https://issues.apache.org/jira/browse/NIFI-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432352#comment-16432352 ] ASF GitHub Bot commented on NIFI-1295: -- Github user moranr commented on the issue: https://github.com/apache/nifi/pull/2607 Thanks @mcgilman, looks good. Could go either way on the Terminate v Terminate threads menu, so unless anyone has a strong opinion for adding "threads," I understand your logic for not making the change. Good catch on the cluster formatting; the formatting changes made here so far are a good step. > Add UI option to interrupt a running processor > -- > > Key: NIFI-1295 > URL: https://issues.apache.org/jira/browse/NIFI-1295 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Affects Versions: 0.4.0 >Reporter: Oleg Zhurakousky >Assignee: Matt Gilman >Priority: Major > > Basically we need an expose option to a user to kill Processors that can't be > shut down the usual way (see NIFI-78 for more details). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-1295) Add UI option to interrupt a running processor
[ https://issues.apache.org/jira/browse/NIFI-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432278#comment-16432278 ] ASF GitHub Bot commented on NIFI-1295: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2607 @moranr @scottyaslan @markap14 I've addressed the PR feedback above. Please have a look at my most recent commit. A couple notes: - I also found and addressed an issue when replicating the terminate threads request throughout the cluster. - I left the Terminate content menu alone since it replaces the Stop option. Like Start/Stop, I think simply stating the action is sufficient. - I did not address the formatting of the queue stats. When investigating I discovered an issue with this formatting. It turns out that it is already formatted in the proposed way when in clustered mode. In standalone this formatting is different. Unfortunately, its a bigger change then I'd like to make in this PR. As a result, I filed a new JIRA [1] to address it in the future. [1] https://issues.apache.org/jira/browse/NIFI-5067 > Add UI option to interrupt a running processor > -- > > Key: NIFI-1295 > URL: https://issues.apache.org/jira/browse/NIFI-1295 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Affects Versions: 0.4.0 >Reporter: Oleg Zhurakousky >Assignee: Matt Gilman >Priority: Major > > Basically we need an expose option to a user to kill Processors that can't be > shut down the usual way (see NIFI-78 for more details). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-1295) Add UI option to interrupt a running processor
[
https://issues.apache.org/jira/browse/NIFI-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431097#comment-16431097
]
ASF GitHub Bot commented on NIFI-1295:
--
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2607#discussion_r180204274
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
---
@@ -3846,6 +3851,73 @@ public QueueSize getTotalFlowFileCount(final
ProcessGroup group) {
return new QueueSize(count, contentSize);
}
+public class GroupStatusCounts {
--- End diff --
Ah yes, I overlooked that. Is a bit difficult to find these things in a
Github Diff page :)
> Add UI option to interrupt a running processor
> --
>
> Key: NIFI-1295
> URL: https://issues.apache.org/jira/browse/NIFI-1295
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core UI
>Affects Versions: 0.4.0
>Reporter: Oleg Zhurakousky
>Assignee: Matt Gilman
>Priority: Major
>
> Basically we need an expose option to a user to kill Processors that can't be
> shut down the usual way (see NIFI-78 for more details).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-1295) Add UI option to interrupt a running processor
[ https://issues.apache.org/jira/browse/NIFI-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428394#comment-16428394 ] ASF GitHub Bot commented on NIFI-1295: -- Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2607 After testing, all looks good to me. I'm a +1 to merge if you want to make those format changes suggested by Rob and optionally the class refactoring that I suggested in the FlowController. Thanks! This is definitely an awesome feature to have added in! > Add UI option to interrupt a running processor > -- > > Key: NIFI-1295 > URL: https://issues.apache.org/jira/browse/NIFI-1295 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Affects Versions: 0.4.0 >Reporter: Oleg Zhurakousky >Assignee: Matt Gilman >Priority: Major > > Basically we need an expose option to a user to kill Processors that can't be > shut down the usual way (see NIFI-78 for more details). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-1295) Add UI option to interrupt a running processor
[ https://issues.apache.org/jira/browse/NIFI-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428387#comment-16428387 ] ASF GitHub Bot commented on NIFI-1295: -- Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2607 +1 to @moranr's suggestion for formatting, also. > Add UI option to interrupt a running processor > -- > > Key: NIFI-1295 > URL: https://issues.apache.org/jira/browse/NIFI-1295 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Affects Versions: 0.4.0 >Reporter: Oleg Zhurakousky >Assignee: Matt Gilman >Priority: Major > > Basically we need an expose option to a user to kill Processors that can't be > shut down the usual way (see NIFI-78 for more details). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-1295) Add UI option to interrupt a running processor
[
https://issues.apache.org/jira/browse/NIFI-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428376#comment-16428376
]
ASF GitHub Bot commented on NIFI-1295:
--
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2607#discussion_r179770521
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
---
@@ -3846,6 +3851,73 @@ public QueueSize getTotalFlowFileCount(final
ProcessGroup group) {
return new QueueSize(count, contentSize);
}
+public class GroupStatusCounts {
--- End diff --
This cannot be static as it needs access to the `processScheduler`
> Add UI option to interrupt a running processor
> --
>
> Key: NIFI-1295
> URL: https://issues.apache.org/jira/browse/NIFI-1295
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core UI
>Affects Versions: 0.4.0
>Reporter: Oleg Zhurakousky
>Assignee: Matt Gilman
>Priority: Major
>
> Basically we need an expose option to a user to kill Processors that can't be
> shut down the usual way (see NIFI-78 for more details).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-1295) Add UI option to interrupt a running processor
[
https://issues.apache.org/jira/browse/NIFI-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428371#comment-16428371
]
ASF GitHub Bot commented on NIFI-1295:
--
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2607#discussion_r179768517
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
---
@@ -3846,6 +3851,73 @@ public QueueSize getTotalFlowFileCount(final
ProcessGroup group) {
return new QueueSize(count, contentSize);
}
+public class GroupStatusCounts {
--- End diff --
And honestly, at that point, you could even get rid of the
getGroupStatusCounts(ProcessGroup) method all together if you wanted, as you
could just use the FlowController to get the root group and then just pass that
root group to the constructor of GroupStatusCounts...
> Add UI option to interrupt a running processor
> --
>
> Key: NIFI-1295
> URL: https://issues.apache.org/jira/browse/NIFI-1295
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core UI
>Affects Versions: 0.4.0
>Reporter: Oleg Zhurakousky
>Assignee: Matt Gilman
>Priority: Major
>
> Basically we need an expose option to a user to kill Processors that can't be
> shut down the usual way (see NIFI-78 for more details).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-1295) Add UI option to interrupt a running processor
[
https://issues.apache.org/jira/browse/NIFI-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428370#comment-16428370
]
ASF GitHub Bot commented on NIFI-1295:
--
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2607#discussion_r179768732
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
---
@@ -330,7 +330,7 @@ public void checkpoint() {
}
@Override
-public void commit() {
+public synchronized void commit() {
--- End diff --
Good - i think i made a mistake in missing this in my last refactor.
> Add UI option to interrupt a running processor
> --
>
> Key: NIFI-1295
> URL: https://issues.apache.org/jira/browse/NIFI-1295
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core UI
>Affects Versions: 0.4.0
>Reporter: Oleg Zhurakousky
>Assignee: Matt Gilman
>Priority: Major
>
> Basically we need an expose option to a user to kill Processors that can't be
> shut down the usual way (see NIFI-78 for more details).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-1295) Add UI option to interrupt a running processor
[
https://issues.apache.org/jira/browse/NIFI-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428372#comment-16428372
]
ASF GitHub Bot commented on NIFI-1295:
--
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2607#discussion_r179768108
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
---
@@ -3846,6 +3851,73 @@ public QueueSize getTotalFlowFileCount(final
ProcessGroup group) {
return new QueueSize(count, contentSize);
}
+public class GroupStatusCounts {
--- End diff --
This is nit-picky but given that this class can be declared as static,
since it doesn't reference FlowController private variables/methods, and given
that FlowController is already nearly 4,000 lines of code, I'd recommend
pulling this class out into its own .java file instead of making it an inner
class of FlowController.
> Add UI option to interrupt a running processor
> --
>
> Key: NIFI-1295
> URL: https://issues.apache.org/jira/browse/NIFI-1295
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core UI
>Affects Versions: 0.4.0
>Reporter: Oleg Zhurakousky
>Assignee: Matt Gilman
>Priority: Major
>
> Basically we need an expose option to a user to kill Processors that can't be
> shut down the usual way (see NIFI-78 for more details).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-1295) Add UI option to interrupt a running processor
[ https://issues.apache.org/jira/browse/NIFI-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428278#comment-16428278 ] ASF GitHub Bot commented on NIFI-1295: -- Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/2607 @mcgilman I have reviewed the client side code and I am a +1 to merge once you have made the updates to the messages as @moranr suggested. Thanks for this contribution! > Add UI option to interrupt a running processor > -- > > Key: NIFI-1295 > URL: https://issues.apache.org/jira/browse/NIFI-1295 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Affects Versions: 0.4.0 >Reporter: Oleg Zhurakousky >Assignee: Matt Gilman >Priority: Major > > Basically we need an expose option to a user to kill Processors that can't be > shut down the usual way (see NIFI-78 for more details). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-1295) Add UI option to interrupt a running processor
[ https://issues.apache.org/jira/browse/NIFI-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427325#comment-16427325 ] ASF GitHub Bot commented on NIFI-1295: -- Github user moranr commented on the issue: https://github.com/apache/nifi/pull/2607 @mcgilman , I was thinking about some suggestions to the formatting and tooltip labeling used on these. I think we're using the '/' (forward slash) inconsistently which could be a bit confusing. How about formatting the thread count in the global status bar like so: **3 (1)** And the tooltip could read something like: **Threads: Active (Terminated)** Then when the thread icon shows on a processor, the count would again show as '# (#)' and the tooltip could be something like: **3 active threads (1 terminated)** I'm also thinking change the current queue/data size global status format to: **_Object Count (Data Size)_** i.e., use parentheses instead of the forward slash This is consistent with the In & Out stats on components. And one last thing I thought is adding the term 'threads' to the Terminate context menu action. So, change _Terminate_ to _Terminate threads_ > Add UI option to interrupt a running processor > -- > > Key: NIFI-1295 > URL: https://issues.apache.org/jira/browse/NIFI-1295 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Affects Versions: 0.4.0 >Reporter: Oleg Zhurakousky >Assignee: Matt Gilman >Priority: Major > > Basically we need an expose option to a user to kill Processors that can't be > shut down the usual way (see NIFI-78 for more details). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-1295) Add UI option to interrupt a running processor
[ https://issues.apache.org/jira/browse/NIFI-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427065#comment-16427065 ] ASF GitHub Bot commented on NIFI-1295: -- GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/2607 NIFI-1295: Adding UI controls for terminating threads NIFI-1295: - Adding UI controls for terminating hung threads. - Showing current number of terminated threads. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mcgilman/nifi NIFI-1295 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2607.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2607 commit 0c9d34ce8968419f0e950b781d2309fb661f1f2d Author: Matt Gilman Date: 2018-04-05T14:56:54Z NIFI-1295: - Adding UI controls for terminating hung threads. - Showing current number of terminated threads. > Add UI option to interrupt a running processor > -- > > Key: NIFI-1295 > URL: https://issues.apache.org/jira/browse/NIFI-1295 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Affects Versions: 0.4.0 >Reporter: Oleg Zhurakousky >Assignee: Matt Gilman >Priority: Major > > Basically we need an expose option to a user to kill Processors that can't be > shut down the usual way (see NIFI-78 for more details). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-1295) Add UI option to interrupt a running processor
[ https://issues.apache.org/jira/browse/NIFI-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15592018#comment-15592018 ] L c commented on NIFI-1295: --- + 1 For Rob Moran comment. > Add UI option to interrupt a running processor > -- > > Key: NIFI-1295 > URL: https://issues.apache.org/jira/browse/NIFI-1295 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 0.4.0 >Reporter: Oleg Zhurakousky >Assignee: Matt Gilman > > Basically we need an expose option to a user to kill Processors that can't be > shut down the usual way (see NIFI-78 for more details). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
