[jira] [Commented] (NIFI-2749) maxvalue Attributes Added by QueryDatabaseTable to FlowFiles May be Incorrect
[ https://issues.apache.org/jira/browse/NIFI-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510261#comment-15510261 ] ASF GitHub Bot commented on NIFI-2749: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/997 > maxvalue Attributes Added by QueryDatabaseTable to FlowFiles May be Incorrect > - > > Key: NIFI-2749 > URL: https://issues.apache.org/jira/browse/NIFI-2749 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Peter Wicks >Priority: Minor > Fix For: 1.1.0 > > > NIFI-2641 caused maxvalue attributes to be placed onto FlowFiles generated by > QueryDatabaseTable. However if QDB is using MAX_ROWS_PER_FLOW_FILE to split > the ResultSet into multiple FlowFiles then the value attached to the FlowFile > will just be the maximum seen so far, and not necessarily the final Maximum. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-2749) maxvalue Attributes Added by QueryDatabaseTable to FlowFiles May be Incorrect
[ https://issues.apache.org/jira/browse/NIFI-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510258#comment-15510258 ] ASF subversion and git services commented on NIFI-2749: --- Commit 938c7cccb8b251d4a1390cf0078b14f53bc94a57 in nifi's branch refs/heads/master from [~patricker] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=938c7cc ] NIFI-2749 Signed-off-by: Matt Burgess This closes #997 > maxvalue Attributes Added by QueryDatabaseTable to FlowFiles May be Incorrect > - > > Key: NIFI-2749 > URL: https://issues.apache.org/jira/browse/NIFI-2749 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Peter Wicks >Priority: Minor > Fix For: 1.1.0 > > > NIFI-2641 caused maxvalue attributes to be placed onto FlowFiles generated by > QueryDatabaseTable. However if QDB is using MAX_ROWS_PER_FLOW_FILE to split > the ResultSet into multiple FlowFiles then the value attached to the FlowFile > will just be the maximum seen so far, and not necessarily the final Maximum. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-2749) maxvalue Attributes Added by QueryDatabaseTable to FlowFiles May be Incorrect
[ https://issues.apache.org/jira/browse/NIFI-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510255#comment-15510255 ] ASF GitHub Bot commented on NIFI-2749: -- Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/997 +1 LGTM, verified the problem exists, the unit tests show the problem, and the fix corrects the problem. Merging to master. > maxvalue Attributes Added by QueryDatabaseTable to FlowFiles May be Incorrect > - > > Key: NIFI-2749 > URL: https://issues.apache.org/jira/browse/NIFI-2749 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Peter Wicks >Priority: Minor > Fix For: 1.1.0 > > > NIFI-2641 caused maxvalue attributes to be placed onto FlowFiles generated by > QueryDatabaseTable. However if QDB is using MAX_ROWS_PER_FLOW_FILE to split > the ResultSet into multiple FlowFiles then the value attached to the FlowFile > will just be the maximum seen so far, and not necessarily the final Maximum. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-2749) maxvalue Attributes Added by QueryDatabaseTable to FlowFiles May be Incorrect
[ https://issues.apache.org/jira/browse/NIFI-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15475815#comment-15475815 ] ASF GitHub Bot commented on NIFI-2749: -- GitHub user patricker opened a pull request: https://github.com/apache/nifi/pull/997 NIFI-2749 Bug fix for NIFI-2641, includes unit test. You can merge this pull request into a Git repository by running: $ git pull https://github.com/patricker/nifi NIFI-2749 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/997.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #997 commit dda8ea390418cdd465e38beb32c4086fa9fbbb4c Author: Peter Wicks Date: 2016-09-09T03:37:21Z NIFI-2749 > maxvalue Attributes Added by QueryDatabaseTable to FlowFiles May be Incorrect > - > > Key: NIFI-2749 > URL: https://issues.apache.org/jira/browse/NIFI-2749 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Peter Wicks >Priority: Minor > > NIFI-2641 caused maxvalue attributes to be placed onto FlowFiles generated by > QueryDatabaseTable. However if QDB is using MAX_ROWS_PER_FLOW_FILE to split > the ResultSet into multiple FlowFiles then the value attached to the FlowFile > will just be the maximum seen so far, and not necessarily the final Maximum. -- This message was sent by Atlassian JIRA (v6.3.4#6332)