[jira] [Commented] (NIFI-2866) The Initial Max Value of QueryDatabaseTable won't be case sensitive.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722881#comment-15722881
 ] 

ASF GitHub Bot commented on NIFI-2866:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1212


> The Initial Max Value of QueryDatabaseTable won't be case sensitive.
> 
>
> Key: NIFI-2866
> URL: https://issues.apache.org/jira/browse/NIFI-2866
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.1.0
>Reporter: Byunghwa Yun
>Priority: Minor
> Fix For: 1.2.0
>
>
> Now, the Initial Max Value of QueryDatabaseTable is allowed the only 
> lowercase so I think to change the below code, it added .toLowerCase() method.
> for(final Map.Entry maxProp : 
> maxValueProperties.entrySet()){
> if 
> (!statePropertyMap.containsKey(maxProp.getKey().toLowerCase())) {
> statePropertyMap.put(maxProp.getKey().toLowerCase(), 
> maxProp.getValue());
> }
> }
> When I set the property that is initial.maxvalue.UPDATE_TIME, 
> QueryDatabaseTable doesn't have WHERE clause with UPDATE_TIME.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2866) The Initial Max Value of QueryDatabaseTable won't be case sensitive.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722859#comment-15722859
 ] 

ASF GitHub Bot commented on NIFI-2866:
--

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/1212
  
+1 LGTM, ran the unit tests and tried in NiFi with mixed case identifiers. 
Thank you for the contribution! Merging to master


> The Initial Max Value of QueryDatabaseTable won't be case sensitive.
> 
>
> Key: NIFI-2866
> URL: https://issues.apache.org/jira/browse/NIFI-2866
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.1.0
>Reporter: Byunghwa Yun
>Priority: Minor
>
> Now, the Initial Max Value of QueryDatabaseTable is allowed the only 
> lowercase so I think to change the below code, it added .toLowerCase() method.
> for(final Map.Entry maxProp : 
> maxValueProperties.entrySet()){
> if 
> (!statePropertyMap.containsKey(maxProp.getKey().toLowerCase())) {
> statePropertyMap.put(maxProp.getKey().toLowerCase(), 
> maxProp.getValue());
> }
> }
> When I set the property that is initial.maxvalue.UPDATE_TIME, 
> QueryDatabaseTable doesn't have WHERE clause with UPDATE_TIME.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2866) The Initial Max Value of QueryDatabaseTable won't be case sensitive.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15660747#comment-15660747
 ] 

ASF GitHub Bot commented on NIFI-2866:
--

Github user combineads closed the pull request at:

https://github.com/apache/nifi/pull/1101


> The Initial Max Value of QueryDatabaseTable won't be case sensitive.
> 
>
> Key: NIFI-2866
> URL: https://issues.apache.org/jira/browse/NIFI-2866
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.1.0
>Reporter: Byunghwa Yun
>Priority: Minor
>
> Now, the Initial Max Value of QueryDatabaseTable is allowed the only 
> lowercase so I think to change the below code, it added .toLowerCase() method.
> for(final Map.Entry maxProp : 
> maxValueProperties.entrySet()){
> if 
> (!statePropertyMap.containsKey(maxProp.getKey().toLowerCase())) {
> statePropertyMap.put(maxProp.getKey().toLowerCase(), 
> maxProp.getValue());
> }
> }
> When I set the property that is initial.maxvalue.UPDATE_TIME, 
> QueryDatabaseTable doesn't have WHERE clause with UPDATE_TIME.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2866) The Initial Max Value of QueryDatabaseTable won't be case sensitive.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603779#comment-15603779
 ] 

ASF GitHub Bot commented on NIFI-2866:
--

Github user combineads commented on the issue:

https://github.com/apache/nifi/pull/1101
  
@mattyb149
Sorry to bother you again. I changed the commit message.
Thanks for your review.


> The Initial Max Value of QueryDatabaseTable won't be case sensitive.
> 
>
> Key: NIFI-2866
> URL: https://issues.apache.org/jira/browse/NIFI-2866
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.1.0
>Reporter: Byunghwa Yun
>Priority: Minor
>
> Now, the Initial Max Value of QueryDatabaseTable is allowed the only 
> lowercase so I think to change the below code, it added .toLowerCase() method.
> for(final Map.Entry maxProp : 
> maxValueProperties.entrySet()){
> if 
> (!statePropertyMap.containsKey(maxProp.getKey().toLowerCase())) {
> statePropertyMap.put(maxProp.getKey().toLowerCase(), 
> maxProp.getValue());
> }
> }
> When I set the property that is initial.maxvalue.UPDATE_TIME, 
> QueryDatabaseTable doesn't have WHERE clause with UPDATE_TIME.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2866) The Initial Max Value of QueryDatabaseTable won't be case sensitive.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581696#comment-15581696
 ] 

ASF GitHub Bot commented on NIFI-2866:
--

Github user combineads commented on the issue:

https://github.com/apache/nifi/pull/1101
  
@mattyb149
I changed the initial.maxvalue.CREATED_ON attribute of 
testInitialMaxValue() test.
Thanks for your review.


> The Initial Max Value of QueryDatabaseTable won't be case sensitive.
> 
>
> Key: NIFI-2866
> URL: https://issues.apache.org/jira/browse/NIFI-2866
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.1.0
>Reporter: Byunghwa Yun
>Priority: Minor
>
> Now, the Initial Max Value of QueryDatabaseTable is allowed the only 
> lowercase so I think to change the below code, it added .toLowerCase() method.
> for(final Map.Entry maxProp : 
> maxValueProperties.entrySet()){
> if 
> (!statePropertyMap.containsKey(maxProp.getKey().toLowerCase())) {
> statePropertyMap.put(maxProp.getKey().toLowerCase(), 
> maxProp.getValue());
> }
> }
> When I set the property that is initial.maxvalue.UPDATE_TIME, 
> QueryDatabaseTable doesn't have WHERE clause with UPDATE_TIME.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2866) The Initial Max Value of QueryDatabaseTable won't be case sensitive.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569388#comment-15569388
 ] 

ASF GitHub Bot commented on NIFI-2866:
--

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/1101
  
Can you add a unit test for this? One option is to update the 
testInitialMaxValue() test to change the name of the "created_on" column to 
uppercase, as well as the max-value column name and the 
initial.maxvalue.CREATED_ON attribute. That should be enough to illustrate the 
problem before applying your change, then the test passes after your change.


> The Initial Max Value of QueryDatabaseTable won't be case sensitive.
> 
>
> Key: NIFI-2866
> URL: https://issues.apache.org/jira/browse/NIFI-2866
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.1.0
>Reporter: Byunghwa Yun
>Priority: Minor
>
> Now, the Initial Max Value of QueryDatabaseTable is allowed the only 
> lowercase so I think to change the below code, it added .toLowerCase() method.
> for(final Map.Entry maxProp : 
> maxValueProperties.entrySet()){
> if 
> (!statePropertyMap.containsKey(maxProp.getKey().toLowerCase())) {
> statePropertyMap.put(maxProp.getKey().toLowerCase(), 
> maxProp.getValue());
> }
> }
> When I set the property that is initial.maxvalue.UPDATE_TIME, 
> QueryDatabaseTable doesn't have WHERE clause with UPDATE_TIME.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2866) The Initial Max Value of QueryDatabaseTable won't be case sensitive.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561326#comment-15561326
 ] 

ASF GitHub Bot commented on NIFI-2866:
--

Github user combineads commented on the issue:

https://github.com/apache/nifi/pull/1101
  
Hello, @mattyb149 .
Cloud you review this PR?

Thank you for your effort.


> The Initial Max Value of QueryDatabaseTable won't be case sensitive.
> 
>
> Key: NIFI-2866
> URL: https://issues.apache.org/jira/browse/NIFI-2866
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.1.0
>Reporter: Byunghwa Yun
>Priority: Minor
>
> Now, the Initial Max Value of QueryDatabaseTable is allowed the only 
> lowercase so I think to change the below code, it added .toLowerCase() method.
> for(final Map.Entry maxProp : 
> maxValueProperties.entrySet()){
> if 
> (!statePropertyMap.containsKey(maxProp.getKey().toLowerCase())) {
> statePropertyMap.put(maxProp.getKey().toLowerCase(), 
> maxProp.getValue());
> }
> }
> When I set the property that is initial.maxvalue.UPDATE_TIME, 
> QueryDatabaseTable doesn't have WHERE clause with UPDATE_TIME.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2866) The Initial Max Value of QueryDatabaseTable won't be case sensitive.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547533#comment-15547533
 ] 

ASF GitHub Bot commented on NIFI-2866:
--

GitHub user combineads opened a pull request:

https://github.com/apache/nifi/pull/1101

NIFI-2866 The Initial Max Value of QueryDatabaseTable won't be case

sensitive

Now, the Initial Max Value of QueryDatabaseTable is allowed the only 
lowercase so I think to change the below code, it added .toLowerCase() method.
for(final Map.Entry maxProp : maxValueProperties.entrySet()){
if (!statePropertyMap.containsKey(maxProp.getKey().toLowerCase()))
{ statePropertyMap.put(maxProp.getKey().toLowerCase(), maxProp.getValue()); 
}
}
When I set the property that is initial.maxvalue.UPDATE_TIME, 
QueryDatabaseTable doesn't have WHERE clause with UPDATE_TIME.
Thanks.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/combineads/nifi NIFI-2866

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1101


commit 821c5c680ba00709198a6e208179672d997b6073
Author: Byunghwa Yun 
Date:   2016-10-05T03:52:53Z

NIFI-2866 The Initial Max Value of QueryDatabaseTable won't be case
sensitive




> The Initial Max Value of QueryDatabaseTable won't be case sensitive.
> 
>
> Key: NIFI-2866
> URL: https://issues.apache.org/jira/browse/NIFI-2866
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.1.0
>Reporter: Byunghwa Yun
>Priority: Minor
>
> Now, the Initial Max Value of QueryDatabaseTable is allowed the only 
> lowercase so I think to change the below code, it added .toLowerCase() method.
> for(final Map.Entry maxProp : 
> maxValueProperties.entrySet()){
> if 
> (!statePropertyMap.containsKey(maxProp.getKey().toLowerCase())) {
> statePropertyMap.put(maxProp.getKey().toLowerCase(), 
> maxProp.getValue());
> }
> }
> When I set the property that is initial.maxvalue.UPDATE_TIME, 
> QueryDatabaseTable doesn't have WHERE clause with UPDATE_TIME.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)