[jira] [Commented] (NIFI-2872) Create PutCloudwatchMetric Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575925#comment-15575925
 ] 

ASF GitHub Bot commented on NIFI-2872:
--

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/1125
  
Thanks, @vegaed, this is definitely going to improve my flow monitoring.


> Create PutCloudwatchMetric Processor
> 
>
> Key: NIFI-2872
> URL: https://issues.apache.org/jira/browse/NIFI-2872
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Affects Versions: 1.1.0
>Reporter: Edgardo Vega
>Priority: Minor
>
> Create a processor for put metrics into aws cloudwatch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2872) Create PutCloudwatchMetric Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574062#comment-15574062
 ] 

ASF GitHub Bot commented on NIFI-2872:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1125


> Create PutCloudwatchMetric Processor
> 
>
> Key: NIFI-2872
> URL: https://issues.apache.org/jira/browse/NIFI-2872
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Affects Versions: 1.1.0
>Reporter: Edgardo Vega
>Priority: Minor
>
> Create a processor for put metrics into aws cloudwatch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2872) Create PutCloudwatchMetric Processor

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574060#comment-15574060
 ] 

ASF subversion and git services commented on NIFI-2872:
---

Commit 7107616420ed31c057ff7bf7f06bf36e5740b3ea in nifi's branch 
refs/heads/master from Edgardo
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=7107616 ]

NIFI-2872 Create PutCloudWatchMetric Processor

This closes #1125.

Signed-off-by: James Wing 


> Create PutCloudwatchMetric Processor
> 
>
> Key: NIFI-2872
> URL: https://issues.apache.org/jira/browse/NIFI-2872
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Affects Versions: 1.1.0
>Reporter: Edgardo Vega
>Priority: Minor
>
> Create a processor for put metrics into aws cloudwatch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2872) Create PutCloudwatchMetric Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573542#comment-15573542
 ] 

ASF GitHub Bot commented on NIFI-2872:
--

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/1125
  
I expect so :).  The latest changes look good, thanks for those. I'm going 
to do a bit more testing, and if everything goes well, I'll merge it this 
evening.


> Create PutCloudwatchMetric Processor
> 
>
> Key: NIFI-2872
> URL: https://issues.apache.org/jira/browse/NIFI-2872
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Affects Versions: 1.1.0
>Reporter: Edgardo Vega
>Priority: Minor
>
> Create a processor for put metrics into aws cloudwatch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2872) Create PutCloudwatchMetric Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573497#comment-15573497
 ] 

ASF GitHub Bot commented on NIFI-2872:
--

Github user vegaed commented on the issue:

https://github.com/apache/nifi/pull/1125
  
So I guess it ready to be merged then?


> Create PutCloudwatchMetric Processor
> 
>
> Key: NIFI-2872
> URL: https://issues.apache.org/jira/browse/NIFI-2872
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Affects Versions: 1.1.0
>Reporter: Edgardo Vega
>Priority: Minor
>
> Create a processor for put metrics into aws cloudwatch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2872) Create PutCloudwatchMetric Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573041#comment-15573041
 ] 

ASF GitHub Bot commented on NIFI-2872:
--

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/1125
  
@vegaed I don't think you should worry, I do not believe the Appveyor build 
is stable.


> Create PutCloudwatchMetric Processor
> 
>
> Key: NIFI-2872
> URL: https://issues.apache.org/jira/browse/NIFI-2872
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Affects Versions: 1.1.0
>Reporter: Edgardo Vega
>Priority: Minor
>
> Create a processor for put metrics into aws cloudwatch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2872) Create PutCloudwatchMetric Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572970#comment-15572970
 ] 

ASF GitHub Bot commented on NIFI-2872:
--

Github user vegaed commented on the issue:

https://github.com/apache/nifi/pull/1125
  
@jvwing You know why the appveyor build is failing. I didn't touch any of 
the S2S code. Is it something I should worry about?


> Create PutCloudwatchMetric Processor
> 
>
> Key: NIFI-2872
> URL: https://issues.apache.org/jira/browse/NIFI-2872
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Affects Versions: 1.1.0
>Reporter: Edgardo Vega
>Priority: Minor
>
> Create a processor for put metrics into aws cloudwatch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2872) Create PutCloudwatchMetric Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571748#comment-15571748
 ] 

ASF GitHub Bot commented on NIFI-2872:
--

Github user vegaed commented on the issue:

https://github.com/apache/nifi/pull/1125
  
@jvwing Thanks for all the great suggestions and code. 

I moved the try up in order to catch those types of parsing exceptions so 
now they will route to failure.

Good catch on the integration tests

Yes I agree unit testing is good. I was modeling off of S3 and SQS and 
didn't see any there, but I see now that dynamo and kinesis packages are being 
both unit and integration tested.



> Create PutCloudwatchMetric Processor
> 
>
> Key: NIFI-2872
> URL: https://issues.apache.org/jira/browse/NIFI-2872
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Affects Versions: 1.1.0
>Reporter: Edgardo Vega
>Priority: Minor
>
> Create a processor for put metrics into aws cloudwatch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2872) Create PutCloudwatchMetric Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571722#comment-15571722
 ] 

ASF GitHub Bot commented on NIFI-2872:
--

Github user vegaed commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1125#discussion_r83200380
  
--- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/cloudwatch/PutCloudWatchMetric.java
 ---
@@ -0,0 +1,203 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.aws.cloudwatch;
+
+import com.amazonaws.ClientConfiguration;
+import com.amazonaws.auth.AWSCredentials;
+import com.amazonaws.auth.AWSCredentialsProvider;
+import com.amazonaws.services.cloudwatch.AmazonCloudWatchClient;
+import com.amazonaws.services.cloudwatch.model.MetricDatum;
+import com.amazonaws.services.cloudwatch.model.PutMetricDataRequest;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import 
org.apache.nifi.processors.aws.AbstractAWSCredentialsProviderProcessor;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Date;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+
+@SupportsBatching
+@InputRequirement(Requirement.INPUT_REQUIRED)
+@Tags({"amazon", "aws", "cloudwatch", "metrics", "put", "publish"})
+@CapabilityDescription("Publishes metrics to Amazon CloudWatch")
+public class PutCloudWatchMetric extends 
AbstractAWSCredentialsProviderProcessor {
+
+public static final Set relationships = 
Collections.unmodifiableSet(
+new HashSet<>(Arrays.asList(REL_SUCCESS, REL_FAILURE)));
+
+private static final Validator DOUBLE_VALIDATOR = new Validator() {
+@Override
+public ValidationResult validate(String subject, String input, 
ValidationContext context) {
+if (context.isExpressionLanguageSupported(subject) && 
context.isExpressionLanguagePresent(input)) {
+return (new 
ValidationResult.Builder()).subject(subject).input(input).explanation("Expression
 Language Present").valid(true).build();
+} else {
+String reason = null;
+
+try {
+Double.parseDouble(input);
+} catch (NumberFormatException var6) {
+reason = "not a valid Double";
+}
+
+return (new 
ValidationResult.Builder()).subject(subject).input(input).explanation(reason).valid(reason
 == null).build();
+}
+}
+};
+
+public static final PropertyDescriptor NAMESPACE = new 
PropertyDescriptor.Builder()
+.name("Namespace")
+.displayName("Namespace")
+.description("The namespace for the metric data for 
CloudWatch")
+.required(true)
+.expressionLanguageSupported(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+
+public static final PropertyDescriptor METRIC_NAME = new 

[jira] [Commented] (NIFI-2872) Create PutCloudwatchMetric Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569834#comment-15569834
 ] 

ASF GitHub Bot commented on NIFI-2872:
--

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/1125
  
@vegaed Thanks for the updated code.  The situation with 
AbstractAWSProcessor is a bit odd.  It's deprecated in that you should not 
derive directly from it, but it still has live code we're definitely using.

* **Number Parsing Exception Handling** - I tested with a non-double metric 
value.  A java.lang.NumberFormatException is thrown parsing the number at 
PutCloudWatchMetric.java:174.  The error message is clear enough, but the 
exception is not caught inside onTrigger(), so the entire session is rolled 
back and the flowfile remains in the incoming queue.  The same thing applies to 
parsing Timestamp.  Shouldn't we catch the exception and route the flowfile to 
failure in a case like this?
* **Integration Tests** - Integration tests failed for me, complaining 
about no flowfiles routed to REL_SUCCESS.  I believe the fix might be as simple 
as adding an empty flowfile before running:

runner.enqueue(new byte[] {});
runner.run();

* **Unit Tests** - How about some unit tests that do not call AWS?  I agree 
there is no substitute for integration tests that actually call AWS, but I 
believe there is also no substitute for unit tests that can easily be run by 
anyone and everyone.  This can be a bit tricky for cloud services, but it seems 
like CloudWatch has an API with nice request/response patterns that can be 
mocked.  So I tried my hand at a [simple mock setup with sample tests for 
PutCloudWatchMetric](https://github.com/jvwing/nifi/commit/b6ae1accfecb464fe16a456cdef04669a65672fe).
  You're welcome to not use this, but I recommend we try something similar that 
gets coverage of onTrigger from unit tests.


> Create PutCloudwatchMetric Processor
> 
>
> Key: NIFI-2872
> URL: https://issues.apache.org/jira/browse/NIFI-2872
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Affects Versions: 1.1.0
>Reporter: Edgardo Vega
>Priority: Minor
>
> Create a processor for put metrics into aws cloudwatch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2872) Create PutCloudwatchMetric Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569802#comment-15569802
 ] 

ASF GitHub Bot commented on NIFI-2872:
--

Github user jvwing commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1125#discussion_r83091812
  
--- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/cloudwatch/PutCloudWatchMetric.java
 ---
@@ -0,0 +1,203 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.aws.cloudwatch;
+
+import com.amazonaws.ClientConfiguration;
+import com.amazonaws.auth.AWSCredentials;
+import com.amazonaws.auth.AWSCredentialsProvider;
+import com.amazonaws.services.cloudwatch.AmazonCloudWatchClient;
+import com.amazonaws.services.cloudwatch.model.MetricDatum;
+import com.amazonaws.services.cloudwatch.model.PutMetricDataRequest;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import 
org.apache.nifi.processors.aws.AbstractAWSCredentialsProviderProcessor;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Date;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+
+@SupportsBatching
+@InputRequirement(Requirement.INPUT_REQUIRED)
+@Tags({"amazon", "aws", "cloudwatch", "metrics", "put", "publish"})
+@CapabilityDescription("Publishes metrics to Amazon CloudWatch")
+public class PutCloudWatchMetric extends 
AbstractAWSCredentialsProviderProcessor {
+
+public static final Set relationships = 
Collections.unmodifiableSet(
+new HashSet<>(Arrays.asList(REL_SUCCESS, REL_FAILURE)));
+
+private static final Validator DOUBLE_VALIDATOR = new Validator() {
+@Override
+public ValidationResult validate(String subject, String input, 
ValidationContext context) {
+if (context.isExpressionLanguageSupported(subject) && 
context.isExpressionLanguagePresent(input)) {
+return (new 
ValidationResult.Builder()).subject(subject).input(input).explanation("Expression
 Language Present").valid(true).build();
+} else {
+String reason = null;
+
+try {
+Double.parseDouble(input);
+} catch (NumberFormatException var6) {
--- End diff --

Any significance to `var6`?  How about `nfe` or just `e`?


> Create PutCloudwatchMetric Processor
> 
>
> Key: NIFI-2872
> URL: https://issues.apache.org/jira/browse/NIFI-2872
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Affects Versions: 1.1.0
>Reporter: Edgardo Vega
>Priority: Minor
>
> Create a processor for put metrics into aws cloudwatch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2872) Create PutCloudwatchMetric Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569803#comment-15569803
 ] 

ASF GitHub Bot commented on NIFI-2872:
--

Github user jvwing commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1125#discussion_r83092101
  
--- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/cloudwatch/PutCloudWatchMetric.java
 ---
@@ -0,0 +1,203 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.aws.cloudwatch;
+
+import com.amazonaws.ClientConfiguration;
+import com.amazonaws.auth.AWSCredentials;
+import com.amazonaws.auth.AWSCredentialsProvider;
+import com.amazonaws.services.cloudwatch.AmazonCloudWatchClient;
+import com.amazonaws.services.cloudwatch.model.MetricDatum;
+import com.amazonaws.services.cloudwatch.model.PutMetricDataRequest;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import 
org.apache.nifi.processors.aws.AbstractAWSCredentialsProviderProcessor;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Date;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+
+@SupportsBatching
+@InputRequirement(Requirement.INPUT_REQUIRED)
+@Tags({"amazon", "aws", "cloudwatch", "metrics", "put", "publish"})
+@CapabilityDescription("Publishes metrics to Amazon CloudWatch")
+public class PutCloudWatchMetric extends 
AbstractAWSCredentialsProviderProcessor {
+
+public static final Set relationships = 
Collections.unmodifiableSet(
+new HashSet<>(Arrays.asList(REL_SUCCESS, REL_FAILURE)));
+
+private static final Validator DOUBLE_VALIDATOR = new Validator() {
+@Override
+public ValidationResult validate(String subject, String input, 
ValidationContext context) {
+if (context.isExpressionLanguageSupported(subject) && 
context.isExpressionLanguagePresent(input)) {
+return (new 
ValidationResult.Builder()).subject(subject).input(input).explanation("Expression
 Language Present").valid(true).build();
+} else {
+String reason = null;
+
+try {
+Double.parseDouble(input);
+} catch (NumberFormatException var6) {
+reason = "not a valid Double";
+}
+
+return (new 
ValidationResult.Builder()).subject(subject).input(input).explanation(reason).valid(reason
 == null).build();
+}
+}
+};
+
+public static final PropertyDescriptor NAMESPACE = new 
PropertyDescriptor.Builder()
+.name("Namespace")
+.displayName("Namespace")
+.description("The namespace for the metric data for 
CloudWatch")
+.required(true)
+.expressionLanguageSupported(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+
+public static final PropertyDescriptor METRIC_NAME = new 

[jira] [Commented] (NIFI-2872) Create PutCloudwatchMetric Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567079#comment-15567079
 ] 

ASF GitHub Bot commented on NIFI-2872:
--

Github user vegaed commented on the issue:

https://github.com/apache/nifi/pull/1125
  
@jvwing Thanks for the review. Just fixed those issues up. Only reason I 
didn't use the RELs from AbstractAWSProcessor is because it is a deprecated 
class, but if it standard practice.


> Create PutCloudwatchMetric Processor
> 
>
> Key: NIFI-2872
> URL: https://issues.apache.org/jira/browse/NIFI-2872
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Affects Versions: 1.1.0
>Reporter: Edgardo Vega
>Priority: Minor
>
> Create a processor for put metrics into aws cloudwatch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2872) Create PutCloudwatchMetric Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566512#comment-15566512
 ] 

ASF GitHub Bot commented on NIFI-2872:
--

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/1125
  
@vegaed thanks for putting this together.  I have a few initial suggestions 
from a quick scan:

* Please run `mvn clean install -Pcontrib-check` - there are a few issues 
with .* imports, unused imports, etc.
* Did you forget to incude an entry for PutCloudWatchMetric processor in 
the service definition file org.apache.nifi.processor.Processor?
* For PropertyDescriptors, please provide both `name` (as a data key) and 
`displayName` (for UI presentation)
* Why not use REL_SUCCESS and REL_FAILURE inherited from 
AbstractAWSProcessor?  The descriptions would be less specific, but it appears 
to be a standard practice.



> Create PutCloudwatchMetric Processor
> 
>
> Key: NIFI-2872
> URL: https://issues.apache.org/jira/browse/NIFI-2872
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Affects Versions: 1.1.0
>Reporter: Edgardo Vega
>Priority: Minor
>
> Create a processor for put metrics into aws cloudwatch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2872) Create PutCloudwatchMetric Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566137#comment-15566137
 ] 

ASF GitHub Bot commented on NIFI-2872:
--

GitHub user vegaed opened a pull request:

https://github.com/apache/nifi/pull/1125

NIFI-2872 Create PutCloudwatchMetric Processor

https://issues.apache.org/jira/browse/NIFI-2872

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vegaed/nifi NIFI-2872

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1125


commit 18dca0059c7b9ce39b368968d4813717de77e07b
Author: Edgardo 
Date:   2016-10-11T18:07:42Z

NIFI-2872 Create PutCloudwatchMetric Processor

https://issues.apache.org/jira/browse/NIFI-2872




> Create PutCloudwatchMetric Processor
> 
>
> Key: NIFI-2872
> URL: https://issues.apache.org/jira/browse/NIFI-2872
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Affects Versions: 1.1.0
>Reporter: Edgardo Vega
>Priority: Minor
>
> Create a processor for put metrics into aws cloudwatch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)