[jira] [Commented] (NIFI-3129) When adding template to flow, I receive failure message "The specified observer identifier already exists."

2016-12-14 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749460#comment-15749460
 ] 

ASF subversion and git services commented on NIFI-3129:
---

Commit aa54da1cf16725d32c6b43531e8195e862999d78 in nifi's branch 
refs/heads/support/nifi-1.1.x from [~markap14]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=aa54da1 ]

NIFI-3129: When adding controller services to a snippet, ensure that we don't 
add the service multiple times, even when it's referenced by child process 
groups. This closes #1284


> When adding template to flow, I receive failure message "The specified 
> observer identifier already exists."
> ---
>
> Key: NIFI-3129
> URL: https://issues.apache.org/jira/browse/NIFI-3129
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Critical
> Fix For: 1.2.0, 1.1.1, 1.0.1
>
> Attachments: 
> 0001-NIFI-3129-When-adding-controller-services-to-a-snipp.patch
>
>
> I have a template that I generated. Whenever I try to drop the template onto 
> the graph, and the UI gives me an error: "The specified observer identifier 
> already exists."
> Part of the template is added to the graph, but it then stops without adding 
> the rest of the components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3129) When adding template to flow, I receive failure message "The specified observer identifier already exists."

2016-12-14 Thread Mark Payne (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749461#comment-15749461
 ] 

Mark Payne commented on NIFI-3129:
--

Merged to both support branches; will re-resolve ticket.

> When adding template to flow, I receive failure message "The specified 
> observer identifier already exists."
> ---
>
> Key: NIFI-3129
> URL: https://issues.apache.org/jira/browse/NIFI-3129
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Critical
> Fix For: 1.2.0, 1.1.1, 1.0.1
>
> Attachments: 
> 0001-NIFI-3129-When-adding-controller-services-to-a-snipp.patch
>
>
> I have a template that I generated. Whenever I try to drop the template onto 
> the graph, and the UI gives me an error: "The specified observer identifier 
> already exists."
> Part of the template is added to the graph, but it then stops without adding 
> the rest of the components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3129) When adding template to flow, I receive failure message "The specified observer identifier already exists."

2016-12-14 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749433#comment-15749433
 ] 

ASF subversion and git services commented on NIFI-3129:
---

Commit fc2941553ecea7a29d6e74ac0fa93c8533506121 in nifi's branch 
refs/heads/support/nifi-1.0.x from [~markap14]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=fc29415 ]

NIFI-3129: When adding controller services to a snippet, ensure that we don't 
add the service multiple times, even when it's referenced by child process 
groups. This closes #1284


> When adding template to flow, I receive failure message "The specified 
> observer identifier already exists."
> ---
>
> Key: NIFI-3129
> URL: https://issues.apache.org/jira/browse/NIFI-3129
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Critical
> Fix For: 1.2.0, 1.1.1, 1.0.1
>
> Attachments: 
> 0001-NIFI-3129-When-adding-controller-services-to-a-snipp.patch
>
>
> I have a template that I generated. Whenever I try to drop the template onto 
> the graph, and the UI gives me an error: "The specified observer identifier 
> already exists."
> Part of the template is added to the graph, but it then stops without adding 
> the rest of the components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3129) When adding template to flow, I receive failure message "The specified observer identifier already exists."

2016-12-14 Thread Mark Payne (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749353#comment-15749353
 ] 

Mark Payne commented on NIFI-3129:
--

The commit id to cherry-pick is ba513447d75dc5e95ddcdfcac1a1fefe2eb175ce

> When adding template to flow, I receive failure message "The specified 
> observer identifier already exists."
> ---
>
> Key: NIFI-3129
> URL: https://issues.apache.org/jira/browse/NIFI-3129
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Critical
> Fix For: 1.2.0, 1.1.1, 1.0.1
>
> Attachments: 
> 0001-NIFI-3129-When-adding-controller-services-to-a-snipp.patch
>
>
> I have a template that I generated. Whenever I try to drop the template onto 
> the graph, and the UI gives me an error: "The specified observer identifier 
> already exists."
> Part of the template is added to the graph, but it then stops without adding 
> the rest of the components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3129) When adding template to flow, I receive failure message "The specified observer identifier already exists."

2016-12-14 Thread Mark Payne (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749348#comment-15749348
 ] 

Mark Payne commented on NIFI-3129:
--

Re-opening this because it needs to go into the 1.0.1 and 1.1.1 branches as 
well. Will attach a patch to this JIRA to make that coordination a little easier

> When adding template to flow, I receive failure message "The specified 
> observer identifier already exists."
> ---
>
> Key: NIFI-3129
> URL: https://issues.apache.org/jira/browse/NIFI-3129
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Critical
> Fix For: 1.2.0, 1.1.1, 1.0.1
>
>
> I have a template that I generated. Whenever I try to drop the template onto 
> the graph, and the UI gives me an error: "The specified observer identifier 
> already exists."
> Part of the template is added to the graph, but it then stops without adding 
> the rest of the components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3129) When adding template to flow, I receive failure message "The specified observer identifier already exists."

2016-11-30 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709294#comment-15709294
 ] 

ASF GitHub Bot commented on NIFI-3129:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1284


> When adding template to flow, I receive failure message "The specified 
> observer identifier already exists."
> ---
>
> Key: NIFI-3129
> URL: https://issues.apache.org/jira/browse/NIFI-3129
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Critical
> Fix For: 1.2.0
>
>
> I have a template that I generated. Whenever I try to drop the template onto 
> the graph, and the UI gives me an error: "The specified observer identifier 
> already exists."
> Part of the template is added to the graph, but it then stops without adding 
> the rest of the components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3129) When adding template to flow, I receive failure message "The specified observer identifier already exists."

2016-11-30 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709295#comment-15709295
 ] 

ASF GitHub Bot commented on NIFI-3129:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1284
  
Thanks @markap14! This has been merged to master.


> When adding template to flow, I receive failure message "The specified 
> observer identifier already exists."
> ---
>
> Key: NIFI-3129
> URL: https://issues.apache.org/jira/browse/NIFI-3129
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Critical
> Fix For: 1.2.0
>
>
> I have a template that I generated. Whenever I try to drop the template onto 
> the graph, and the UI gives me an error: "The specified observer identifier 
> already exists."
> Part of the template is added to the graph, but it then stops without adding 
> the rest of the components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3129) When adding template to flow, I receive failure message "The specified observer identifier already exists."

2016-11-30 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709293#comment-15709293
 ] 

ASF subversion and git services commented on NIFI-3129:
---

Commit fff0148a0e057277b34e647ef31c441ed5b4bdc3 in nifi's branch 
refs/heads/master from [~markap14]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=fff0148 ]

NIFI-3129: When adding controller services to a snippet, ensure that we don't 
add the service multiple times, even when it's referenced by child process 
groups. This closes #1284


> When adding template to flow, I receive failure message "The specified 
> observer identifier already exists."
> ---
>
> Key: NIFI-3129
> URL: https://issues.apache.org/jira/browse/NIFI-3129
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Critical
> Fix For: 1.2.0
>
>
> I have a template that I generated. Whenever I try to drop the template onto 
> the graph, and the UI gives me an error: "The specified observer identifier 
> already exists."
> Part of the template is added to the graph, but it then stops without adding 
> the rest of the components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3129) When adding template to flow, I receive failure message "The specified observer identifier already exists."

2016-11-30 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709152#comment-15709152
 ] 

ASF GitHub Bot commented on NIFI-3129:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1284
  
Will review...


> When adding template to flow, I receive failure message "The specified 
> observer identifier already exists."
> ---
>
> Key: NIFI-3129
> URL: https://issues.apache.org/jira/browse/NIFI-3129
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Critical
> Fix For: 1.2.0
>
>
> I have a template that I generated. Whenever I try to drop the template onto 
> the graph, and the UI gives me an error: "The specified observer identifier 
> already exists."
> Part of the template is added to the graph, but it then stops without adding 
> the rest of the components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3129) When adding template to flow, I receive failure message "The specified observer identifier already exists."

2016-11-30 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708981#comment-15708981
 ] 

ASF GitHub Bot commented on NIFI-3129:
--

GitHub user markap14 opened a pull request:

https://github.com/apache/nifi/pull/1284

NIFI-3129: When adding controller services to a snippet, ensure that …

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.

…we don't add the service multiple times, even when it's referenced by 
child process groups

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/markap14/nifi NIFI-3129

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1284


commit a091b4be37b51dc53b35d5f817bdbfc149562592
Author: Mark Payne 
Date:   2016-11-30T16:07:32Z

NIFI-3129: When adding controller services to a snippet, ensure that we 
don't add the service multiple times, even when it's referenced by child 
process groups




> When adding template to flow, I receive failure message "The specified 
> observer identifier already exists."
> ---
>
> Key: NIFI-3129
> URL: https://issues.apache.org/jira/browse/NIFI-3129
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Critical
> Fix For: 1.2.0
>
>
> I have a template that I generated. Whenever I try to drop the template onto 
> the graph, and the UI gives me an error: "The specified observer identifier 
> already exists."
> Part of the template is added to the graph, but it then stops without adding 
> the rest of the components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3129) When adding template to flow, I receive failure message "The specified observer identifier already exists."

2016-11-30 Thread Mark Payne (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708959#comment-15708959
 ] 

Mark Payne commented on NIFI-3129:
--

Looking at the template, it appears that the Controller Service is actually 
listed twice within the Template: once for the parent Process Group and once in 
the child Process Group. Within the child Process Group, the Controller Service 
is listed with a Parent Group ID that points to the parent group, not the 
child. It seems that when we create a snippet that includes Controller 
Services, as would be the case in a Template, that we add all Controller 
Services that are referenced, for each group that they are referenced in, 
instead of just adding it to the upper-most level.

> When adding template to flow, I receive failure message "The specified 
> observer identifier already exists."
> ---
>
> Key: NIFI-3129
> URL: https://issues.apache.org/jira/browse/NIFI-3129
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Critical
> Fix For: 1.2.0
>
>
> I have a template that I generated. Whenever I try to drop the template onto 
> the graph, and the UI gives me an error: "The specified observer identifier 
> already exists."
> Part of the template is added to the graph, but it then stops without adding 
> the rest of the components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)