[jira] [Commented] (NIFI-4403) Add group name in bulletin data

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176611#comment-16176611
 ] 

ASF GitHub Bot commented on NIFI-4403:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2167


> Add group name in bulletin data
> ---
>
> Key: NIFI-4403
> URL: https://issues.apache.org/jira/browse/NIFI-4403
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.4.0
>
>
> At the moment a bulletin includes the following information:
> - timestamp
> - id
> - nodeAddress
> - level
> - category
>   - message
> - groupId
>  - sourceId
>  - sourceName
>  - sourceType
> When S2S is used to redirect bulletins to external monitoring tools it'd be 
> useful to also indicate the group name in addition to the group id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4403) Add group name in bulletin data

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176610#comment-16176610
 ] 

ASF subversion and git services commented on NIFI-4403:
---

Commit 50d018566db4d2c6f97995dcde7a180d7e154ae6 in nifi's branch 
refs/heads/master from [~pvillard]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=50d0185 ]

NIFI-4403 - add group name to bulletins model. This closes #2167


> Add group name in bulletin data
> ---
>
> Key: NIFI-4403
> URL: https://issues.apache.org/jira/browse/NIFI-4403
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.4.0
>
>
> At the moment a bulletin includes the following information:
> - timestamp
> - id
> - nodeAddress
> - level
> - category
>   - message
> - groupId
>  - sourceId
>  - sourceName
>  - sourceType
> When S2S is used to redirect bulletins to external monitoring tools it'd be 
> useful to also indicate the group name in addition to the group id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4403) Add group name in bulletin data

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175343#comment-16175343
 ] 

ASF GitHub Bot commented on NIFI-4403:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2167
  
Thanks @mcgilman - it should be OK now: group name is only on server side 
and only exposed through the reporting task.


> Add group name in bulletin data
> ---
>
> Key: NIFI-4403
> URL: https://issues.apache.org/jira/browse/NIFI-4403
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
>
> At the moment a bulletin includes the following information:
> - timestamp
> - id
> - nodeAddress
> - level
> - category
>   - message
> - groupId
>  - sourceId
>  - sourceName
>  - sourceType
> When S2S is used to redirect bulletins to external monitoring tools it'd be 
> useful to also indicate the group name in addition to the group id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4403) Add group name in bulletin data

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175094#comment-16175094
 ] 

ASF GitHub Bot commented on NIFI-4403:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2167
  
That is correct. Knowledge of the components (UUID, status, etc) is 
allowed. Knowledge of what those components are/how they are configured is not.


> Add group name in bulletin data
> ---
>
> Key: NIFI-4403
> URL: https://issues.apache.org/jira/browse/NIFI-4403
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
>
> At the moment a bulletin includes the following information:
> - timestamp
> - id
> - nodeAddress
> - level
> - category
>   - message
> - groupId
>  - sourceId
>  - sourceName
>  - sourceType
> When S2S is used to redirect bulletins to external monitoring tools it'd be 
> useful to also indicate the group name in addition to the group id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4403) Add group name in bulletin data

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175027#comment-16175027
 ] 

ASF GitHub Bot commented on NIFI-4403:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2167
  
Good point. Just to be sure: we allow the user to see the group UUID but we 
don't want to make readable the associated group name. Right? I'll remove the 
group name reference in bulletin entity and bulletin dto.


> Add group name in bulletin data
> ---
>
> Key: NIFI-4403
> URL: https://issues.apache.org/jira/browse/NIFI-4403
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
>
> At the moment a bulletin includes the following information:
> - timestamp
> - id
> - nodeAddress
> - level
> - category
>   - message
> - groupId
>  - sourceId
>  - sourceName
>  - sourceType
> When S2S is used to redirect bulletins to external monitoring tools it'd be 
> useful to also indicate the group name in addition to the group id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4403) Add group name in bulletin data

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174911#comment-16174911
 ] 

ASF GitHub Bot commented on NIFI-4403:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2167
  
I don't think we can always add the group name to the BulletinDTO. A user 
could have permissions to the component generating the bulletin but not the 
Process Group the component lives in. Adding it to the Bulletin model 
server-side and exposed via the ReportingContext should ok though.

FYI - The source name is fair game as the BulletinDto is not set in the 
BulletinEntity when they lack permissions to the source. 


> Add group name in bulletin data
> ---
>
> Key: NIFI-4403
> URL: https://issues.apache.org/jira/browse/NIFI-4403
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
>
> At the moment a bulletin includes the following information:
> - timestamp
> - id
> - nodeAddress
> - level
> - category
>   - message
> - groupId
>  - sourceId
>  - sourceName
>  - sourceType
> When S2S is used to redirect bulletins to external monitoring tools it'd be 
> useful to also indicate the group name in addition to the group id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4403) Add group name in bulletin data

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174873#comment-16174873
 ] 

ASF GitHub Bot commented on NIFI-4403:
--

GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/2167

NIFI-4403 - add group name to bulletins model & S2S bulletin reporting task

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-4403

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2167.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2167


commit f93ea715eb186519579d3bbfa8ab230aa4e28143
Author: Pierre Villard 
Date:   2017-09-21T12:12:29Z

NIFI-4403 - add group name to bulletins model




> Add group name in bulletin data
> ---
>
> Key: NIFI-4403
> URL: https://issues.apache.org/jira/browse/NIFI-4403
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Minor
>
> At the moment a bulletin includes the following information:
> - timestamp
> - id
> - nodeAddress
> - level
> - category
>   - message
> - groupId
>  - sourceId
>  - sourceName
>  - sourceType
> When S2S is used to redirect bulletins to external monitoring tools it'd be 
> useful to also indicate the group name in addition to the group id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)