[jira] [Commented] (NIFI-4862) Add Copy original attributes to SelectHiveQL processor

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430195#comment-16430195
 ] 

ASF subversion and git services commented on NIFI-4862:
---

Commit ae1d3e39456b364b776d73f46b39e87272e52865 in nifi's branch 
refs/heads/master from [~ca9mbu]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=ae1d3e3 ]

NIFI-4862: Keep incoming flowfile attributes in outgoing flowfiles from 
SelectHiveQL

This closes #2605.

Signed-off-by: Koji Kawamura 


> Add Copy original attributes to SelectHiveQL processor
> --
>
> Key: NIFI-4862
> URL: https://issues.apache.org/jira/browse/NIFI-4862
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.5.0
>Reporter: Jakub Leś
>Priority: Minor
> Attachments: 
> 0001-NIFI-4862-Add-Copy-original-attributtes-to-SelectHiv.patch
>
>
> Hi, 
> Please add "Copy original attributes" to processor SelectHiveQL. Thanks to 
> that we can use HttpRequest and HttpResponse to synchronize fetching query 
> result in webservice.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4862) Add Copy original attributes to SelectHiveQL processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430198#comment-16430198
 ] 

ASF GitHub Bot commented on NIFI-4862:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2605


> Add Copy original attributes to SelectHiveQL processor
> --
>
> Key: NIFI-4862
> URL: https://issues.apache.org/jira/browse/NIFI-4862
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.5.0
>Reporter: Jakub Leś
>Priority: Minor
> Attachments: 
> 0001-NIFI-4862-Add-Copy-original-attributtes-to-SelectHiv.patch
>
>
> Hi, 
> Please add "Copy original attributes" to processor SelectHiveQL. Thanks to 
> that we can use HttpRequest and HttpResponse to synchronize fetching query 
> result in webservice.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4862) Add Copy original attributes to SelectHiveQL processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430192#comment-16430192
 ] 

ASF GitHub Bot commented on NIFI-4862:
--

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/2605
  
@mattyb149 Thanks for the fix. I confirmed the attributes in the incoming 
FlowFile are carried to the outgoing FlowFiles. Two FlowFiles were created by 
SelectHiveQL in the flow below, from 1 incoming FlowFile. NiFi provenance 
events look correct. I was able to render following graph with Atlas.


![image](https://user-images.githubusercontent.com/1107620/38484186-b66e3a74-3c10-11e8-8924-5b0d40f18003.png)


![image](https://user-images.githubusercontent.com/1107620/38484739-8577ef58-3c12-11e8-8e90-dffccbab104d.png)


![image](https://user-images.githubusercontent.com/1107620/38484149-931fb034-3c10-11e8-92fd-0931bf05df48.png)

LGTM +1, merging to master.


> Add Copy original attributes to SelectHiveQL processor
> --
>
> Key: NIFI-4862
> URL: https://issues.apache.org/jira/browse/NIFI-4862
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.5.0
>Reporter: Jakub Leś
>Priority: Minor
> Attachments: 
> 0001-NIFI-4862-Add-Copy-original-attributtes-to-SelectHiv.patch
>
>
> Hi, 
> Please add "Copy original attributes" to processor SelectHiveQL. Thanks to 
> that we can use HttpRequest and HttpResponse to synchronize fetching query 
> result in webservice.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4862) Add Copy original attributes to SelectHiveQL processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428121#comment-16428121
 ] 

ASF GitHub Bot commented on NIFI-4862:
--

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/2605
  
@mattyb149 I'm going to review it, thanks!


> Add Copy original attributes to SelectHiveQL processor
> --
>
> Key: NIFI-4862
> URL: https://issues.apache.org/jira/browse/NIFI-4862
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.5.0
>Reporter: Jakub Leś
>Priority: Minor
> Attachments: 
> 0001-NIFI-4862-Add-Copy-original-attributtes-to-SelectHiv.patch
>
>
> Hi, 
> Please add "Copy original attributes" to processor SelectHiveQL. Thanks to 
> that we can use HttpRequest and HttpResponse to synchronize fetching query 
> result in webservice.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4862) Add Copy original attributes to SelectHiveQL processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426077#comment-16426077
 ] 

ASF GitHub Bot commented on NIFI-4862:
--

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/2605
  
@ijokarumawak Mind taking a look at this one? It changed the order of 
provenance events so it touched your code for emitting a FETCH-FORK (now it's a 
FORK-FETCH). Just want to make sure the provenance chain is clear, simple, and 
complete. Thanks in advance!


> Add Copy original attributes to SelectHiveQL processor
> --
>
> Key: NIFI-4862
> URL: https://issues.apache.org/jira/browse/NIFI-4862
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.5.0
>Reporter: Jakub Leś
>Priority: Minor
> Attachments: 
> 0001-NIFI-4862-Add-Copy-original-attributtes-to-SelectHiv.patch
>
>
> Hi, 
> Please add "Copy original attributes" to processor SelectHiveQL. Thanks to 
> that we can use HttpRequest and HttpResponse to synchronize fetching query 
> result in webservice.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4862) Add Copy original attributes to SelectHiveQL processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426076#comment-16426076
 ] 

ASF GitHub Bot commented on NIFI-4862:
--

GitHub user mattyb149 opened a pull request:

https://github.com/apache/nifi/pull/2605

NIFI-4862: Keep incoming flowfile attributes in outgoing flowfiles from 
SelectHiveQL

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mattyb149/nifi NIFI-4862

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2605.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2605


commit cbd0e10b9ef6d692841b551764388c5973bdfb75
Author: Matthew Burgess 
Date:   2018-04-04T19:38:24Z

NIFI-4862: Keep incoming flowfile attributes in outgoing flowfiles from 
SelectHiveQL




> Add Copy original attributes to SelectHiveQL processor
> --
>
> Key: NIFI-4862
> URL: https://issues.apache.org/jira/browse/NIFI-4862
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.5.0
>Reporter: Jakub Leś
>Priority: Minor
> Attachments: 
> 0001-NIFI-4862-Add-Copy-original-attributtes-to-SelectHiv.patch
>
>
> Hi, 
> Please add "Copy original attributes" to processor SelectHiveQL. Thanks to 
> that we can use HttpRequest and HttpResponse to synchronize fetching query 
> result in webservice.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4862) Add Copy original attributes to SelectHiveQL processor

[Matt Burgess (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426049#comment-16426049
 ] 

Matt Burgess commented on NIFI-4862:


This is actually a regression caused by a logic bug in NIFI-4473. Rather than 
add another property to choose whether or not to include the original 
attribute, I propose we reinstate the original behavior, where if there is an 
incoming flow file, its attributes will be transferred to the outgoing flow 
file(s).

> Add Copy original attributes to SelectHiveQL processor
> --
>
> Key: NIFI-4862
> URL: https://issues.apache.org/jira/browse/NIFI-4862
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.5.0
>Reporter: Jakub Leś
>Priority: Minor
> Attachments: 
> 0001-NIFI-4862-Add-Copy-original-attributtes-to-SelectHiv.patch
>
>
> Hi, 
> Please add "Copy original attributes" to processor SelectHiveQL. Thanks to 
> that we can use HttpRequest and HttpResponse to synchronize fetching query 
> result in webservice.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)