[jira] [Commented] (NIFI-4938) Offline buffering is not supported by paho client version 1.0.2 used in mqtt processors.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470120#comment-16470120
 ] 

ASF GitHub Bot commented on NIFI-4938:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2514


> Offline buffering is not supported by paho client version 1.0.2 used in mqtt 
> processors.
> 
>
> Key: NIFI-4938
> URL: https://issues.apache.org/jira/browse/NIFI-4938
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Himanshu Mishra
>Priority: Major
> Fix For: 1.7.0
>
>
> Off line buffering is not supported by paho client version 1.0.2 used in mqtt 
> processors which causes problem of "message loss" with QoS 1 and QoS 2 for 
> mqtt messages when the client connectivity is lost.
> The version 1.2.0 of paho client supports this off line buffering. Thus 
> addressing this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4938) Offline buffering is not supported by paho client version 1.0.2 used in mqtt processors.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470117#comment-16470117
 ] 

ASF subversion and git services commented on NIFI-4938:
---

Commit 6e0be8e6414b489aa4c86a71cd0b271ce4e23f96 in nifi's branch 
refs/heads/master from [~HMDC]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=6e0be8e ]

NIFI-4938 Upgraded org.eclipse.paho.client.mqttv3 dependency version to 1.2.0

Signed-off-by: Pierre Villard 

This closes #2514.


> Offline buffering is not supported by paho client version 1.0.2 used in mqtt 
> processors.
> 
>
> Key: NIFI-4938
> URL: https://issues.apache.org/jira/browse/NIFI-4938
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Himanshu Mishra
>Priority: Major
> Fix For: 1.7.0
>
>
> Off line buffering is not supported by paho client version 1.0.2 used in mqtt 
> processors which causes problem of "message loss" with QoS 1 and QoS 2 for 
> mqtt messages when the client connectivity is lost.
> The version 1.2.0 of paho client supports this off line buffering. Thus 
> addressing this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4938) Offline buffering is not supported by paho client version 1.0.2 used in mqtt processors.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470109#comment-16470109
 ] 

ASF GitHub Bot commented on NIFI-4938:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2514
  
LGTM. Checked release notes of the updated library and dependency tree to 
ensure there is nothing wrong here. I've only one request: to also update the 
version in the notice files (in this bundle and the assembly one). Will take 
care of this while merging. Thanks!


> Offline buffering is not supported by paho client version 1.0.2 used in mqtt 
> processors.
> 
>
> Key: NIFI-4938
> URL: https://issues.apache.org/jira/browse/NIFI-4938
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Himanshu Mishra
>Priority: Major
>
> Off line buffering is not supported by paho client version 1.0.2 used in mqtt 
> processors which causes problem of "message loss" with QoS 1 and QoS 2 for 
> mqtt messages when the client connectivity is lost.
> The version 1.2.0 of paho client supports this off line buffering. Thus 
> addressing this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4938) Offline buffering is not supported by paho client version 1.0.2 used in mqtt processors.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389296#comment-16389296
 ] 

ASF GitHub Bot commented on NIFI-4938:
--

Github user Himanshu-it commented on the issue:

https://github.com/apache/nifi/pull/2514
  
continuous integration with travis falis with concurrent modification error 
in 
"TestFileSystemRepository.testMinimalArchiveCleanupIntervalHonoredAndLogged:151",
 but locally I have build with
mvn clean install and mvn -Pcontrib-check clean install, both are working 
fine. Any pointers on this. 


> Offline buffering is not supported by paho client version 1.0.2 used in mqtt 
> processors.
> 
>
> Key: NIFI-4938
> URL: https://issues.apache.org/jira/browse/NIFI-4938
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Himanshu Mishra
>Priority: Major
>
> Off line buffering is not supported by paho client version 1.0.2 used in mqtt 
> processors which causes problem of "message loss" with QoS 1 and QoS 2 for 
> mqtt messages when the client connectivity is lost.
> The version 1.2.0 of paho client supports this off line buffering. Thus 
> addressing this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4938) Offline buffering is not supported by paho client version 1.0.2 used in mqtt processors.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389075#comment-16389075
 ] 

ASF GitHub Bot commented on NIFI-4938:
--

Github user Himanshu-it commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2514#discussion_r172748974
  
--- Diff: 
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/test/java/org/apache/nifi/processors/mqtt/common/MqttTestClient.java
 ---
@@ -17,16 +17,7 @@
 
 package org.apache.nifi.processors.mqtt.common;
 
-import org.eclipse.paho.client.mqttv3.IMqttClient;
-import org.eclipse.paho.client.mqttv3.IMqttDeliveryToken;
-import org.eclipse.paho.client.mqttv3.IMqttToken;
-import org.eclipse.paho.client.mqttv3.MqttCallback;
-import org.eclipse.paho.client.mqttv3.MqttConnectOptions;
-import org.eclipse.paho.client.mqttv3.MqttException;
-import org.eclipse.paho.client.mqttv3.MqttMessage;
-import org.eclipse.paho.client.mqttv3.MqttPersistenceException;
-import org.eclipse.paho.client.mqttv3.MqttSecurityException;
-import org.eclipse.paho.client.mqttv3.MqttTopic;
+import org.eclipse.paho.client.mqttv3.*;
--- End diff --

sure thanks.


> Offline buffering is not supported by paho client version 1.0.2 used in mqtt 
> processors.
> 
>
> Key: NIFI-4938
> URL: https://issues.apache.org/jira/browse/NIFI-4938
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Himanshu Mishra
>Priority: Major
>
> Off line buffering is not supported by paho client version 1.0.2 used in mqtt 
> processors which causes problem of "message loss" with QoS 1 and QoS 2 for 
> mqtt messages when the client connectivity is lost.
> The version 1.2.0 of paho client supports this off line buffering. Thus 
> addressing this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4938) Offline buffering is not supported by paho client version 1.0.2 used in mqtt processors.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387798#comment-16387798
 ] 

ASF GitHub Bot commented on NIFI-4938:
--

Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2514#discussion_r172519579
  
--- Diff: 
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/test/java/org/apache/nifi/processors/mqtt/common/MqttTestClient.java
 ---
@@ -17,16 +17,7 @@
 
 package org.apache.nifi.processors.mqtt.common;
 
-import org.eclipse.paho.client.mqttv3.IMqttClient;
-import org.eclipse.paho.client.mqttv3.IMqttDeliveryToken;
-import org.eclipse.paho.client.mqttv3.IMqttToken;
-import org.eclipse.paho.client.mqttv3.MqttCallback;
-import org.eclipse.paho.client.mqttv3.MqttConnectOptions;
-import org.eclipse.paho.client.mqttv3.MqttException;
-import org.eclipse.paho.client.mqttv3.MqttMessage;
-import org.eclipse.paho.client.mqttv3.MqttPersistenceException;
-import org.eclipse.paho.client.mqttv3.MqttSecurityException;
-import org.eclipse.paho.client.mqttv3.MqttTopic;
+import org.eclipse.paho.client.mqttv3.*;
--- End diff --

please avoid star import.  Be sure to run 

mvn clean install -Pcontrib-check


> Offline buffering is not supported by paho client version 1.0.2 used in mqtt 
> processors.
> 
>
> Key: NIFI-4938
> URL: https://issues.apache.org/jira/browse/NIFI-4938
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Himanshu Mishra
>Priority: Major
>
> Off line buffering is not supported by paho client version 1.0.2 used in mqtt 
> processors which causes problem of "message loss" with QoS 1 and QoS 2 for 
> mqtt messages when the client connectivity is lost.
> The version 1.2.0 of paho client supports this off line buffering. Thus 
> addressing this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4938) Offline buffering is not supported by paho client version 1.0.2 used in mqtt processors.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387794#comment-16387794
 ] 

ASF GitHub Bot commented on NIFI-4938:
--

GitHub user Himanshu-it opened a pull request:

https://github.com/apache/nifi/pull/2514

NIFI-4938 Upgraded org.eclipse.paho.client.mqttv3 dependency version …

Off line buffering for mqtt messages will now be supported with the version 
of paho client being updated to 1.2.0 from 1.0.2 .


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Himanshu-it/nifi 
NIFI-4938-Offline-mqtt-message-buffering-support-for-mqtt-processors-with-QoS1-and-Qos2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2514


commit 49f1410c7bf61edfe9a9fb19f566743590f50636
Author: himanshu 
Date:   2018-03-06T13:38:50Z

NIFI-4938 Upgraded org.eclipse.paho.client.mqttv3 dependency version to 
1.2.0




> Offline buffering is not supported by paho client version 1.0.2 used in mqtt 
> processors.
> 
>
> Key: NIFI-4938
> URL: https://issues.apache.org/jira/browse/NIFI-4938
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Himanshu Mishra
>Priority: Major
>
> Off line buffering is not supported by paho client version 1.0.2 used in mqtt 
> processors which causes problem of "message loss" with QoS 1 and QoS 2 for 
> mqtt messages when the client connectivity is lost.
> The version 1.2.0 of paho client supports this off line buffering. Thus 
> addressing this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)