[jira] [Commented] (NIFI-4940) CSVReader - Header schema strategy - normalize names

2018-03-06 Thread Pierre Villard (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388518#comment-16388518
 ] 

Pierre Villard commented on NIFI-4940:
--

Thanks for your comment [~markap14]! I didn't pay close attention.

It's possible to escape the field names when using a record path:
{code:java}
/'my id'/childField{code}

> CSVReader - Header schema strategy - normalize names
> 
>
> Key: NIFI-4940
> URL: https://issues.apache.org/jira/browse/NIFI-4940
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>
> When using the CSV Reader with the Header Schema Strategy access, we should 
> add a property (boolean) in case field names should be normalized to be avro 
> compatible. Otherwise it won't be possible, for instance, to use the 
> UpdateRecord processor and access a field with a "weird" name.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4940) CSVReader - Header schema strategy - normalize names

2018-03-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388511#comment-16388511
 ] 

ASF GitHub Bot commented on NIFI-4940:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2513
  
Closing as per comment from Mark in the JIRA. What I was trying to achieve 
can already be done and works nicely :) Thanks anyway for having a look 
@zenfenan !


> CSVReader - Header schema strategy - normalize names
> 
>
> Key: NIFI-4940
> URL: https://issues.apache.org/jira/browse/NIFI-4940
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>
> When using the CSV Reader with the Header Schema Strategy access, we should 
> add a property (boolean) in case field names should be normalized to be avro 
> compatible. Otherwise it won't be possible, for instance, to use the 
> UpdateRecord processor and access a field with a "weird" name.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4940) CSVReader - Header schema strategy - normalize names

2018-03-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388512#comment-16388512
 ] 

ASF GitHub Bot commented on NIFI-4940:
--

Github user pvillard31 closed the pull request at:

https://github.com/apache/nifi/pull/2513


> CSVReader - Header schema strategy - normalize names
> 
>
> Key: NIFI-4940
> URL: https://issues.apache.org/jira/browse/NIFI-4940
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>
> When using the CSV Reader with the Header Schema Strategy access, we should 
> add a property (boolean) in case field names should be normalized to be avro 
> compatible. Otherwise it won't be possible, for instance, to use the 
> UpdateRecord processor and access a field with a "weird" name.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4940) CSVReader - Header schema strategy - normalize names

2018-03-06 Thread Mark Payne (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388457#comment-16388457
 ] 

Mark Payne commented on NIFI-4940:
--

[~pvillard] I am probably just missing something obvious here, but I'm not sure 
that I'm following the intent here exactly. It feels very odd to me to have an 
option to "Normalize Column Names for Avro" type of option on the CSV Reader. 
You also mention that UpdateRecord is not working as expected with "weird" 
column names - so not sure how that ties into Avro. Is the concern here that 
RecordPath is not properly evaluating the field names in some cases? Or is your 
UpdateRecord processor configured with an Avro Writer and that's causing 
failures?

> CSVReader - Header schema strategy - normalize names
> 
>
> Key: NIFI-4940
> URL: https://issues.apache.org/jira/browse/NIFI-4940
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>
> When using the CSV Reader with the Header Schema Strategy access, we should 
> add a property (boolean) in case field names should be normalized to be avro 
> compatible. Otherwise it won't be possible, for instance, to use the 
> UpdateRecord processor and access a field with a "weird" name.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4940) CSVReader - Header schema strategy - normalize names

2018-03-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388109#comment-16388109
 ] 

ASF GitHub Bot commented on NIFI-4940:
--

Github user zenfenan commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2513#discussion_r172590173
  
--- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/csv/CSVHeaderSchemaStrategy.java
 ---
@@ -79,4 +81,12 @@ public RecordSchema getSchema(Map 
variables, final InputStream c
 public Set getSuppliedSchemaFields() {
 return schemaFields;
 }
+
+private String normalizeNameForAvro(String inputName) {
+String normalizedName = inputName.replaceAll("[^A-Za-z0-9_]", "_");
--- End diff --

How about this `[^A-Za-z0-9_]+`? So rather than adding N underscores for 
continuous non-compatible characters, it adds a single `_`. 


> CSVReader - Header schema strategy - normalize names
> 
>
> Key: NIFI-4940
> URL: https://issues.apache.org/jira/browse/NIFI-4940
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>
> When using the CSV Reader with the Header Schema Strategy access, we should 
> add a property (boolean) in case field names should be normalized to be avro 
> compatible. Otherwise it won't be possible, for instance, to use the 
> UpdateRecord processor and access a field with a "weird" name.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4940) CSVReader - Header schema strategy - normalize names

2018-03-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387770#comment-16387770
 ] 

ASF GitHub Bot commented on NIFI-4940:
--

GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/2513

NIFI-4940 - CSVReader - Header schema strategy - normalize names

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-4940

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2513.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2513


commit d6cf8b7ccb0d4877c3ffd422b67ee53d37f46853
Author: Pierre Villard 
Date:   2018-03-06T13:32:29Z

NIFI-4940 - CSVReader - Header schema strategy - normalize names




> CSVReader - Header schema strategy - normalize names
> 
>
> Key: NIFI-4940
> URL: https://issues.apache.org/jira/browse/NIFI-4940
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>
> When using the CSV Reader with the Header Schema Strategy access, we should 
> add a property (boolean) in case field names should be normalized to be avro 
> compatible. Otherwise it won't be possible, for instance, to use the 
> UpdateRecord processor and access a field with a "weird" name.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)