[jira] [Commented] (NIFI-4944) PutHiveStreaming multiple instances with Snappy fail intermittently
[
https://issues.apache.org/jira/browse/NIFI-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395575#comment-16395575
]
ASF GitHub Bot commented on NIFI-4944:
--
Github user moonkev commented on the issue:
https://github.com/apache/nifi/pull/2519
I was aware that PutHiveStreaming used snappy-java vs native snappy, but
was unaware of the methods that snappy-java protect against loading in multiple
class loaders. Many thanks for the detailed explanation @mcgilman!
> PutHiveStreaming multiple instances with Snappy fail intermittently
> ---
>
> Key: NIFI-4944
> URL: https://issues.apache.org/jira/browse/NIFI-4944
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
> Fix For: 1.6.0
>
>
> When data coming into PutHiveStreaming is compressed with Snappy, then
> multiple instances of PutHiveStreaming in a flow can cause a failure, the log
> often shows the following:
> {{org.apache.nifi.processors.hive.PutHiveStreaming$$Lambda$510/1467586448@68a5884d
> failed to process due to org.xerial.snappy.SnappyError:
> [FAILED_TO_LOAD_NATIVE_LIBRARY] null; rolling back session: {}}}
> This is due to a race condition in Snappy 1.0.5 (the version used by the Hive
> NAR) where two classloaders can try to define the native loader class, thus
> the second one would fail, giving the error above.
> The proposed solution is to guarantee that Snappy is loaded before this
> situation is encountered (i.e. before the InstanceClassLoaders are created).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4944) PutHiveStreaming multiple instances with Snappy fail intermittently
[
https://issues.apache.org/jira/browse/NIFI-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395549#comment-16395549
]
ASF GitHub Bot commented on NIFI-4944:
--
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2519
Thanks @mattyb149! This has been merged to master.
> PutHiveStreaming multiple instances with Snappy fail intermittently
> ---
>
> Key: NIFI-4944
> URL: https://issues.apache.org/jira/browse/NIFI-4944
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
> Fix For: 1.6.0
>
>
> When data coming into PutHiveStreaming is compressed with Snappy, then
> multiple instances of PutHiveStreaming in a flow can cause a failure, the log
> often shows the following:
> {{org.apache.nifi.processors.hive.PutHiveStreaming$$Lambda$510/1467586448@68a5884d
> failed to process due to org.xerial.snappy.SnappyError:
> [FAILED_TO_LOAD_NATIVE_LIBRARY] null; rolling back session: {}}}
> This is due to a race condition in Snappy 1.0.5 (the version used by the Hive
> NAR) where two classloaders can try to define the native loader class, thus
> the second one would fail, giving the error above.
> The proposed solution is to guarantee that Snappy is loaded before this
> situation is encountered (i.e. before the InstanceClassLoaders are created).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4944) PutHiveStreaming multiple instances with Snappy fail intermittently
[
https://issues.apache.org/jira/browse/NIFI-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395550#comment-16395550
]
ASF GitHub Bot commented on NIFI-4944:
--
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2519
> PutHiveStreaming multiple instances with Snappy fail intermittently
> ---
>
> Key: NIFI-4944
> URL: https://issues.apache.org/jira/browse/NIFI-4944
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
> Fix For: 1.6.0
>
>
> When data coming into PutHiveStreaming is compressed with Snappy, then
> multiple instances of PutHiveStreaming in a flow can cause a failure, the log
> often shows the following:
> {{org.apache.nifi.processors.hive.PutHiveStreaming$$Lambda$510/1467586448@68a5884d
> failed to process due to org.xerial.snappy.SnappyError:
> [FAILED_TO_LOAD_NATIVE_LIBRARY] null; rolling back session: {}}}
> This is due to a race condition in Snappy 1.0.5 (the version used by the Hive
> NAR) where two classloaders can try to define the native loader class, thus
> the second one would fail, giving the error above.
> The proposed solution is to guarantee that Snappy is loaded before this
> situation is encountered (i.e. before the InstanceClassLoaders are created).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4944) PutHiveStreaming multiple instances with Snappy fail intermittently
[
https://issues.apache.org/jira/browse/NIFI-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395548#comment-16395548
]
ASF subversion and git services commented on NIFI-4944:
---
Commit d4632bdd5dce85cc7adb8c70bafda44d6a333da9 in nifi's branch
refs/heads/master from [~ca9mbu]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=d4632bd ]
NIFI-4944: Guard against race condition in Snappy for PutHiveStreaming
NIFI-4944: Removed unnecessary synchronized block, added more comments
This closes #2519
> PutHiveStreaming multiple instances with Snappy fail intermittently
> ---
>
> Key: NIFI-4944
> URL: https://issues.apache.org/jira/browse/NIFI-4944
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
>
> When data coming into PutHiveStreaming is compressed with Snappy, then
> multiple instances of PutHiveStreaming in a flow can cause a failure, the log
> often shows the following:
> {{org.apache.nifi.processors.hive.PutHiveStreaming$$Lambda$510/1467586448@68a5884d
> failed to process due to org.xerial.snappy.SnappyError:
> [FAILED_TO_LOAD_NATIVE_LIBRARY] null; rolling back session: {}}}
> This is due to a race condition in Snappy 1.0.5 (the version used by the Hive
> NAR) where two classloaders can try to define the native loader class, thus
> the second one would fail, giving the error above.
> The proposed solution is to guarantee that Snappy is loaded before this
> situation is encountered (i.e. before the InstanceClassLoaders are created).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4944) PutHiveStreaming multiple instances with Snappy fail intermittently
[
https://issues.apache.org/jira/browse/NIFI-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395547#comment-16395547
]
ASF subversion and git services commented on NIFI-4944:
---
Commit d4632bdd5dce85cc7adb8c70bafda44d6a333da9 in nifi's branch
refs/heads/master from [~ca9mbu]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=d4632bd ]
NIFI-4944: Guard against race condition in Snappy for PutHiveStreaming
NIFI-4944: Removed unnecessary synchronized block, added more comments
This closes #2519
> PutHiveStreaming multiple instances with Snappy fail intermittently
> ---
>
> Key: NIFI-4944
> URL: https://issues.apache.org/jira/browse/NIFI-4944
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
>
> When data coming into PutHiveStreaming is compressed with Snappy, then
> multiple instances of PutHiveStreaming in a flow can cause a failure, the log
> often shows the following:
> {{org.apache.nifi.processors.hive.PutHiveStreaming$$Lambda$510/1467586448@68a5884d
> failed to process due to org.xerial.snappy.SnappyError:
> [FAILED_TO_LOAD_NATIVE_LIBRARY] null; rolling back session: {}}}
> This is due to a race condition in Snappy 1.0.5 (the version used by the Hive
> NAR) where two classloaders can try to define the native loader class, thus
> the second one would fail, giving the error above.
> The proposed solution is to guarantee that Snappy is loaded before this
> situation is encountered (i.e. before the InstanceClassLoaders are created).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4944) PutHiveStreaming multiple instances with Snappy fail intermittently
[
https://issues.apache.org/jira/browse/NIFI-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393821#comment-16393821
]
ASF GitHub Bot commented on NIFI-4944:
--
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2519
@moonkev I think there a couple different scenario's here. This is
admittedly pretty complicated, but my understanding is as follows:
- In a case like PutHDFS, snappy compression is supported through the
native hadoop library. In this case, the native snappy library is not loaded.
Issues seen here are do to multiple classloaders attempting to load "hadoop"
native library.
- In a case like CompressContent, snappy support is supplied by the native
snappy library loaded indirectly through snappy-java. In more recent version,
they effectively bypass the native loading issues by copying the native library
to a temp directory and loading it with a UUID appended to the name. This
allows the native library to multiple times (since the name is different each
time).
- In a case like PutHiveStreaming, snappy support is also supplied through
snappy-java. The difference is that its an old version of snappy-java that does
not perform the UUID trick. Force upgrading in this case is tricky since it is
a transitive dependency (PutHiveStreaming -> Hive -> avro -> snappy). The
legacy snappy-java addresses the native library issue by directly injecting the
class that loads the native library into the root classloader. The ultimate
issue here was that multiple processors were attempting to do this loading at
the same time (due to the loading happening in onTrigger).
@mattyb149 Please chime in here if any of my understanding isn't correct.
Hope this helps
> PutHiveStreaming multiple instances with Snappy fail intermittently
> ---
>
> Key: NIFI-4944
> URL: https://issues.apache.org/jira/browse/NIFI-4944
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
>
> When data coming into PutHiveStreaming is compressed with Snappy, then
> multiple instances of PutHiveStreaming in a flow can cause a failure, the log
> often shows the following:
> {{org.apache.nifi.processors.hive.PutHiveStreaming$$Lambda$510/1467586448@68a5884d
> failed to process due to org.xerial.snappy.SnappyError:
> [FAILED_TO_LOAD_NATIVE_LIBRARY] null; rolling back session: {}}}
> This is due to a race condition in Snappy 1.0.5 (the version used by the Hive
> NAR) where two classloaders can try to define the native loader class, thus
> the second one would fail, giving the error above.
> The proposed solution is to guarantee that Snappy is loaded before this
> situation is encountered (i.e. before the InstanceClassLoaders are created).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4944) PutHiveStreaming multiple instances with Snappy fail intermittently
[
https://issues.apache.org/jira/browse/NIFI-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393729#comment-16393729
]
ASF GitHub Bot commented on NIFI-4944:
--
Github user moonkev commented on the issue:
https://github.com/apache/nifi/pull/2519
Hi
Seeing this same issue with the PutHDFS processor and came across this.
Curious with this solution, won't the same condition arise with this same
solution? Won't the static initializer here be called in each instance class
loader which makes use of this processor? I was reading
[here](https://bryanbende.com/development/2016/11/24/apache-nifi-class-loading)
and it seems that each processor itself will be loaded again, thus causing
snappy's static initializer to be called, which in turn will again attempt to
load its native library.
Thanks
Kevin
> PutHiveStreaming multiple instances with Snappy fail intermittently
> ---
>
> Key: NIFI-4944
> URL: https://issues.apache.org/jira/browse/NIFI-4944
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
>
> When data coming into PutHiveStreaming is compressed with Snappy, then
> multiple instances of PutHiveStreaming in a flow can cause a failure, the log
> often shows the following:
> {{org.apache.nifi.processors.hive.PutHiveStreaming$$Lambda$510/1467586448@68a5884d
> failed to process due to org.xerial.snappy.SnappyError:
> [FAILED_TO_LOAD_NATIVE_LIBRARY] null; rolling back session: {}}}
> This is due to a race condition in Snappy 1.0.5 (the version used by the Hive
> NAR) where two classloaders can try to define the native loader class, thus
> the second one would fail, giving the error above.
> The proposed solution is to guarantee that Snappy is loaded before this
> situation is encountered (i.e. before the InstanceClassLoaders are created).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4944) PutHiveStreaming multiple instances with Snappy fail intermittently
[
https://issues.apache.org/jira/browse/NIFI-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393083#comment-16393083
]
ASF GitHub Bot commented on NIFI-4944:
--
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2519
@mattyb149 Previously the loading of Snappy happened during onTrigger. This
could lead to the race condition described in the JIRA/PR. Moving this to a
static initializer should alleviate the issue. Additionally, the act of service
discovery (Java SPI) will load the class. Because of this, I actually don't
believe the synchronization here is necessary. Thoughts?
> PutHiveStreaming multiple instances with Snappy fail intermittently
> ---
>
> Key: NIFI-4944
> URL: https://issues.apache.org/jira/browse/NIFI-4944
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
>
> When data coming into PutHiveStreaming is compressed with Snappy, then
> multiple instances of PutHiveStreaming in a flow can cause a failure, the log
> often shows the following:
> {{org.apache.nifi.processors.hive.PutHiveStreaming$$Lambda$510/1467586448@68a5884d
> failed to process due to org.xerial.snappy.SnappyError:
> [FAILED_TO_LOAD_NATIVE_LIBRARY] null; rolling back session: {}}}
> This is due to a race condition in Snappy 1.0.5 (the version used by the Hive
> NAR) where two classloaders can try to define the native loader class, thus
> the second one would fail, giving the error above.
> The proposed solution is to guarantee that Snappy is loaded before this
> situation is encountered (i.e. before the InstanceClassLoaders are created).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4944) PutHiveStreaming multiple instances with Snappy fail intermittently
[
https://issues.apache.org/jira/browse/NIFI-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392223#comment-16392223
]
ASF GitHub Bot commented on NIFI-4944:
--
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2519
+1 LGTM. Unit tests ran and the solution looks like a sensible and
effective one.
> PutHiveStreaming multiple instances with Snappy fail intermittently
> ---
>
> Key: NIFI-4944
> URL: https://issues.apache.org/jira/browse/NIFI-4944
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
>
> When data coming into PutHiveStreaming is compressed with Snappy, then
> multiple instances of PutHiveStreaming in a flow can cause a failure, the log
> often shows the following:
> {{org.apache.nifi.processors.hive.PutHiveStreaming$$Lambda$510/1467586448@68a5884d
> failed to process due to org.xerial.snappy.SnappyError:
> [FAILED_TO_LOAD_NATIVE_LIBRARY] null; rolling back session: {}}}
> This is due to a race condition in Snappy 1.0.5 (the version used by the Hive
> NAR) where two classloaders can try to define the native loader class, thus
> the second one would fail, giving the error above.
> The proposed solution is to guarantee that Snappy is loaded before this
> situation is encountered (i.e. before the InstanceClassLoaders are created).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4944) PutHiveStreaming multiple instances with Snappy fail intermittently
[
https://issues.apache.org/jira/browse/NIFI-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390144#comment-16390144
]
ASF GitHub Bot commented on NIFI-4944:
--
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2519
NIFI-4944: Guard against race condition in Snappy for PutHiveStreaming
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-4944
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2519.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2519
commit 20de68f5e33039c2bb4d3ecd79eddd5e882aa8db
Author: Matthew Burgess
Date: 2018-03-07T20:19:39Z
NIFI-4944: Guard against race condition in Snappy for PutHiveStreaming
> PutHiveStreaming multiple instances with Snappy fail intermittently
> ---
>
> Key: NIFI-4944
> URL: https://issues.apache.org/jira/browse/NIFI-4944
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
>
> When data coming into PutHiveStreaming is compressed with Snappy, then
> multiple instances of PutHiveStreaming in a flow can cause a failure, the log
> often shows the following:
> org.apache.nifi.processors.hive.PutHiveStreaming$$Lambda$510/1467586448@68a5884d
> failed to process due to org.xerial.snappy.SnappyError:
> [FAILED_TO_LOAD_NATIVE_LIBRARY] null; rolling back session: {}
> This is due to a race condition in Snappy 1.0.5 (the version used by the Hive
> NAR) where two classloaders can try to define the native loader class, thus
> the second one would fail, giving the error above.
> The proposed solution is to guarantee that Snappy is loaded before this
> situation is encountered (i.e. before the InstanceClassLoaders are created).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
