[jira] [Commented] (NIFI-5116) Add ability for nifi-toolkit to prepare nifi.properties for use with CLI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454250#comment-16454250
 ] 

ASF GitHub Bot commented on NIFI-5116:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2660


> Add ability for nifi-toolkit to prepare nifi.properties for use with CLI 
> -
>
> Key: NIFI-5116
> URL: https://issues.apache.org/jira/browse/NIFI-5116
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Bende
>Assignee: Andy LoPresto
>Priority: Minor
> Fix For: 1.7.0
>
>
> Since the CLI needs to know the information to connect to a NiFi instance, 
> and this will typically be put into a properties for re-use with CLI 
> commands, it would be nice if there was an easy way to produce a CLI 
> properties file from a given nifi.properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5116) Add ability for nifi-toolkit to prepare nifi.properties for use with CLI

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454248#comment-16454248
 ] 

ASF subversion and git services commented on NIFI-5116:
---

Commit 4e4aa54c69ce991f7f7772cf95c666cd31610d23 in nifi's branch 
refs/heads/master from [~alopresto]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=4e4aa54 ]

NIFI-5116 Implemented logic to translate nifi.properties file to CLI properties 
format.
Added unit tests.

This closes #2660.

Signed-off-by: Bryan Bende 


> Add ability for nifi-toolkit to prepare nifi.properties for use with CLI 
> -
>
> Key: NIFI-5116
> URL: https://issues.apache.org/jira/browse/NIFI-5116
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Bende
>Assignee: Andy LoPresto
>Priority: Minor
> Fix For: 1.7.0
>
>
> Since the CLI needs to know the information to connect to a NiFi instance, 
> and this will typically be put into a properties for re-use with CLI 
> commands, it would be nice if there was an easy way to produce a CLI 
> properties file from a given nifi.properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5116) Add ability for nifi-toolkit to prepare nifi.properties for use with CLI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454245#comment-16454245
 ] 

ASF GitHub Bot commented on NIFI-5116:
--

Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/2660
  
Looks good, going to merge, thanks!


> Add ability for nifi-toolkit to prepare nifi.properties for use with CLI 
> -
>
> Key: NIFI-5116
> URL: https://issues.apache.org/jira/browse/NIFI-5116
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Bende
>Assignee: Andy LoPresto
>Priority: Minor
>
> Since the CLI needs to know the information to connect to a NiFi instance, 
> and this will typically be put into a properties for re-use with CLI 
> commands, it would be nice if there was an easy way to produce a CLI 
> properties file from a given nifi.properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5116) Add ability for nifi-toolkit to prepare nifi.properties for use with CLI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454185#comment-16454185
 ] 

ASF GitHub Bot commented on NIFI-5116:
--

Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/2660
  
Reviewing...


> Add ability for nifi-toolkit to prepare nifi.properties for use with CLI 
> -
>
> Key: NIFI-5116
> URL: https://issues.apache.org/jira/browse/NIFI-5116
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Bende
>Assignee: Andy LoPresto
>Priority: Minor
>
> Since the CLI needs to know the information to connect to a NiFi instance, 
> and this will typically be put into a properties for re-use with CLI 
> commands, it would be nice if there was an easy way to produce a CLI 
> properties file from a given nifi.properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5116) Add ability for nifi-toolkit to prepare nifi.properties for use with CLI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453199#comment-16453199
 ] 

ASF GitHub Bot commented on NIFI-5116:
--

GitHub user alopresto opened a pull request:

https://github.com/apache/nifi/pull/2660

NIFI-5116 Implemented logic to translate nifi.properties file to CLI …

…properties format.

Added unit tests.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alopresto/nifi NIFI-5116

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2660.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2660


commit 3acd47453374777fd3a9717d45b3a03d40b55b4d
Author: Andy LoPresto 
Date:   2018-04-25T22:27:05Z

NIFI-5116 Implemented logic to translate nifi.properties file to CLI 
properties format.
Added unit tests.




> Add ability for nifi-toolkit to prepare nifi.properties for use with CLI 
> -
>
> Key: NIFI-5116
> URL: https://issues.apache.org/jira/browse/NIFI-5116
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Bende
>Assignee: Andy LoPresto
>Priority: Minor
>
> Since the CLI needs to know the information to connect to a NiFi instance, 
> and this will typically be put into a properties for re-use with CLI 
> commands, it would be nice if there was an easy way to produce a CLI 
> properties file from a given nifi.properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)