[jira] [Commented] (NIFI-5202) TestListDatabaseTables timing issue
[
https://issues.apache.org/jira/browse/NIFI-5202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478910#comment-16478910
]
ASF GitHub Bot commented on NIFI-5202:
--
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2709
> TestListDatabaseTables timing issue
> ---
>
> Key: NIFI-5202
> URL: https://issues.apache.org/jira/browse/NIFI-5202
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: Mark Payne
>Assignee: Matt Burgess
>Priority: Major
>
> I sometimes see TestListDatabaseTables fail in Travis-CI:
> {code:java}
> [INFO] Results:
> [INFO]
> [ERROR] Failures:
> [ERROR] TestListDatabaseTables.testListTablesMultipleRefresh:218
> expected:<1> but was:<2>
> [INFO] {code}
> It appears to be a timing issue. When I run it on my laptop, it always
> succeeds, as-is. However, I can easily reproduce the error above if I update
> the unit test by adding a Thread.sleep at line 214:
> {code:java}
> assertEquals("2",
> results.get(0).getAttribute(ListDatabaseTables.DB_TABLE_COUNT));
> runner.clearTransferState();
> Thread.sleep(500);
> // Add another table immediately, the first table should not be
> listed again but the second should
> stmt.execute("create table TEST_TABLE2 (id integer not null, val1
> integer, val2 integer, constraint my_pk2 primary key (id))");
> stmt.close();{code}
> With that Thread.sleep(500) added in, it always fails on my laptop. This
> essentially is mimicking a slower environment, such as travis-ci.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5202) TestListDatabaseTables timing issue
[
https://issues.apache.org/jira/browse/NIFI-5202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1647#comment-1647
]
ASF GitHub Bot commented on NIFI-5202:
--
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2709
NIFI-5202: Fixed timing issue in TestListDatabaseTables
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-5202
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2709.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2709
> TestListDatabaseTables timing issue
> ---
>
> Key: NIFI-5202
> URL: https://issues.apache.org/jira/browse/NIFI-5202
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: Mark Payne
>Assignee: Matt Burgess
>Priority: Major
>
> I sometimes see TestListDatabaseTables fail in Travis-CI:
> {code:java}
> [INFO] Results:
> [INFO]
> [ERROR] Failures:
> [ERROR] TestListDatabaseTables.testListTablesMultipleRefresh:218
> expected:<1> but was:<2>
> [INFO] {code}
> It appears to be a timing issue. When I run it on my laptop, it always
> succeeds, as-is. However, I can easily reproduce the error above if I update
> the unit test by adding a Thread.sleep at line 214:
> {code:java}
> assertEquals("2",
> results.get(0).getAttribute(ListDatabaseTables.DB_TABLE_COUNT));
> runner.clearTransferState();
> Thread.sleep(500);
> // Add another table immediately, the first table should not be
> listed again but the second should
> stmt.execute("create table TEST_TABLE2 (id integer not null, val1
> integer, val2 integer, constraint my_pk2 primary key (id))");
> stmt.close();{code}
> With that Thread.sleep(500) added in, it always fails on my laptop. This
> essentially is mimicking a slower environment, such as travis-ci.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5202) TestListDatabaseTables timing issue
[
https://issues.apache.org/jira/browse/NIFI-5202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477746#comment-16477746
]
Matt Burgess commented on NIFI-5202:
Yeah if the two runs take more than 200 ms then it will refresh on its own,
I'll add something to the test that determines the elapsed time and expect 1 or
2 accordingly?
> TestListDatabaseTables timing issue
> ---
>
> Key: NIFI-5202
> URL: https://issues.apache.org/jira/browse/NIFI-5202
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: Mark Payne
>Priority: Major
>
> I sometimes see TestListDatabaseTables fail in Travis-CI:
> {code:java}
> [INFO] Results:
> [INFO]
> [ERROR] Failures:
> [ERROR] TestListDatabaseTables.testListTablesMultipleRefresh:218
> expected:<1> but was:<2>
> [INFO] {code}
> It appears to be a timing issue. When I run it on my laptop, it always
> succeeds, as-is. However, I can easily reproduce the error above if I update
> the unit test by adding a Thread.sleep at line 214:
> {code:java}
> assertEquals("2",
> results.get(0).getAttribute(ListDatabaseTables.DB_TABLE_COUNT));
> runner.clearTransferState();
> Thread.sleep(500);
> // Add another table immediately, the first table should not be
> listed again but the second should
> stmt.execute("create table TEST_TABLE2 (id integer not null, val1
> integer, val2 integer, constraint my_pk2 primary key (id))");
> stmt.close();{code}
> With that Thread.sleep(500) added in, it always fails on my laptop. This
> essentially is mimicking a slower environment, such as travis-ci.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
