[jira] [Commented] (NIFI-5446) Specify the file encoding option to UTF-8 in pom.xml
[
https://issues.apache.org/jira/browse/NIFI-5446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656072#comment-16656072
]
ASF GitHub Bot commented on NIFI-5446:
--
Github user tasanuma commented on the issue:
https://github.com/apache/nifi/pull/2910
Thanks for reviewing and merging it, @ijokarumawak!
> Specify the file encoding option to UTF-8 in pom.xml
>
>
> Key: NIFI-5446
> URL: https://issues.apache.org/jira/browse/NIFI-5446
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Takanobu Asanuma
>Assignee: Takanobu Asanuma
>Priority: Major
>
> {{TestJacksonCSVRecordReader.testUTF8}} failed in my environment (CentOS 7).
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.nifi.csv.TestJacksonCSVRecordReader
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.272
> s <<< FAILURE! - in org.apache.nifi.csv.TestJacksonCSVRecordReader
> [ERROR] testUTF8(org.apache.nifi.csv.TestJacksonCSVRecordReader) Time
> elapsed: 1.007 s <<< FAILURE!
> org.junit.ComparisonFailure: expected:<[???]> but was:<[???]>
> at
> org.apache.nifi.csv.TestJacksonCSVRecordReader.testUTF8(TestJacksonCSVRecordReader.java:81)
> {noformat}
> After a bit of research, the problem seems to be same as
> [here|https://stackoverflow.com/questions/17656475/maven-source-encoding-in-utf-8-not-working].
> I specified the file-encoding option of UTF-8 in the command line arguments
> and the unit test succeeded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5446) Specify the file encoding option to UTF-8 in pom.xml
[
https://issues.apache.org/jira/browse/NIFI-5446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655221#comment-16655221
]
ASF GitHub Bot commented on NIFI-5446:
--
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2910
> Specify the file encoding option to UTF-8 in pom.xml
>
>
> Key: NIFI-5446
> URL: https://issues.apache.org/jira/browse/NIFI-5446
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Takanobu Asanuma
>Assignee: Takanobu Asanuma
>Priority: Major
>
> {{TestJacksonCSVRecordReader.testUTF8}} failed in my environment (CentOS 7).
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.nifi.csv.TestJacksonCSVRecordReader
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.272
> s <<< FAILURE! - in org.apache.nifi.csv.TestJacksonCSVRecordReader
> [ERROR] testUTF8(org.apache.nifi.csv.TestJacksonCSVRecordReader) Time
> elapsed: 1.007 s <<< FAILURE!
> org.junit.ComparisonFailure: expected:<[???]> but was:<[???]>
> at
> org.apache.nifi.csv.TestJacksonCSVRecordReader.testUTF8(TestJacksonCSVRecordReader.java:81)
> {noformat}
> After a bit of research, the problem seems to be same as
> [here|https://stackoverflow.com/questions/17656475/maven-source-encoding-in-utf-8-not-working].
> I specified the file-encoding option of UTF-8 in the command line arguments
> and the unit test succeeded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5446) Specify the file encoding option to UTF-8 in pom.xml
[
https://issues.apache.org/jira/browse/NIFI-5446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654686#comment-16654686
]
ASF GitHub Bot commented on NIFI-5446:
--
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2910
Thanks @tasanuma , LGTM +1, merging!
> Specify the file encoding option to UTF-8 in pom.xml
>
>
> Key: NIFI-5446
> URL: https://issues.apache.org/jira/browse/NIFI-5446
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Takanobu Asanuma
>Assignee: Takanobu Asanuma
>Priority: Major
>
> {{TestJacksonCSVRecordReader.testUTF8}} failed in my environment (CentOS 7).
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.nifi.csv.TestJacksonCSVRecordReader
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.272
> s <<< FAILURE! - in org.apache.nifi.csv.TestJacksonCSVRecordReader
> [ERROR] testUTF8(org.apache.nifi.csv.TestJacksonCSVRecordReader) Time
> elapsed: 1.007 s <<< FAILURE!
> org.junit.ComparisonFailure: expected:<[???]> but was:<[???]>
> at
> org.apache.nifi.csv.TestJacksonCSVRecordReader.testUTF8(TestJacksonCSVRecordReader.java:81)
> {noformat}
> After a bit of research, the problem seems to be same as
> [here|https://stackoverflow.com/questions/17656475/maven-source-encoding-in-utf-8-not-working].
> I specified the file-encoding option of UTF-8 in the command line arguments
> and the unit test succeeded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5446) Specify the file encoding option to UTF-8 in pom.xml
[
https://issues.apache.org/jira/browse/NIFI-5446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654685#comment-16654685
]
ASF subversion and git services commented on NIFI-5446:
---
Commit ec8afd18d6ae39dc1b09698fabfd1d3e7eaa70cf in nifi's branch
refs/heads/master from [~tasanuma0829]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=ec8afd1 ]
NIFI-5446: Specify the file encoding option to UTF-8 in pom.xml
This closes #2910.
Signed-off-by: Koji Kawamura
> Specify the file encoding option to UTF-8 in pom.xml
>
>
> Key: NIFI-5446
> URL: https://issues.apache.org/jira/browse/NIFI-5446
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Takanobu Asanuma
>Assignee: Takanobu Asanuma
>Priority: Major
>
> {{TestJacksonCSVRecordReader.testUTF8}} failed in my environment (CentOS 7).
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.nifi.csv.TestJacksonCSVRecordReader
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.272
> s <<< FAILURE! - in org.apache.nifi.csv.TestJacksonCSVRecordReader
> [ERROR] testUTF8(org.apache.nifi.csv.TestJacksonCSVRecordReader) Time
> elapsed: 1.007 s <<< FAILURE!
> org.junit.ComparisonFailure: expected:<[???]> but was:<[???]>
> at
> org.apache.nifi.csv.TestJacksonCSVRecordReader.testUTF8(TestJacksonCSVRecordReader.java:81)
> {noformat}
> After a bit of research, the problem seems to be same as
> [here|https://stackoverflow.com/questions/17656475/maven-source-encoding-in-utf-8-not-working].
> I specified the file-encoding option of UTF-8 in the command line arguments
> and the unit test succeeded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5446) Specify the file encoding option to UTF-8 in pom.xml
[
https://issues.apache.org/jira/browse/NIFI-5446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653193#comment-16653193
]
ASF GitHub Bot commented on NIFI-5446:
--
Github user tasanuma commented on the issue:
https://github.com/apache/nifi/pull/2910
Could somebody please review it?
> Specify the file encoding option to UTF-8 in pom.xml
>
>
> Key: NIFI-5446
> URL: https://issues.apache.org/jira/browse/NIFI-5446
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Takanobu Asanuma
>Assignee: Takanobu Asanuma
>Priority: Major
>
> {{TestJacksonCSVRecordReader.testUTF8}} failed in my environment (CentOS 7).
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.nifi.csv.TestJacksonCSVRecordReader
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.272
> s <<< FAILURE! - in org.apache.nifi.csv.TestJacksonCSVRecordReader
> [ERROR] testUTF8(org.apache.nifi.csv.TestJacksonCSVRecordReader) Time
> elapsed: 1.007 s <<< FAILURE!
> org.junit.ComparisonFailure: expected:<[???]> but was:<[???]>
> at
> org.apache.nifi.csv.TestJacksonCSVRecordReader.testUTF8(TestJacksonCSVRecordReader.java:81)
> {noformat}
> After a bit of research, the problem seems to be same as
> [here|https://stackoverflow.com/questions/17656475/maven-source-encoding-in-utf-8-not-working].
> I specified the file-encoding option of UTF-8 in the command line arguments
> and the unit test succeeded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5446) Specify the file encoding option to UTF-8 in pom.xml
[
https://issues.apache.org/jira/browse/NIFI-5446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552381#comment-16552381
]
ASF GitHub Bot commented on NIFI-5446:
--
GitHub user tasanuma opened a pull request:
https://github.com/apache/nifi/pull/2910
NIFI-5446: Specify the file encoding option to UTF-8 in pom.xml
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tasanuma/nifi NIFI-5446
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2910.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2910
commit b4071afa0b3385b6ee10bde27d48e25aa2e2232e
Author: Takanobu Asanuma
Date: 2018-07-23T04:53:51Z
Specify the file encoding option to UTF-8 in pom.xml
> Specify the file encoding option to UTF-8 in pom.xml
>
>
> Key: NIFI-5446
> URL: https://issues.apache.org/jira/browse/NIFI-5446
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Takanobu Asanuma
>Assignee: Takanobu Asanuma
>Priority: Major
>
> {{TestJacksonCSVRecordReader.testUTF8}} failed in my environment (CentOS 7).
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.nifi.csv.TestJacksonCSVRecordReader
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.272
> s <<< FAILURE! - in org.apache.nifi.csv.TestJacksonCSVRecordReader
> [ERROR] testUTF8(org.apache.nifi.csv.TestJacksonCSVRecordReader) Time
> elapsed: 1.007 s <<< FAILURE!
> org.junit.ComparisonFailure: expected:<[???]> but was:<[???]>
> at
> org.apache.nifi.csv.TestJacksonCSVRecordReader.testUTF8(TestJacksonCSVRecordReader.java:81)
> {noformat}
> After a bit of research, the problem seems to be same as
> [here|https://stackoverflow.com/questions/17656475/maven-source-encoding-in-utf-8-not-working].
> I specified the file-encoding option of UTF-8 in the command line arguments
> and the unit test succeeded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
