[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[ https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634320#comment-16634320 ] ASF GitHub Bot commented on NIFI-5489: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2936 There are definitely inconsistencies throughout the project as this wasn't always a firm policy and there are many different contributors to the project. As you noted, we have tried to tighten the reviews and catch this where we can, and hopefully with the completion of [NIFI-5627](https://issues.apache.org/jira/browse/NIFI-5627), we will have a foundation to move forward on enabling EL in passwords for users. > Support Attribute Expressions with AMQP Processors > -- > > Key: NIFI-5489 > URL: https://issues.apache.org/jira/browse/NIFI-5489 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Daniel >Priority: Major > Fix For: 1.8.0 > > > Particularly the fields: host, virtualhost and username. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[ https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634316#comment-16634316 ] ASF GitHub Bot commented on NIFI-5489: -- Github user lukepfarrar commented on the issue: https://github.com/apache/nifi/pull/2936 I wondered if that was the case but it did not seem consistent with the DB pooling, which does/did allow EL in the password, althought I notice that the scope has been tightened in recent versions. Thanks :) > Support Attribute Expressions with AMQP Processors > -- > > Key: NIFI-5489 > URL: https://issues.apache.org/jira/browse/NIFI-5489 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Daniel >Priority: Major > Fix For: 1.8.0 > > > Particularly the fields: host, virtualhost and username. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[
https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634295#comment-16634295
]
ASF GitHub Bot commented on NIFI-5489:
--
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2936
Hi @lukepfarrar , we have a policy of not evaluating EL in password fields.
Here is [an example of that review
process](https://github.com/apache/nifi/pull/3020#discussion_r219712821) and
the reasoning behind it on another PR.
> Our policy so far has been that passwords do not support expression
language, for a couple reasons:
> 1. How to evaluate if a password `abc${def}` should be interpreted as
`abc` + *the value of(`def`)* or the literal string `abc${def}`
> 1. The variable registry is not designed to store sensitive values
securely, so if a password is stored here, it can be accessed by an
unauthorized user
> Support Attribute Expressions with AMQP Processors
> --
>
> Key: NIFI-5489
> URL: https://issues.apache.org/jira/browse/NIFI-5489
> Project: Apache NiFi
> Issue Type: Improvement
>Affects Versions: 1.7.1
>Reporter: Daniel
>Priority: Major
> Fix For: 1.8.0
>
>
> Particularly the fields: host, virtualhost and username.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[ https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634274#comment-16634274 ] ASF GitHub Bot commented on NIFI-5489: -- Github user lukepfarrar commented on the issue: https://github.com/apache/nifi/pull/2936 Is there a reason why USER supports el but PASSWORD does not? > Support Attribute Expressions with AMQP Processors > -- > > Key: NIFI-5489 > URL: https://issues.apache.org/jira/browse/NIFI-5489 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Daniel >Priority: Major > Fix For: 1.8.0 > > > Particularly the fields: host, virtualhost and username. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[ https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575169#comment-16575169 ] ASF GitHub Bot commented on NIFI-5489: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2936 > Support Attribute Expressions with AMQP Processors > -- > > Key: NIFI-5489 > URL: https://issues.apache.org/jira/browse/NIFI-5489 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Daniel >Priority: Major > > Particularly the fields: host, virtualhost and username. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[ https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575167#comment-16575167 ] ASF subversion and git services commented on NIFI-5489: --- Commit 3731cc855849c6bc971909f561be56138f13d182 in nifi's branch refs/heads/master from [~djimenez88] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=3731cc8 ] NIFI-5489: Add expression language support to AMQP processors HOST, VHOST and USER Fields. This closes #2936 Signed-off-by: zenfenan > Support Attribute Expressions with AMQP Processors > -- > > Key: NIFI-5489 > URL: https://issues.apache.org/jira/browse/NIFI-5489 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Daniel >Priority: Major > > Particularly the fields: host, virtualhost and username. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[ https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573542#comment-16573542 ] ASF GitHub Bot commented on NIFI-5489: -- Github user danieljimenez commented on the issue: https://github.com/apache/nifi/pull/2936 FWIW I am currently using a SNAPSHOT from 01782bf on a real RabbitMQ server. > Support Attribute Expressions with AMQP Processors > -- > > Key: NIFI-5489 > URL: https://issues.apache.org/jira/browse/NIFI-5489 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Daniel >Priority: Major > > Particularly the fields: host, virtualhost and username. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[ https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573537#comment-16573537 ] ASF GitHub Bot commented on NIFI-5489: -- Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/2936 +1 from me, though I didn't test this against a real RabbitMQ server. @zenfenan did you want to take another look? > Support Attribute Expressions with AMQP Processors > -- > > Key: NIFI-5489 > URL: https://issues.apache.org/jira/browse/NIFI-5489 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Daniel >Priority: Major > > Particularly the fields: host, virtualhost and username. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[ https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573505#comment-16573505 ] ASF GitHub Bot commented on NIFI-5489: -- Github user danieljimenez commented on the issue: https://github.com/apache/nifi/pull/2936 @mosermw Port added sir. :) > Support Attribute Expressions with AMQP Processors > -- > > Key: NIFI-5489 > URL: https://issues.apache.org/jira/browse/NIFI-5489 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Daniel >Priority: Major > > Particularly the fields: host, virtualhost and username. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[ https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572106#comment-16572106 ] ASF GitHub Bot commented on NIFI-5489: -- Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/2936 Please do add Port to your PR, if you can, then I think this will also cover NIFI-4723. It looks like PORT_VALIDATOR already supports expression language, so you are good there. > Support Attribute Expressions with AMQP Processors > -- > > Key: NIFI-5489 > URL: https://issues.apache.org/jira/browse/NIFI-5489 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Daniel >Priority: Major > > Particularly the fields: host, virtualhost and username. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[ https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572103#comment-16572103 ] ASF GitHub Bot commented on NIFI-5489: -- Github user danieljimenez commented on the issue: https://github.com/apache/nifi/pull/2936 @mosermw I can, I just enabled the fields most likely to be variables for most use cases. If you'd like me to add that to this PR, I certainly can. > Support Attribute Expressions with AMQP Processors > -- > > Key: NIFI-5489 > URL: https://issues.apache.org/jira/browse/NIFI-5489 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Daniel >Priority: Major > > Particularly the fields: host, virtualhost and username. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[ https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572090#comment-16572090 ] Michael Moser commented on NIFI-5489: - See also NIFI-4723 and NIFI-5118 > Support Attribute Expressions with AMQP Processors > -- > > Key: NIFI-5489 > URL: https://issues.apache.org/jira/browse/NIFI-5489 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Daniel >Priority: Major > > Particularly the fields: host, virtualhost and username. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[ https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572086#comment-16572086 ] ASF GitHub Bot commented on NIFI-5489: -- Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/2936 If you are using VARIABLE_REGISTRY to dynamically evaluate the Host, shouldn't you also allow it for Port? > Support Attribute Expressions with AMQP Processors > -- > > Key: NIFI-5489 > URL: https://issues.apache.org/jira/browse/NIFI-5489 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Daniel >Priority: Major > > Particularly the fields: host, virtualhost and username. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[ https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572028#comment-16572028 ] ASF GitHub Bot commented on NIFI-5489: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2936 @danieljimenez correct, PRs merged now will be included in the next release. Because our *bug fix* releases (`x.x.1`) do not include feature work, this will be in the next *minor* release, which is `1.8.0`. > Support Attribute Expressions with AMQP Processors > -- > > Key: NIFI-5489 > URL: https://issues.apache.org/jira/browse/NIFI-5489 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Daniel >Priority: Major > > Particularly the fields: host, virtualhost and username. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[ https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571929#comment-16571929 ] ASF GitHub Bot commented on NIFI-5489: -- Github user danieljimenez commented on the issue: https://github.com/apache/nifi/pull/2936 Missed a spot evaluating the attribute expressions. Fixed. > Support Attribute Expressions with AMQP Processors > -- > > Key: NIFI-5489 > URL: https://issues.apache.org/jira/browse/NIFI-5489 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Daniel >Priority: Major > > Particularly the fields: host, virtualhost and username. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[ https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571747#comment-16571747 ] ASF GitHub Bot commented on NIFI-5489: -- Github user danieljimenez commented on the issue: https://github.com/apache/nifi/pull/2936 Awesome, thanks! That would mean it's targeted for 1.8.0, correct? > Support Attribute Expressions with AMQP Processors > -- > > Key: NIFI-5489 > URL: https://issues.apache.org/jira/browse/NIFI-5489 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Daniel >Priority: Major > > Particularly the fields: host, virtualhost and username. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[ https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570313#comment-16570313 ] ASF GitHub Bot commented on NIFI-5489: -- Github user danieljimenez commented on the issue: https://github.com/apache/nifi/pull/2936 After rerunning the Travis failures are gone. > Support Attribute Expressions with AMQP Processors > -- > > Key: NIFI-5489 > URL: https://issues.apache.org/jira/browse/NIFI-5489 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Daniel >Priority: Major > > Particularly the fields: host, virtualhost and username. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[ https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569407#comment-16569407 ] ASF GitHub Bot commented on NIFI-5489: -- Github user danieljimenez commented on the issue: https://github.com/apache/nifi/pull/2936 No idea what the travis failures are, they are definitely not related to this change. > Support Attribute Expressions with AMQP Processors > -- > > Key: NIFI-5489 > URL: https://issues.apache.org/jira/browse/NIFI-5489 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Daniel >Priority: Major > > Particularly the fields: host, virtualhost and username. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5489) Support Attribute Expressions with AMQP Processors
[ https://issues.apache.org/jira/browse/NIFI-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569222#comment-16569222 ] ASF GitHub Bot commented on NIFI-5489: -- GitHub user danieljimenez opened a pull request: https://github.com/apache/nifi/pull/2936 NIFI-5489: Add expression language support to AMQP processors HOST, V… …HOST and USER Fields. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [x] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/danieljimenez/nifi NIFI-5489-amqp-attribute-expression-support Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2936.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2936 commit 1a9c9d5cd8759125ec344a9ad389b282fb40267d Author: Daniel Jimenez Date: 2018-08-04T16:11:28Z NIFI-5489: Add expression language support to AMQP processors HOST, VHOST and USER Fields. > Support Attribute Expressions with AMQP Processors > -- > > Key: NIFI-5489 > URL: https://issues.apache.org/jira/browse/NIFI-5489 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Daniel >Priority: Major > > Particularly the fields: host, virtualhost and username. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
