[jira] [Commented] (NIFI-5677) Add/clarify why modifying/creating variables are not considered local changes in versioned flows
[ https://issues.apache.org/jira/browse/NIFI-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676216#comment-16676216 ] ASF GitHub Bot commented on NIFI-5677: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3125 > Add/clarify why modifying/creating variables are not considered local changes > in versioned flows > > > Key: NIFI-5677 > URL: https://issues.apache.org/jira/browse/NIFI-5677 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Reporter: Andrew Lim >Assignee: Andrew Lim >Priority: Minor > > There has been some confusion over why creating or modifying variables in a > versioned flow do not trigger local changes in the flow. > Will improve the relevant section in the User Guide > (https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#managing_local_changes) > with the following clarifications: > Modifying doesn’t trigger local changes because variable values are intended > to be different in each environment. When a flow is imported to an > environment, it is assumed there is a one-time operation required to set > those variables specific for the given environment. > Creating a variable doesn’t trigger a local change because just creating a > variable on its own has not changed anything about what the flow processes. > A component will have to be created/modified that uses the new variable, > which will trigger a local change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5677) Add/clarify why modifying/creating variables are not considered local changes in versioned flows
[ https://issues.apache.org/jira/browse/NIFI-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676214#comment-16676214 ] ASF subversion and git services commented on NIFI-5677: --- Commit d0688d0785dd7dee0e761975f993bdaf8e374139 in nifi's branch refs/heads/master from [~andrewmlim] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=d0688d0 ] NIFI-5677 Added note to clarify why modifying/creating variables not local changes in versioned flows Update user-guide.adoc This closes #3125. Signed-off-by: Koji Kawamura > Add/clarify why modifying/creating variables are not considered local changes > in versioned flows > > > Key: NIFI-5677 > URL: https://issues.apache.org/jira/browse/NIFI-5677 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Reporter: Andrew Lim >Assignee: Andrew Lim >Priority: Minor > > There has been some confusion over why creating or modifying variables in a > versioned flow do not trigger local changes in the flow. > Will improve the relevant section in the User Guide > (https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#managing_local_changes) > with the following clarifications: > Modifying doesn’t trigger local changes because variable values are intended > to be different in each environment. When a flow is imported to an > environment, it is assumed there is a one-time operation required to set > those variables specific for the given environment. > Creating a variable doesn’t trigger a local change because just creating a > variable on its own has not changed anything about what the flow processes. > A component will have to be created/modified that uses the new variable, > which will trigger a local change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5677) Add/clarify why modifying/creating variables are not considered local changes in versioned flows
[ https://issues.apache.org/jira/browse/NIFI-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676213#comment-16676213 ] ASF GitHub Bot commented on NIFI-5677: -- Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/3125 LGTM, +1. Merging. Thanks @andrewmlim! > Add/clarify why modifying/creating variables are not considered local changes > in versioned flows > > > Key: NIFI-5677 > URL: https://issues.apache.org/jira/browse/NIFI-5677 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Reporter: Andrew Lim >Assignee: Andrew Lim >Priority: Minor > > There has been some confusion over why creating or modifying variables in a > versioned flow do not trigger local changes in the flow. > Will improve the relevant section in the User Guide > (https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#managing_local_changes) > with the following clarifications: > Modifying doesn’t trigger local changes because variable values are intended > to be different in each environment. When a flow is imported to an > environment, it is assumed there is a one-time operation required to set > those variables specific for the given environment. > Creating a variable doesn’t trigger a local change because just creating a > variable on its own has not changed anything about what the flow processes. > A component will have to be created/modified that uses the new variable, > which will trigger a local change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5677) Add/clarify why modifying/creating variables are not considered local changes in versioned flows
[ https://issues.apache.org/jira/browse/NIFI-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675420#comment-16675420 ] ASF GitHub Bot commented on NIFI-5677: -- Github user andrewmlim commented on a diff in the pull request: https://github.com/apache/nifi/pull/3125#discussion_r230824217 --- Diff: nifi-docs/src/main/asciidoc/user-guide.adoc --- @@ -1928,7 +1928,9 @@ The following actions are not considered local changes: * modifying sensitive property values * modifying remote process group URLs * updating a processor that was referencing a non-existent controller service to reference an externally available controller service -* modifying variables +* creating or modifying variables --- End diff -- Added "deleting variables" scenario. PR read for review/merge if no other issues raised. Thanks @ijokarumawak ! > Add/clarify why modifying/creating variables are not considered local changes > in versioned flows > > > Key: NIFI-5677 > URL: https://issues.apache.org/jira/browse/NIFI-5677 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Reporter: Andrew Lim >Assignee: Andrew Lim >Priority: Minor > > There has been some confusion over why creating or modifying variables in a > versioned flow do not trigger local changes in the flow. > Will improve the relevant section in the User Guide > (https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#managing_local_changes) > with the following clarifications: > Modifying doesn’t trigger local changes because variable values are intended > to be different in each environment. When a flow is imported to an > environment, it is assumed there is a one-time operation required to set > those variables specific for the given environment. > Creating a variable doesn’t trigger a local change because just creating a > variable on its own has not changed anything about what the flow processes. > A component will have to be created/modified that uses the new variable, > which will trigger a local change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5677) Add/clarify why modifying/creating variables are not considered local changes in versioned flows
[ https://issues.apache.org/jira/browse/NIFI-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675412#comment-16675412 ] ASF GitHub Bot commented on NIFI-5677: -- Github user andrewmlim commented on a diff in the pull request: https://github.com/apache/nifi/pull/3125#discussion_r230820448 --- Diff: nifi-docs/src/main/asciidoc/user-guide.adoc --- @@ -1928,7 +1928,9 @@ The following actions are not considered local changes: * modifying sensitive property values * modifying remote process group URLs * updating a processor that was referencing a non-existent controller service to reference an externally available controller service -* modifying variables +* creating or modifying variables --- End diff -- That's a good point. Will add that scenario. > Add/clarify why modifying/creating variables are not considered local changes > in versioned flows > > > Key: NIFI-5677 > URL: https://issues.apache.org/jira/browse/NIFI-5677 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Reporter: Andrew Lim >Assignee: Andrew Lim >Priority: Minor > > There has been some confusion over why creating or modifying variables in a > versioned flow do not trigger local changes in the flow. > Will improve the relevant section in the User Guide > (https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#managing_local_changes) > with the following clarifications: > Modifying doesn’t trigger local changes because variable values are intended > to be different in each environment. When a flow is imported to an > environment, it is assumed there is a one-time operation required to set > those variables specific for the given environment. > Creating a variable doesn’t trigger a local change because just creating a > variable on its own has not changed anything about what the flow processes. > A component will have to be created/modified that uses the new variable, > which will trigger a local change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5677) Add/clarify why modifying/creating variables are not considered local changes in versioned flows
[ https://issues.apache.org/jira/browse/NIFI-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674617#comment-16674617 ] ASF GitHub Bot commented on NIFI-5677: -- Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/3125#discussion_r230623728 --- Diff: nifi-docs/src/main/asciidoc/user-guide.adoc --- @@ -1928,7 +1928,9 @@ The following actions are not considered local changes: * modifying sensitive property values * modifying remote process group URLs * updating a processor that was referencing a non-existent controller service to reference an externally available controller service -* modifying variables +* creating or modifying variables --- End diff -- A bit nit-picky, but how about deleting variables? > Add/clarify why modifying/creating variables are not considered local changes > in versioned flows > > > Key: NIFI-5677 > URL: https://issues.apache.org/jira/browse/NIFI-5677 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Reporter: Andrew Lim >Assignee: Andrew Lim >Priority: Minor > > There has been some confusion over why creating or modifying variables in a > versioned flow do not trigger local changes in the flow. > Will improve the relevant section in the User Guide > (https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#managing_local_changes) > with the following clarifications: > Modifying doesn’t trigger local changes because variable values are intended > to be different in each environment. When a flow is imported to an > environment, it is assumed there is a one-time operation required to set > those variables specific for the given environment. > Creating a variable doesn’t trigger a local change because just creating a > variable on its own has not changed anything about what the flow processes. > A component will have to be created/modified that uses the new variable, > which will trigger a local change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5677) Add/clarify why modifying/creating variables are not considered local changes in versioned flows
[ https://issues.apache.org/jira/browse/NIFI-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673438#comment-16673438 ] ASF GitHub Bot commented on NIFI-5677: -- GitHub user andrewmlim opened a pull request: https://github.com/apache/nifi/pull/3125 NIFI-5677 Added note to clarify why modifying/creating variables not … …local changes in versioned flows You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrewmlim/nifi NIFI-5677 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/3125.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3125 > Add/clarify why modifying/creating variables are not considered local changes > in versioned flows > > > Key: NIFI-5677 > URL: https://issues.apache.org/jira/browse/NIFI-5677 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Reporter: Andrew Lim >Assignee: Andrew Lim >Priority: Minor > > There has been some confusion over why creating or modifying variables in a > versioned flow do not trigger local changes in the flow. > Will improve the relevant section in the User Guide > (https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#managing_local_changes) > with the following clarifications: > Modifying doesn’t trigger local changes because variable values are intended > to be different in each environment. When a flow is imported to an > environment, it is assumed there is a one-time operation required to set > those variables specific for the given environment. > Creating a variable doesn’t trigger a local change because just creating a > variable on its own has not changed anything about what the flow processes. > A component will have to be created/modified that uses the new variable, > which will trigger a local change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
