[jira] [Commented] (NIFI-5891) NiFi record serde throws NPE when decimal field has null value
[
https://issues.apache.org/jira/browse/NIFI-5891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720295#comment-16720295
]
ASF subversion and git services commented on NIFI-5891:
---
Commit c51512f5e33cbd413b1fda8700408aa95614680e in nifi's branch
refs/heads/master from gkkorir
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=c51512f ]
NIFI-5891 fix handling of null logical types in Hive3Streaming processor
NIFI-5891: Fixed Checkstyle issues
Signed-off-by: Matthew Burgess
This closes #3216
> NiFi record serde throws NPE when decimal field has null value
> --
>
> Key: NIFI-5891
> URL: https://issues.apache.org/jira/browse/NIFI-5891
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Environment: RHEL 7.5
> Open JDK 1.8
>Reporter: Gideon Korir
>Priority: Major
>
> When an incoming record has a null decimal field, NiFiRecordSerDe (
> org.apache.hive.streaming) throws an NPE when trying to create a HiveDecimal.
> This causes the PutHive3Streaming processor to skip the record and log a
> warning.
>
> The lines:
> {code:java}
> val = HiveDecimal.create(record.getAsDouble(fieldName));
> {code}
> should be changed to something along the lines of:
> {code:java}
> Double d = record.getAsDouble(fieldName);
> val = d == null ? null : HiveRecord.create(d);{code}
> The bug is insidious and occurs during Auto-unboxing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5891) NiFi record serde throws NPE when decimal field has null value
[
https://issues.apache.org/jira/browse/NIFI-5891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720296#comment-16720296
]
ASF GitHub Bot commented on NIFI-5891:
--
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/3216
> NiFi record serde throws NPE when decimal field has null value
> --
>
> Key: NIFI-5891
> URL: https://issues.apache.org/jira/browse/NIFI-5891
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Environment: RHEL 7.5
> Open JDK 1.8
>Reporter: Gideon Korir
>Priority: Major
> Fix For: 1.9.0
>
>
> When an incoming record has a null decimal field, NiFiRecordSerDe (
> org.apache.hive.streaming) throws an NPE when trying to create a HiveDecimal.
> This causes the PutHive3Streaming processor to skip the record and log a
> warning.
>
> The lines:
> {code:java}
> val = HiveDecimal.create(record.getAsDouble(fieldName));
> {code}
> should be changed to something along the lines of:
> {code:java}
> Double d = record.getAsDouble(fieldName);
> val = d == null ? null : HiveRecord.create(d);{code}
> The bug is insidious and occurs during Auto-unboxing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5891) NiFi record serde throws NPE when decimal field has null value
[
https://issues.apache.org/jira/browse/NIFI-5891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720294#comment-16720294
]
ASF subversion and git services commented on NIFI-5891:
---
Commit c51512f5e33cbd413b1fda8700408aa95614680e in nifi's branch
refs/heads/master from gkkorir
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=c51512f ]
NIFI-5891 fix handling of null logical types in Hive3Streaming processor
NIFI-5891: Fixed Checkstyle issues
Signed-off-by: Matthew Burgess
This closes #3216
> NiFi record serde throws NPE when decimal field has null value
> --
>
> Key: NIFI-5891
> URL: https://issues.apache.org/jira/browse/NIFI-5891
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Environment: RHEL 7.5
> Open JDK 1.8
>Reporter: Gideon Korir
>Priority: Major
>
> When an incoming record has a null decimal field, NiFiRecordSerDe (
> org.apache.hive.streaming) throws an NPE when trying to create a HiveDecimal.
> This causes the PutHive3Streaming processor to skip the record and log a
> warning.
>
> The lines:
> {code:java}
> val = HiveDecimal.create(record.getAsDouble(fieldName));
> {code}
> should be changed to something along the lines of:
> {code:java}
> Double d = record.getAsDouble(fieldName);
> val = d == null ? null : HiveRecord.create(d);{code}
> The bug is insidious and occurs during Auto-unboxing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5891) NiFi record serde throws NPE when decimal field has null value
[
https://issues.apache.org/jira/browse/NIFI-5891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720292#comment-16720292
]
ASF GitHub Bot commented on NIFI-5891:
--
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/3216
+1 LGTM, verified the unit tests illustrate the problem and the patch fixes
it. There are 2 CheckStyle violations but I will fix them on merge. Thanks for
the fix! Merging to master
> NiFi record serde throws NPE when decimal field has null value
> --
>
> Key: NIFI-5891
> URL: https://issues.apache.org/jira/browse/NIFI-5891
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Environment: RHEL 7.5
> Open JDK 1.8
>Reporter: Gideon Korir
>Priority: Major
>
> When an incoming record has a null decimal field, NiFiRecordSerDe (
> org.apache.hive.streaming) throws an NPE when trying to create a HiveDecimal.
> This causes the PutHive3Streaming processor to skip the record and log a
> warning.
>
> The lines:
> {code:java}
> val = HiveDecimal.create(record.getAsDouble(fieldName));
> {code}
> should be changed to something along the lines of:
> {code:java}
> Double d = record.getAsDouble(fieldName);
> val = d == null ? null : HiveRecord.create(d);{code}
> The bug is insidious and occurs during Auto-unboxing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5891) NiFi record serde throws NPE when decimal field has null value
[
https://issues.apache.org/jira/browse/NIFI-5891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720227#comment-16720227
]
Gideon Korir commented on NIFI-5891:
This issue seems to affect all logical avro types: decimal, date, timestamp,
arrays
> NiFi record serde throws NPE when decimal field has null value
> --
>
> Key: NIFI-5891
> URL: https://issues.apache.org/jira/browse/NIFI-5891
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.8.0
> Environment: RHEL 7.5
> Open JDK 1.8
>Reporter: Gideon Korir
>Priority: Major
>
> When an incoming record has a null decimal field, NiFiRecordSerDe (
> org.apache.hive.streaming) throws an NPE when trying to create a HiveDecimal.
> This causes the PutHive3Streaming processor to skip the record and log a
> warning.
>
> The lines:
> {code:java}
> val = HiveDecimal.create(record.getAsDouble(fieldName));
> {code}
> should be changed to something along the lines of:
> {code:java}
> Double d = record.getAsDouble(fieldName);
> val = d == null ? null : HiveRecord.create(d);{code}
> The bug is insidious and occurs during Auto-unboxing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5891) NiFi record serde throws NPE when decimal field has null value
[
https://issues.apache.org/jira/browse/NIFI-5891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720220#comment-16720220
]
ASF GitHub Bot commented on NIFI-5891:
--
GitHub user gideonkorir opened a pull request:
https://github.com/apache/nifi/pull/3216
NIFI-5891 fix handling of null logical types in Hive3Streaming processor
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gideonkorir/nifi NIFI-5891
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3216.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3216
commit 61a5e9507ac2def912b1a954ce0708a83a49c2db
Author: gkkorir
Date: 2018-12-13T14:25:37Z
NIFI-5891 fix handling of null logical types in Hive3Streaming processor
> NiFi record serde throws NPE when decimal field has null value
> --
>
> Key: NIFI-5891
> URL: https://issues.apache.org/jira/browse/NIFI-5891
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.8.0
> Environment: RHEL 7.5
> Open JDK 1.8
>Reporter: Gideon Korir
>Priority: Major
>
> When an incoming record has a null decimal field, NiFiRecordSerDe (
> org.apache.hive.streaming) throws an NPE when trying to create a HiveDecimal.
> This causes the PutHive3Streaming processor to skip the record and log a
> warning.
>
> The lines:
> {code:java}
> val = HiveDecimal.create(record.getAsDouble(fieldName));
> {code}
> should be changed to something along the lines of:
> {code:java}
> Double d = record.getAsDouble(fieldName);
> val = d == null ? null : HiveRecord.create(d);{code}
> The bug is insidious and occurs during Auto-unboxing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
