[jira] [Commented] (NIFIREG-126) Entering an invalid bucket id in a deep link causes JS error
[ https://issues.apache.org/jira/browse/NIFIREG-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358847#comment-16358847 ] ASF GitHub Bot commented on NIFIREG-126: Github user asfgit closed the pull request at: https://github.com/apache/nifi-registry/pull/99 > Entering an invalid bucket id in a deep link causes JS error > > > Key: NIFIREG-126 > URL: https://issues.apache.org/jira/browse/NIFIREG-126 > Project: NiFi Registry > Issue Type: Bug >Affects Versions: 0.1.0 >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > > As a user when I enter an invalid deep link I want to be routed to view all > the items in all the buckets that I am authorized to view and to be notified > that the requested bucket/item id is invalid. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-126) Entering an invalid bucket id in a deep link causes JS error
[ https://issues.apache.org/jira/browse/NIFIREG-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358584#comment-16358584 ] ASF GitHub Bot commented on NIFIREG-126: Github user scottyaslan commented on the issue: https://github.com/apache/nifi-registry/pull/99 @kevdoran I have updated this PR with the new message as well as logging info. > Entering an invalid bucket id in a deep link causes JS error > > > Key: NIFIREG-126 > URL: https://issues.apache.org/jira/browse/NIFIREG-126 > Project: NiFi Registry > Issue Type: Bug >Affects Versions: 0.1.0 >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > > As a user when I enter an invalid deep link I want to be routed to view all > the items in all the buckets that I am authorized to view and to be notified > that the requested bucket/item id is invalid. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-126) Entering an invalid bucket id in a deep link causes JS error
[ https://issues.apache.org/jira/browse/NIFIREG-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358585#comment-16358585 ] ASF GitHub Bot commented on NIFIREG-126: Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/99 Thanks! Will review > Entering an invalid bucket id in a deep link causes JS error > > > Key: NIFIREG-126 > URL: https://issues.apache.org/jira/browse/NIFIREG-126 > Project: NiFi Registry > Issue Type: Bug >Affects Versions: 0.1.0 >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > > As a user when I enter an invalid deep link I want to be routed to view all > the items in all the buckets that I am authorized to view and to be notified > that the requested bucket/item id is invalid. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-126) Entering an invalid bucket id in a deep link causes JS error
[
https://issues.apache.org/jira/browse/NIFIREG-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358502#comment-16358502
]
ASF GitHub Bot commented on NIFIREG-126:
Github user moranr commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/99#discussion_r167249634
--- Diff:
nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/AccessPolicyResource.java
---
@@ -174,7 +174,7 @@ public Response getAccessPolicy(
final AccessPolicy accessPolicy =
authorizationService.getAccessPolicy(identifier);
if (accessPolicy == null) {
-throw new ResourceNotFoundException("No access policy found
with ID + " + identifier);
+throw new ResourceNotFoundException("The specified access
policy does not exist for this bucket.");
--- End diff --
I think that works, we could even add _"...in this registry."_ to end of
that. It's consistent with the other messages.
> Entering an invalid bucket id in a deep link causes JS error
>
>
> Key: NIFIREG-126
> URL: https://issues.apache.org/jira/browse/NIFIREG-126
> Project: NiFi Registry
> Issue Type: Bug
>Affects Versions: 0.1.0
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>
> As a user when I enter an invalid deep link I want to be routed to view all
> the items in all the buckets that I am authorized to view and to be notified
> that the requested bucket/item id is invalid.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFIREG-126) Entering an invalid bucket id in a deep link causes JS error
[
https://issues.apache.org/jira/browse/NIFIREG-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358490#comment-16358490
]
ASF GitHub Bot commented on NIFIREG-126:
Github user scottyaslan commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/99#discussion_r167246736
--- Diff:
nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/AccessPolicyResource.java
---
@@ -174,7 +174,7 @@ public Response getAccessPolicy(
final AccessPolicy accessPolicy =
authorizationService.getAccessPolicy(identifier);
if (accessPolicy == null) {
-throw new ResourceNotFoundException("No access policy found
with ID + " + identifier);
+throw new ResourceNotFoundException("The specified access
policy does not exist for this bucket.");
--- End diff --
Good catchI think we can simply change it to say "The specified policy
does not exist."?
> Entering an invalid bucket id in a deep link causes JS error
>
>
> Key: NIFIREG-126
> URL: https://issues.apache.org/jira/browse/NIFIREG-126
> Project: NiFi Registry
> Issue Type: Bug
>Affects Versions: 0.1.0
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>
> As a user when I enter an invalid deep link I want to be routed to view all
> the items in all the buckets that I am authorized to view and to be notified
> that the requested bucket/item id is invalid.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFIREG-126) Entering an invalid bucket id in a deep link causes JS error
[
https://issues.apache.org/jira/browse/NIFIREG-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357618#comment-16357618
]
ASF GitHub Bot commented on NIFIREG-126:
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/99#discussion_r167076913
--- Diff:
nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/AccessPolicyResource.java
---
@@ -174,7 +174,7 @@ public Response getAccessPolicy(
final AccessPolicy accessPolicy =
authorizationService.getAccessPolicy(identifier);
if (accessPolicy == null) {
-throw new ResourceNotFoundException("No access policy found
with ID + " + identifier);
+throw new ResourceNotFoundException("The specified access
policy does not exist for this bucket.");
--- End diff --
I'm on board with the spirit of this change: removing cryptic UUIDs from
the UX error messages, while still providing enough context to be
useful/meaningful to the user. In general these changes look fine.
In this particular case, however, I think the wording of this message
assumes too much regarding "... does not exist _for this bucket_". Access
policies on the backend are generic to all types of resources, not just
buckets. So for instance, one could be attempting to add a user to the access
policy for the Proxy Resource, or the Tenants (users and groups) Resource. In
such a case, it would be confusing to receive an error message referencing
buckets.
I think we need use a more generic error message that is suitable for all
cases (REST API or UI).
> Entering an invalid bucket id in a deep link causes JS error
>
>
> Key: NIFIREG-126
> URL: https://issues.apache.org/jira/browse/NIFIREG-126
> Project: NiFi Registry
> Issue Type: Bug
>Affects Versions: 0.1.0
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>
> As a user when I enter an invalid deep link I want to be routed to view all
> the items in all the buckets that I am authorized to view and to be notified
> that the requested bucket/item id is invalid.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFIREG-126) Entering an invalid bucket id in a deep link causes JS error
[ https://issues.apache.org/jira/browse/NIFIREG-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357377#comment-16357377 ] ASF GitHub Bot commented on NIFIREG-126: Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/99 Thanks @moranr and @scottyaslan! Will do a final pass on this > Entering an invalid bucket id in a deep link causes JS error > > > Key: NIFIREG-126 > URL: https://issues.apache.org/jira/browse/NIFIREG-126 > Project: NiFi Registry > Issue Type: Bug >Affects Versions: 0.1.0 >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > > As a user when I enter an invalid deep link I want to be routed to view all > the items in all the buckets that I am authorized to view and to be notified > that the requested bucket/item id is invalid. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-126) Entering an invalid bucket id in a deep link causes JS error
[ https://issues.apache.org/jira/browse/NIFIREG-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356020#comment-16356020 ] ASF GitHub Bot commented on NIFIREG-126: Github user scottyaslan commented on the issue: https://github.com/apache/nifi-registry/pull/99 @kevdoran I have updated this PR with @moranr suggested messaging. > Entering an invalid bucket id in a deep link causes JS error > > > Key: NIFIREG-126 > URL: https://issues.apache.org/jira/browse/NIFIREG-126 > Project: NiFi Registry > Issue Type: Bug >Affects Versions: 0.1.0 >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > > As a user when I enter an invalid deep link I want to be routed to view all > the items in all the buckets that I am authorized to view and to be notified > that the requested bucket/item id is invalid. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-126) Entering an invalid bucket id in a deep link causes JS error
[ https://issues.apache.org/jira/browse/NIFIREG-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355577#comment-16355577 ] ASF GitHub Bot commented on NIFIREG-126: Github user moranr commented on the issue: https://github.com/apache/nifi-registry/pull/99 @scottyaslan , @kevdoran – redirect behavior looks good. Below are recommendations for the dialog titles and messages. UNSECURED _-nifi-registry/explorer/grid-list/buckets/0_ _-nifi-registry/explorer/grid-list/buckets/0/flows/0_ - Title – Bucket Not Found - Msg – The specified bucket ID does not exist in this registry. _-nifi-registry/explorer/grid-list/buckets/**existing-bucket-id**/flows/0_ - Title – Flow Not Found - Msg – The specified flow ID does not exist in this bucket. _-nifi-registry/administration/users_ - Title – Not Applicable - Msg – User administration is not configured for this registry. SECURED _-nifi-registry/administration/workflow(sidenav:manage/bucket/)_ - Title – Bucket Not Found - Msg – The specified bucket ID does not exist in this registry. _-nifi-registry/administration/users(sidenav:manage/user/)_ - Title – User Not Found - Msg – The specified user ID does not exist in this registry. _-nifi-registry/administration/users(sidenav:manage/group/)_ - Title – User Group Not Found - Msg – The specified user group ID does not exist in this registry. _-nifi-registry/administration/*_ (If user does not have applicable admin privileges) - Title – Access Denied - Msg – Please contact your System Administrator. > Entering an invalid bucket id in a deep link causes JS error > > > Key: NIFIREG-126 > URL: https://issues.apache.org/jira/browse/NIFIREG-126 > Project: NiFi Registry > Issue Type: Bug >Affects Versions: 0.1.0 >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > > As a user when I enter an invalid deep link I want to be routed to view all > the items in all the buckets that I am authorized to view and to be notified > that the requested bucket/item id is invalid. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-126) Entering an invalid bucket id in a deep link causes JS error
[ https://issues.apache.org/jira/browse/NIFIREG-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350729#comment-16350729 ] ASF GitHub Bot commented on NIFIREG-126: Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/99 Reviewing... > Entering an invalid bucket id in a deep link causes JS error > > > Key: NIFIREG-126 > URL: https://issues.apache.org/jira/browse/NIFIREG-126 > Project: NiFi Registry > Issue Type: Bug >Affects Versions: 0.1.0 >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > > As a user when I enter an invalid deep link I want to be routed to view all > the items in all the buckets that I am authorized to view and to be notified > that the requested bucket/item id is invalid. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-126) Entering an invalid bucket id in a deep link causes JS error
[ https://issues.apache.org/jira/browse/NIFIREG-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350344#comment-16350344 ] ASF GitHub Bot commented on NIFIREG-126: GitHub user scottyaslan opened a pull request: https://github.com/apache/nifi-registry/pull/99 [NIFIREG-126] adding some polish and testing around deep links To test this PR: You can merge this pull request into a Git repository by running: $ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-126 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-registry/pull/99.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #99 commit bbf9d96abc96023bcc2cf0deeb8c31a1c435e850 Author: Scott Aslan Date: 2018-02-01T21:38:28Z [NIFIREG-126] adding some polish and testing around deep links > Entering an invalid bucket id in a deep link causes JS error > > > Key: NIFIREG-126 > URL: https://issues.apache.org/jira/browse/NIFIREG-126 > Project: NiFi Registry > Issue Type: Bug >Affects Versions: 0.1.0 >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > > As a user when I enter an invalid deep link I want to be routed to view all > the items in all the buckets that I am authorized to view and to be notified > that the requested bucket/item id is invalid. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
