[jira] [Updated] (NIFI-12010) Handle auto-commit and commit based on driver capabilities in SQL components

2023-08-29 Thread Matt Burgess (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-12010:

Description: 
Some JDBC drivers throw an exception when calling setAutoCommit(false), even if 
the auto-commit setting for the driver is already false. Although unfortunate, 
I'm not sure it is a violation of the JDBC API. The SQL components in NiFi that 
use the JDBC API should catch SQLFeatureNotSupportedException and perhaps log a 
debug message but otherwise proceed.

Same goes for connection.commit() and connection.rollback(), these should not 
be explicitly called if auto-commit is true for the connection. 

  was:
Some JDBC drivers throw an exception when calling setAutoCommit(false), even if 
the auto-commit setting for the driver is already false. Although unfortunate, 
I'm not sure it is a violation of the JDBC API. PutDatabaseRecord should catch 
SQLFeatureNotSupportedException and perhaps log a debug message but otherwise 
proceed.

Same goes for connection.commit() and connection.rollback(), these should not 
be explicitly called if auto-commit is true for the connection. 


> Handle auto-commit and commit based on driver capabilities in SQL components
> 
>
> Key: NIFI-12010
> URL: https://issues.apache.org/jira/browse/NIFI-12010
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
> Fix For: 1.latest, 2.latest
>
>
> Some JDBC drivers throw an exception when calling setAutoCommit(false), even 
> if the auto-commit setting for the driver is already false. Although 
> unfortunate, I'm not sure it is a violation of the JDBC API. The SQL 
> components in NiFi that use the JDBC API should catch 
> SQLFeatureNotSupportedException and perhaps log a debug message but otherwise 
> proceed.
> Same goes for connection.commit() and connection.rollback(), these should not 
> be explicitly called if auto-commit is true for the connection. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-12010) Handle auto-commit and commit based on driver capabilities in SQL components

2023-08-29 Thread Matt Burgess (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-12010:

Fix Version/s: 1.latest
   2.latest
   (was: 2.0.0)
   (was: 1.24.0)

> Handle auto-commit and commit based on driver capabilities in SQL components
> 
>
> Key: NIFI-12010
> URL: https://issues.apache.org/jira/browse/NIFI-12010
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
> Fix For: 1.latest, 2.latest
>
>
> Some JDBC drivers throw an exception when calling setAutoCommit(false), even 
> if the auto-commit setting for the driver is already false. Although 
> unfortunate, I'm not sure it is a violation of the JDBC API. 
> PutDatabaseRecord should catch SQLFeatureNotSupportedException and perhaps 
> log a debug message but otherwise proceed.
> Same goes for connection.commit() and connection.rollback(), these should not 
> be explicitly called if auto-commit is true for the connection. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)