Re: [PR] NIFI-14149 Fix invalid MiNiFi flow json by setting the default value of maxTimerDrivenThreadCount and update minifi-toolkit command set with examples [nifi]

[via GitHub]

briansolo1985 closed pull request #9628: NIFI-14149 Fix invalid MiNiFi flow 
json by setting the default value of maxTimerDrivenThreadCount and update 
minifi-toolkit command set with examples
URL: https://github.com/apache/nifi/pull/9628


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] NIFI-14149 Fix invalid MiNiFi flow json by setting the default value of maxTimerDrivenThreadCount and update minifi-toolkit command set with examples [nifi]

[via GitHub]

briansolo1985 commented on PR #9628:
URL: https://github.com/apache/nifi/pull/9628#issuecomment-2586366801

   Thank you for incorporating the change. Looks good, +1 from my side
   Will proceed with merging the PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] NIFI-14149 Fix invalid MiNiFi flow json by setting the default value of maxTimerDrivenThreadCount and update minifi-toolkit command set with examples [nifi]

[via GitHub]

pkedvessy commented on PR #9628:
URL: https://github.com/apache/nifi/pull/9628#issuecomment-2585901080

   @briansolo1985 Thanks for your review and feedback. I addressed your 
suggestion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] NIFI-14149 Fix invalid MiNiFi flow json by setting the default value of maxTimerDrivenThreadCount and update minifi-toolkit command set with examples [nifi]

[via GitHub]

briansolo1985 commented on code in PR #9628:
URL: https://github.com/apache/nifi/pull/9628#discussion_r1912428218


##
minifi/minifi-toolkit/minifi-toolkit-assembly/README.md:
##
@@ -48,7 +48,8 @@ After downloading the binary and extracting it, to run the 
MiNiFi Toolkit Conver
   java org.apache.nifi.minifi.toolkit.configuration.ConfigMain  
options
 
   Valid commands include:
-  transform-yml: Transforms legacy MiNiFi flow config YAML into MiNiFi 
flow config JSON
+ - transform-nifi: Transform NiFi2 flow JSON format into MiNifi flow JSON 
format

Review Comment:
   Many thanks for updating the documentation!



##
minifi/minifi-toolkit/minifi-toolkit-configuration/src/main/java/org/apache/nifi/minifi/toolkit/configuration/json/TransformNifiCommandFactory.java:
##
@@ -63,8 +65,11 @@ private int transformNifiToJson(String[] args) {
 RegisteredFlowSnapshot registeredFlowSnapshot = 
readNifiFlow(sourceNiFiJsonPath);
 VersionedDataflow versionedDataflow = new VersionedDataflow();
 
versionedDataflow.setRootGroup(registeredFlowSnapshot.getFlowContents());
-versionedDataflow
-.setParameterContexts(new 
ArrayList<>(registeredFlowSnapshot.getParameterContexts().values()));
+versionedDataflow.setParameterContexts(new 
ArrayList<>(registeredFlowSnapshot.getParameterContexts().values()));
+
+ConfigSchema configSchema = new 
ConfigSchema(Collections.emptyMap());
+
versionedDataflow.setMaxTimerDrivenThreadCount(configSchema.getCoreProperties().getMaxConcurrentThreads().intValue());

Review Comment:
   This will always result in the DEFAULT_MAX_CONCURRENT_THREADS, what about 
just simply reference it without instantiating ConfigSchema?
   ```
   
versionedDataflow.setMaxTimerDrivenThreadCount(CorePropertiesSchema.DEFAULT_MAX_CONCURRENT_THREADS);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] NIFI-14149 Fix invalid MiNiFi flow json by setting the default value of maxTimerDrivenThreadCount and update minifi-toolkit command set with examples [nifi]

[via GitHub]

pkedvessy closed pull request #9627: NIFI-14149 Fix invalid MiNiFi flow json by 
setting the default value of maxTimerDrivenThreadCount and update 
minifi-toolkit command set with examples
URL: https://github.com/apache/nifi/pull/9627


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org