Re: [PR] NIFI-6532 Added documentation to TransformXML to explain the usage of dynamic properties in stylesheets. [nifi]
exceptionfactory merged PR #10999: URL: https://github.com/apache/nifi/pull/10999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] NIFI-6532 Added documentation to TransformXML to explain the usage of dynamic properties in stylesheets. [nifi]
dan-s1 commented on PR #10999: URL: https://github.com/apache/nifi/pull/10999#issuecomment-4057439006 Okay I have reduced this PR to only the addition of the `additionalDetails.md` file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] NIFI-6532 Added documentation to TransformXML to explain the usage of dynamic properties in stylesheets. [nifi]
exceptionfactory commented on PR #10999: URL: https://github.com/apache/nifi/pull/10999#issuecomment-4057187545 > Should I perhaps separate the unit tests also and include those as well as the fix for `CapturingLogger` and keep this PR for the documentation only? Yes, that would work. Since the Jira issue, and PR title, focus on documentation, decoupling the testing would be helpful for tracking purposes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] NIFI-6532 Added documentation to TransformXML to explain the usage of dynamic properties in stylesheets. [nifi]
dan-s1 commented on PR #10999: URL: https://github.com/apache/nifi/pull/10999#issuecomment-4057095713 I understand that, but the fix won't be as apparent since there are no unit tests for `CapturingLogger`. It is in this ticket, a concrete instance where the issue crops up as I could not check for `ValidationException` without the stack trace. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] NIFI-6532 Added documentation to TransformXML to explain the usage of dynamic properties in stylesheets. [nifi]
exceptionfactory commented on PR #10999: URL: https://github.com/apache/nifi/pull/10999#issuecomment-4055494468 > @exceptionfactory Its not exactly clear to me what the errors are on the Windows box. The last thing I saw was about a directory not existing which did not relate to my additions. Thanks, sounds like it could have been an intermittent issue then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] NIFI-6532 Added documentation to TransformXML to explain the usage of dynamic properties in stylesheets. [nifi]
dan-s1 commented on PR #10999: URL: https://github.com/apache/nifi/pull/10999#issuecomment-4052402645 @exceptionfactory Its not exactly clear to me what the errors are on the Windows box. The last thing I saw was about a directory not existing which did not relate to my additions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
