[Issue 96720] FilePicker: setDefaultName, setDefaultDirectory broken

[bugzilla]

https://bz.apache.org/ooo/show_bug.cgi?id=96720

Matthias Seidel  changed:

   What|Removed |Added

 CC||msei...@apache.org

--- Comment #16 from Matthias Seidel  ---
(In reply to damjan from comment #13)
> Committed r1716508 fixing point 4:
> 
> Display the proposed filename even when the URL
> specified for the file picker directory is invalid.
> 
> As the Win32 file picker sadly allows both paths and URLs
> for directories, users try paths on other more
> restrictive platforms, and since the file picker there
> shows neither the directory nor the file, they wrongly
> conclude both are broken.

Cherry-picked for AOO41X with:
https://github.com/apache/openoffice/commit/de4f303f92c636ab115e46e3d5e1477fba3d4960

I understand this is only a partly fix.

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.

[Issue 96720] FilePicker: setDefaultName, setDefaultDirectory broken

[bugzilla]

https://bz.apache.org/ooo/show_bug.cgi?id=96720

oooforum (fr)  changed:

   What|Removed |Added

 CC||ardamose...@gmail.com

--- Comment #15 from oooforum (fr)  ---
*** Issue 123544 has been marked as a duplicate of this issue. ***

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.

[Issue 96720] FilePicker: setDefaultName, setDefaultDirectory broken

[bugzilla]

https://bz.apache.org/ooo/show_bug.cgi?id=96720

oooforum (fr)  changed:

   What|Removed |Added

 CC||ooofo...@free.fr

--- Comment #14 from oooforum (fr)  ---
Thanks Damjan for the fix.
This issue is targeted for 4.2.0
I don't know if this commit can be backported for 4.1.4?

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.

[Issue 96720] FilePicker: setDefaultName, setDefaultDirectory broken

[bugzilla]

https://bz.apache.org/ooo/show_bug.cgi?id=96720

dam...@apache.org changed:

   What|Removed |Added

 Status|ACCEPTED|CONFIRMED
 CC||dam...@apache.org
 Latest|--- |4.2.0-dev
Confirmation in||

--- Comment #11 from dam...@apache.org ---
There is many issues here.

1. "Under Ubuntu ONLY setDefaultName() does not work with FILEOPEN_SIMPLE".

Yes, this is **by design**. GTK can't support
gtk_file_chooser_default_set_current_name() for opening files, it gives the
following assertion:

(soffice:81466): Gtk-CRITICAL **: gtk_file_chooser_default_set_current_name:
assertion 'impl->action == GTK_FILE_CHOOSER_ACTION_SAVE || impl->action ==
GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER' failed

which is why AOO doesn't even try to call
gtk_file_chooser_default_set_current_name() when the OPEN dialog is shown (see
SalGtkFilePicker::setDefaultName). The suggested filename can only be used when
saving. Blame GTK.

2. The code from the OP is just plain wrong: the current directory needs to be
given as a URL. The documentation for XFilePicker requires a URL for
setDisplayDirectory(). "/home" is not a URL. It should be "file:///home"

3. com.sun.star.ui.dialogs.Win32FilePicker allows paths instead of URLs (both
C:/ and file:///C:/ work, file:/C:/ doesn't), but other platforms are
stricter!!!

4. For com.sun.star.ui.dialogs.FilePicker, when the directory isn't a URL, the
default filename isn't shown either. I feel that when the directory is wrong it
shouldn't affect the file; not only is there no good reason for it to, but it
can also confuse users as to what is wrong, like the OP here who believed both
the file and directory are broken.

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.

[Issue 96720] FilePicker: setDefaultName, setDefaultDirectory broken

[bugzilla]

https://bz.apache.org/ooo/show_bug.cgi?id=96720

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #12 from Regina Henschel  ---
@damjan: One error is a wrong property in VistaFilePicker.cxx, see my fix in
http://cgit.freedesktop.org/libreoffice/core/commit/?id=8775593bcc543b3d7021e20736f42fa13035870d

When you (or someone else) work on the problem, please fix that too. I'm
currently to busy to fix it myself.

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.

[Issue 96720] FilePicker: setDefaultName, setDefaultDirectory broken

[bugzilla]

https://bz.apache.org/ooo/show_bug.cgi?id=96720

dam...@apache.org changed:

   What|Removed |Added

   Target Milestone|--- |4.2.0

--- Comment #13 from dam...@apache.org ---
Committed r1716508 fixing point 4:

Display the proposed filename even when the URL
specified for the file picker directory is invalid.

As the Win32 file picker sadly allows both paths and URLs
for directories, users try paths on other more
restrictive platforms, and since the file picker there
shows neither the directory nor the file, they wrongly
conclude both are broken.

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.