[GitHub] [openwhisk] sven-lange-last commented on issue #4633: Optimize WhiskEntity deserialization

2019-09-19 Thread GitBox
sven-lange-last commented on issue #4633: Optimize WhiskEntity deserialization URL: https://github.com/apache/openwhisk/issues/4633#issuecomment-532997277 This approach would improve scenarios where pre-existing actions are loaded from the artifact store and fail in deserialisation because

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4584: OpenWhisk User Events

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4584: OpenWhisk User Events URL: https://github.com/apache/openwhisk/pull/4584#discussion_r326065254 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala ## @@ -195,34 +198,59 @@

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4584: OpenWhisk User Events

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4584: OpenWhisk User Events URL: https://github.com/apache/openwhisk/pull/4584#discussion_r326069009 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/ActivationResult.scala ## @@ -61,16 +61,25 @@

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4584: OpenWhisk User Events

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4584: OpenWhisk User Events URL: https://github.com/apache/openwhisk/pull/4584#discussion_r326071229 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/ActivationResult.scala ## @@ -61,16 +61,25 @@

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4584: OpenWhisk User Events

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4584: OpenWhisk User Events URL: https://github.com/apache/openwhisk/pull/4584#discussion_r326072530 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/WhiskActivation.scala ## @@ -145,6 +145,10 @@

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4584: OpenWhisk User Events

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4584: OpenWhisk User Events URL: https://github.com/apache/openwhisk/pull/4584#discussion_r326067606 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala ## @@ -256,6 +286,7 @@ case

[GitHub] [openwhisk] chetanmeh opened a new issue #4633: Optimize WhiskEntity deserialization

2019-09-19 Thread GitBox
chetanmeh opened a new issue #4633: Optimize WhiskEntity deserialization URL: https://github.com/apache/openwhisk/issues/4633 Currently the deserialization logic for `WhiskEntity` uses a trail based approahc where it tries multiple deserializers

[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
sven-lange-last commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326048416 ## File path:

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326054019 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r325989534 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r325993909 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r325988736 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r325996077 ## File path:

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r325988193 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r325991407 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r325990234 ## File path:

[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
sven-lange-last commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326063425 ## File path:

[GitHub] [openwhisk] selfxp opened a new issue #4634: Extends user-events configuration

2019-09-19 Thread GitBox
selfxp opened a new issue #4634: Extends user-events configuration URL: https://github.com/apache/openwhisk/issues/4634 * The Prometheus recorder can't be disabled in the current `user-events` implementation. Someone might want to use the KamonRecorder with some reporters other than

[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
sven-lange-last commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326038270 ## File path:

[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
sven-lange-last commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326038270 ## File path:

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4584: OpenWhisk User Events

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4584: OpenWhisk User Events URL: https://github.com/apache/openwhisk/pull/4584#discussion_r326119692 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/WhiskActivation.scala ## @@ -82,8 +82,8 @@ case

[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
sven-lange-last commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326203622 ## File path:

[GitHub] [openwhisk] rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326203452 ## File path:

[GitHub] [openwhisk] rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326201849 ## File path:

[GitHub] [openwhisk] rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326154802 ## File path:

[GitHub] [openwhisk] rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326154490 ## File path:

[GitHub] [openwhisk] rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326156558 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala

[GitHub] [openwhisk] rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326158858 ## File path:

[GitHub] [openwhisk] rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326152274 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326193031 ## File path: core/standalone/src/main/scala/org/apache/openwhisk/standalone/KafkaLauncher.scala

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326198147 ## File path:

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4584: OpenWhisk User Events

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4584: OpenWhisk User Events URL: https://github.com/apache/openwhisk/pull/4584#discussion_r326119356 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala ## @@ -195,34 +198,59 @@

[GitHub] [openwhisk] rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326150664 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala

[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
sven-lange-last commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326150432 ## File path:

[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
sven-lange-last commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326150517 ## File path:

[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
sven-lange-last commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326150351 ## File path:

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326186606 ## File path:

[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
sven-lange-last commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326155928 ## File path:

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326184627 ## File path: core/standalone/src/main/scala/org/apache/openwhisk/standalone/KafkaLauncher.scala

[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
sven-lange-last commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326189887 ## File path:

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326205999 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala

[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
sven-lange-last commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326209107 ## File path:

[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
sven-lange-last commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326149173 ## File path:

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326202534 ## File path:

[GitHub] [openwhisk] chetanmeh opened a new issue #4635: Combine active ack and slot release for setups not collecting logs directly

2019-09-19 Thread GitBox
chetanmeh opened a new issue #4635: Combine active ack and slot release for setups not collecting logs directly URL: https://github.com/apache/openwhisk/issues/4635 This is extension of #4624 as discussed in [comments][1]. We can optimize the Kafka flow for setups which do not collect

[GitHub] [openwhisk] rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326204785 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala

[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
sven-lange-last commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326191971 ## File path:

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326198456 ## File path:

[GitHub] [openwhisk] codecov-io edited a comment on issue #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
codecov-io edited a comment on issue #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#issuecomment-531316564 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4624?src=pr=h1) Report > Merging

[GitHub] [openwhisk] codecov-io edited a comment on issue #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
codecov-io edited a comment on issue #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#issuecomment-53154 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4628?src=pr=h1) Report > Merging

[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
sven-lange-last commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326236622 ## File path:

[GitHub] [openwhisk] chetanmeh commented on issue #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
chetanmeh commented on issue #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#issuecomment-533189190 Thanks Sven for the review! This is an automated message from

[GitHub] [openwhisk] codecov-io edited a comment on issue #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
codecov-io edited a comment on issue #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#issuecomment-53154 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4628?src=pr=h1) Report > Merging

[GitHub] [openwhisk] rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326256172 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala

[GitHub] [openwhisk] chetanmeh merged pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
chetanmeh merged pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [openwhisk] rabbah opened a new issue #4636: Refactor active ack method signature to be an interface

2019-09-19 Thread GitBox
rabbah opened a new issue #4636: Refactor active ack method signature to be an interface URL: https://github.com/apache/openwhisk/issues/4636 In core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala: > */ - type ActiveAck = (TransactionId,

[GitHub] [openwhisk] rabbah merged pull request #4617: Add kind "unknown" to fallback activations

2019-09-19 Thread GitBox
rabbah merged pull request #4617: Add kind "unknown" to fallback activations URL: https://github.com/apache/openwhisk/pull/4617 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [openwhisk] rabbah commented on a change in pull request #4617: Add kind "unknown" to fallback activations

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4617: Add kind "unknown" to fallback activations URL: https://github.com/apache/openwhisk/pull/4617#discussion_r326259380 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/Exec.scala ## @@ -242,6

[GitHub] [openwhisk] codecov-io edited a comment on issue #4627: Add descriptions how to update, remove or rename runtime kinds and language families

2019-09-19 Thread GitBox
codecov-io edited a comment on issue #4627: Add descriptions how to update, remove or rename runtime kinds and language families URL: https://github.com/apache/openwhisk/pull/4627#issuecomment-532154575 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4627?src=pr=h1) Report >

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4503: Add optional config for appending custom registry to user provided images

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4503: Add optional config for appending custom registry to user provided images URL: https://github.com/apache/openwhisk/pull/4503#discussion_r326467823 ## File path: ansible/group_vars/all ## @@ -55,7 +55,8 @@ whisk: #

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326465642 ## File path: core/standalone/README.md ## @@ -204,7 +219,35 @@ Api Gateway mode can be

[GitHub] [openwhisk] codecov-io commented on issue #4632: Activation Persister Service

2019-09-19 Thread GitBox
codecov-io commented on issue #4632: Activation Persister Service URL: https://github.com/apache/openwhisk/pull/4632#issuecomment-533411344 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4632?src=pr=h1) Report > Merging

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
chetanmeh commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326466033 ## File path:

[GitHub] [openwhisk] codecov-io edited a comment on issue #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
codecov-io edited a comment on issue #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#issuecomment-531316564 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4624?src=pr=h1) Report > Merging

[GitHub] [openwhisk] codecov-io edited a comment on issue #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
codecov-io edited a comment on issue #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#issuecomment-531316564 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4624?src=pr=h1) Report > Merging

[GitHub] [openwhisk] codecov-io edited a comment on issue #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
codecov-io edited a comment on issue #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#issuecomment-531316564 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4624?src=pr=h1) Report > Merging

[GitHub] [openwhisk] rabbah commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326433077 ## File path: core/standalone/README.md ## @@ -204,7 +219,35 @@ Api Gateway mode can be enabled

[GitHub] [openwhisk] rabbah commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4628: Embedded Kafka support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326433208 ## File path: core/standalone/README.md ## @@ -204,7 +219,35 @@ Api Gateway mode can be enabled

[GitHub] [openwhisk] rabbah commented on issue #4609: Add namespace field to activation log

2019-09-19 Thread GitBox
rabbah commented on issue #4609: Add namespace field to activation log URL: https://github.com/apache/openwhisk/pull/4609#issuecomment-533362102 Take a look at `makeSequenceActivation` in `SequenceActions`. This is an

[GitHub] [openwhisk] rabbah commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families URL: https://github.com/apache/openwhisk/pull/4627#discussion_r326432413 ## File path: docs/actions-update.md ## @@ -0,0 +1,75 @@ + +##

[GitHub] [openwhisk] rabbah commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families URL: https://github.com/apache/openwhisk/pull/4627#discussion_r326431572 ## File path: docs/actions-update.md ## @@ -0,0 +1,75 @@ + +##

[GitHub] [openwhisk] rabbah commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families URL: https://github.com/apache/openwhisk/pull/4627#discussion_r326432228 ## File path: docs/actions-update.md ## @@ -0,0 +1,75 @@ + +##

[GitHub] [openwhisk] rabbah commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families URL: https://github.com/apache/openwhisk/pull/4627#discussion_r326431818 ## File path: docs/actions-update.md ## @@ -0,0 +1,75 @@ + +##

[GitHub] [openwhisk] rabbah commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families URL: https://github.com/apache/openwhisk/pull/4627#discussion_r326431621 ## File path: docs/actions-update.md ## @@ -0,0 +1,75 @@ + +##

[GitHub] [openwhisk] rabbah commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families URL: https://github.com/apache/openwhisk/pull/4627#discussion_r326432316 ## File path: docs/actions-update.md ## @@ -0,0 +1,75 @@ + +##

[GitHub] [openwhisk] rabbah commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families URL: https://github.com/apache/openwhisk/pull/4627#discussion_r326432044 ## File path: docs/actions-update.md ## @@ -0,0 +1,75 @@ + +##

[GitHub] [openwhisk] rabbah commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families URL: https://github.com/apache/openwhisk/pull/4627#discussion_r326431689 ## File path: docs/actions-update.md ## @@ -0,0 +1,75 @@ + +##

[GitHub] [openwhisk] rabbah opened a new issue #4637: inefficiencies and issues with the actions CRUD API

2019-09-19 Thread GitBox
rabbah opened a new issue #4637: inefficiencies and issues with the actions CRUD API URL: https://github.com/apache/openwhisk/issues/4637 Actions are represented by the type `WhiskAction`, which includes a property of type `Exec`. The `Exec` instances may include the code inline. The REST

[GitHub] [openwhisk] rabbah commented on issue #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
rabbah commented on issue #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#issuecomment-533322879 @chetanmeh I refactored the active acker's signature/type. @sven-lange-last we can't remove `WhiskActivation` - the

[GitHub] [openwhisk] rabbah commented on issue #4624: Combines active ack and slot release when both are available.

2019-09-19 Thread GitBox
rabbah commented on issue #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#issuecomment-533322961 I removed WIP label as I think all comments are addressed at this point.

[GitHub] [openwhisk] rabbah commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families

2019-09-19 Thread GitBox
rabbah commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families URL: https://github.com/apache/openwhisk/pull/4627#discussion_r326432711 ## File path: docs/actions-update.md ## @@ -0,0 +1,75 @@ + +##