[GitHub] [openwhisk] dgrove-oss commented on issue #4685: Revert "Remove unused test helpers"

2019-10-11 Thread GitBox 
dgrove-oss commented on issue #4685: Revert "Remove unused test helpers"
URL: https://github.com/apache/openwhisk/pull/4685#issuecomment-541206048
 
 
   For the record, the scope is bigger than my previous comment indicates.  
getCredentials is used as an alias in more downstream repos.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] dgrove-oss commented on issue #4685: Revert "Remove unused test helpers"

2019-10-11 Thread GitBox 
dgrove-oss commented on issue #4685: Revert "Remove unused test helpers"
URL: https://github.com/apache/openwhisk/pull/4685#issuecomment-541153384
 
 
   fwiw, I have pretty much all the repos cloned locally.  Here's what I see 
with some recursive finds.  Fairly limited downstream usage.
   
   
   daves-mbp:openwhisk dgrove$ qfind getVCAPServices
   ./openwhisk/tests/src/test/scala/common/WhiskProperties.java
   
./openwhisk-devtools/docker-compose/openwhisk-src/tests/src/test/scala/common/TestUtils.java
   
./openwhisk-devtools/docker-compose/openwhisk-src/tests/src/test/scala/common/WhiskProperties.java
   daves-mbp:openwhisk dgrove$ qfind getVCAPcredentials
   ./openwhisk-package-cloudant/tests/src/test/scala/system/CloudantUtil.java
   ./openwhisk-catalog/tests/src/test/scala/packages/weather/WeatherTests.scala
   
./ibm-functions-runtime-nodejs/tests/src/test/scala/runtime/integration/CredentialsIBMNodeJsDb2CloudTests.scala
   
./ibm-functions-runtime-nodejs/tests/src/test/scala/runtime/integration/CredentialsIBMNodeJsActionCloudantTests.scala
   
./ibm-functions-runtime-nodejs/tests/src/test/scala/runtime/integration/CredentialsIBMNodeJsActionWatsonTests.scala
   
./openwhisk-devtools/docker-compose/openwhisk-src/tests/src/test/scala/common/TestUtils.java
   
./ibm-functions-runtime-python/tests/build/tmp/scala/compilerAnalysis/compileTestScala.analysis
   
./ibm-functions-runtime-python/tests/src/test/scala/integration/CredentialsIBMPythonDb2CloudTests.scala
   
./ibm-functions-runtime-python/tests/src/test/scala/integration/CredentialsIBMPythonWatsonTests.scala
   
./ibm-functions-runtime-python/tests/src/test/scala/integration/CredentialsIBMPythonCloudantTests.scala
   
./ibm-functions-runtime-swift/tests/build/tmp/scala/compilerAnalysis/compileTestScala.analysis
   
./ibm-functions-runtime-swift/tests/src/test/scala/runtime/integration/CredentialsIBMSwiftActionWatsonTests.scala
   ```
   
   It might be faster to fix downstream, especially with the pip/travis 
breakage blocking merges in the main repo


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services