[GitHub] mrutkows commented on issue #366: Support more runtime types from bluemix host info.

2017-08-29 Thread git
mrutkows commented on issue #366: Support more runtime types from bluemix host info. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/366#issuecomment-325734725 @lzbj @pritidesai @houshengbo Priti has volunteered to "fix" this if I merge it today and work to put back the

[GitHub] mrutkows closed pull request #366: Support more runtime types from bluemix host info.

2017-08-29 Thread git
mrutkows closed pull request #366: Support more runtime types from bluemix host info. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/366 This is an automated message from the Apache Git Service. To

[GitHub] rabbah commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
rabbah commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135870188 ## File path: tests/src/test/scala/whisk/core/cli/test/WskBasicUsageTests.scala ## @@ -826,6

[GitHub] rabbah commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
rabbah commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135870847 ## File path: tests/src/test/scala/whisk/core/cli/test/WskBasicUsageTests.scala ## @@ -826,6

[GitHub] rabbah commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
rabbah commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135870714 ## File path: tests/src/test/scala/whisk/core/cli/test/WskBasicUsageTests.scala ## @@ -826,6

[GitHub] rabbah commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
rabbah commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135870088 ## File path: tests/src/test/scala/common/Wsk.scala ## @@ -168,13 +168,17 @@ trait

[GitHub] rabbah commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
rabbah commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135870847 ## File path: tests/src/test/scala/whisk/core/cli/test/WskBasicUsageTests.scala ## @@ -826,6

[GitHub] houshengbo commented on a change in pull request #406: fixing david's runtimetests

2017-08-29 Thread git
houshengbo commented on a change in pull request #406: fixing david's runtimetests URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/406#discussion_r135875483 ## File path: tests/src/integration/runtimetests/runtimes_test.go ## @@ -28,11 +28,10 @@ import

[GitHub] houshengbo commented on a change in pull request #406: fixing david's runtimetests

2017-08-29 Thread git
houshengbo commented on a change in pull request #406: fixing david's runtimetests URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/406#discussion_r135875616 ## File path: tests/src/integration/runtimetests/runtimes_test.go ## @@ -28,11 +28,10 @@ import

[GitHub] mdeuser commented on a change in pull request #2591: User-Agent CLI/version header

2017-08-29 Thread git
mdeuser commented on a change in pull request #2591: User-Agent CLI/version header URL: https://github.com/apache/incubator-openwhisk/pull/2591#discussion_r135885573 ## File path: tools/cli/go-whisk-cli/commands/commands.go ## @@ -60,6 +60,7 @@ func setupClientConfig(cmd

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135876203 ## File path: tools/cli/go-whisk-cli/commands/util.go ## @@ -866,6 +873,44 @@ func

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135878561 ## File path: tools/cli/go-whisk-cli/commands/action.go ## @@ -870,6 +970,17 @@ func

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135873280 ## File path: tools/cli/go-whisk-cli/commands/util.go ## @@ -866,6 +873,44 @@ func

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135875181 ## File path: tools/cli/go-whisk-cli/commands/util.go ## @@ -866,6 +873,44 @@ func

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135869038 ## File path: tools/cli/go-whisk-cli/commands/action.go ## @@ -489,6 +492,87 @@ func

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135871039 ## File path: tools/cli/go-whisk-cli/commands/util.go ## @@ -866,6 +873,44 @@ func

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135878011 ## File path: tools/cli/go-whisk-cli/commands/action.go ## @@ -908,29 +1019,29 @@ func

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135871798 ## File path: tools/cli/go-whisk-cli/commands/util.go ## @@ -866,6 +873,44 @@ func

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135869150 ## File path: tools/cli/go-whisk-cli/commands/action.go ## @@ -489,6 +492,87 @@ func

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135874611 ## File path: tools/cli/go-whisk-cli/commands/util.go ## @@ -866,6 +873,44 @@ func

[GitHub] pritidesai opened a new issue #409: Undeploy doesn't work with manifest.yml

2017-08-29 Thread git
pritidesai opened a new issue #409: Undeploy doesn't work with manifest.yml URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/409 We can have deployment done with `manifest.yml` but when you try to undeploy, it fails with: ``` wskdeploy.Path is wskdeploy ==>

[GitHub] pritidesai commented on issue #366: Support more runtime types from bluemix host info.

2017-08-29 Thread git
pritidesai commented on issue #366: Support more runtime types from bluemix host info. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/366#issuecomment-325731104 @lzbj `TestSupportProjectPath` is failing with the following error, its executing with `-m` option but

[GitHub] pritidesai opened a new pull request #406: fixing david's runtimetests

2017-08-29 Thread git
pritidesai opened a new pull request #406: fixing david's runtimetests URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/406 replacing `-m` option with `-p` for runtime tests This is an automated message from

[GitHub] houshengbo opened a new pull request #34: Replace the path of wskprops' parent dir with the path of wskprops

2017-08-29 Thread git
houshengbo opened a new pull request #34: Replace the path of wskprops' parent dir with the path of wskprops URL: https://github.com/apache/incubator-openwhisk-client-go/pull/34 We need to search for .wskprops under HOME dir instead of GOPATH. In addition, we support the input of the

[GitHub] rabbah commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
rabbah commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135870088 ## File path: tests/src/test/scala/common/Wsk.scala ## @@ -168,13 +168,17 @@ trait

[GitHub] rabbah commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
rabbah commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135870007 ## File path: tools/cli/go-whisk/whisk/action.go ## @@ -51,6 +51,7 @@ type Exec struct {

[GitHub] rabbah commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
rabbah commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135870714 ## File path: tests/src/test/scala/whisk/core/cli/test/WskBasicUsageTests.scala ## @@ -826,6

[GitHub] pritidesai commented on issue #408: Make the config file able to work for .wskprops

2017-08-29 Thread git
pritidesai commented on issue #408: Make the config file able to work for .wskprops URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/408#issuecomment-325756305 WSK CLI stores the properties set in ~/.wskprops which looks like: ``` cat ~/.wskprops

[GitHub] mrutkows commented on issue #366: Support more runtime types from bluemix host info.

2017-08-29 Thread git
mrutkows commented on issue #366: Support more runtime types from bluemix host info. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/366#issuecomment-325733842 @lzbj the "jaraction" test should not have been brought into the runtimes tests. It should remain separate as

[GitHub] markusthoemmes commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
markusthoemmes commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135872664 ## File path: tools/cli/go-whisk-cli/wski18n/resources/en_US.all.json ## @@ -1522,4

[GitHub] houshengbo opened a new pull request #408: Make the config file able to work for .wskprops

2017-08-29 Thread git
houshengbo opened a new pull request #408: Make the config file able to work for .wskprops URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/408 This is an automated message from the Apache Git Service. To

[GitHub] houshengbo closed pull request #407: adding back jaraction integration test

2017-08-29 Thread git
houshengbo closed pull request #407: adding back jaraction integration test URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/407 This is an automated message from the Apache Git Service. To respond to the

[GitHub] houshengbo closed issue #25: Not adding "api" to the URL

2017-08-29 Thread git
houshengbo closed issue #25: Not adding "api" to the URL URL: https://github.com/apache/incubator-openwhisk-client-go/issues/25 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] houshengbo commented on issue #25: Not adding "api" to the URL

2017-08-29 Thread git
houshengbo commented on issue #25: Not adding "api" to the URL URL: https://github.com/apache/incubator-openwhisk-client-go/issues/25#issuecomment-325781332 @tleyden I have fixed this issue. Feel free to reopen it if it still valid.

[GitHub] markusthoemmes commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review)

2017-08-29 Thread git
markusthoemmes commented on a change in pull request #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r135872418 ## File path: tools/cli/go-whisk-cli/wski18n/resources/en_US.all.json ## @@ -1522,4

[GitHub] houshengbo commented on a change in pull request #406: fixing david's runtimetests

2017-08-29 Thread git
houshengbo commented on a change in pull request #406: fixing david's runtimetests URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/406#discussion_r135875488 ## File path: tests/src/integration/runtimetests/runtimes_test.go ## @@ -28,11 +28,10 @@ import

[GitHub] houshengbo commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing

2017-08-29 Thread git
houshengbo commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/405#issuecomment-325782197 @lzbj Strangely travis does not report this error, but it really exists when I run make test

[GitHub] mrutkows closed pull request #33: Remove bluemix URL as the default URL for client go

2017-08-29 Thread git
mrutkows closed pull request #33: Remove bluemix URL as the default URL for client go URL: https://github.com/apache/incubator-openwhisk-client-go/pull/33 This is an automated message from the Apache Git Service. To

[GitHub] mrutkows closed pull request #34: Replace the path of wskprops' parent dir with the path of wskprops

2017-08-29 Thread git
mrutkows closed pull request #34: Replace the path of wskprops' parent dir with the path of wskprops URL: https://github.com/apache/incubator-openwhisk-client-go/pull/34 This is an automated message from the Apache Git

[GitHub] lzbj closed issue #416: wskdeploy doesn't work with latest code merges.

2017-08-29 Thread git
lzbj closed issue #416: wskdeploy doesn't work with latest code merges. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/416 This is an automated message from the Apache Git Service. To respond to the

[GitHub] lzbj commented on issue #416: wskdeploy doesn't work with latest code merges.

2017-08-29 Thread git
lzbj commented on issue #416: wskdeploy doesn't work with latest code merges. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/416#issuecomment-325884830 ok, got it, I didn't update my cli lib, yes it works now, close it. Thanks a lot @daisy-ycguo .

[GitHub] lzbj commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing

2017-08-29 Thread git
lzbj commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/405#issuecomment-325886806 @pritidesai is our UT expert, please could you help take a look @pritidesai

[GitHub] cmdhema opened a new issue #2673: How can I restart OpenWhisk?

2017-08-29 Thread git
cmdhema opened a new issue #2673: How can I restart OpenWhisk? URL: https://github.com/apache/incubator-openwhisk/issues/2673 Hello I write codes on controller and invoker and others. And then, I did rebuild and deploy and successfully. After that, I invoke action with wsk

[GitHub] pritidesai commented on issue #408: Make the config file able to work for .wskprops

2017-08-29 Thread git
pritidesai commented on issue #408: Make the config file able to work for .wskprops URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/408#issuecomment-325794301 LGTM This is an automated message from the

[GitHub] houshengbo opened a new pull request #410: Update the README with more instructions of building binaries

2017-08-29 Thread git
houshengbo opened a new pull request #410: Update the README with more instructions of building binaries URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/410 This is an automated message from the Apache

[GitHub] pritidesai closed pull request #406: fixing david's runtimetests

2017-08-29 Thread git
pritidesai closed pull request #406: fixing david's runtimetests URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/406 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] pritidesai commented on issue #406: fixing david's runtimetests

2017-08-29 Thread git
pritidesai commented on issue #406: fixing david's runtimetests URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/406#issuecomment-325806759 All of these changes are incorporated into Vincent's PR #408 This

[GitHub] houshengbo closed issue #395: Deprecation of baseUrl

2017-08-29 Thread git
houshengbo closed issue #395: Deprecation of baseUrl URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/395 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] houshengbo commented on issue #395: Deprecation of baseUrl

2017-08-29 Thread git
houshengbo commented on issue #395: Deprecation of baseUrl URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/395#issuecomment-325813855 This is already fixed. This is an automated message from the Apache

[GitHub] mdeuser commented on issue #99: WIP Changes required to add service bindings to the Bluemix plugin

2017-08-29 Thread git
mdeuser commented on issue #99: WIP Changes required to add service bindings to the Bluemix plugin URL: https://github.com/apache/incubator-openwhisk-cli/pull/99#issuecomment-325816295 @jessealva - in general, when the pr is merged, no additional technical debt is expected. in this

[GitHub] pritidesai commented on issue #396: Deploy sequences separately other than combining with actions

2017-08-29 Thread git
pritidesai commented on issue #396: Deploy sequences separately other than combining with actions URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/396#issuecomment-325817448 @daisy-ycguo we have to make sure that wskdeploy deploys all actions prior to deploying

[GitHub] codecov-io commented on issue #63: style: add .editorconfig, eslint and reformat js file

2017-08-29 Thread git
codecov-io commented on issue #63: style: add .editorconfig, eslint and reformat js file URL: https://github.com/apache/incubator-openwhisk-client-js/pull/63#issuecomment-320281397 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/63?src=pr=h1) Report >

[GitHub] pritidesai commented on issue #396: Deploy sequences separately other than combining with actions

2017-08-29 Thread git
pritidesai commented on issue #396: Deploy sequences separately other than combining with actions URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/396#issuecomment-325817448 @daisy-ycguo we have to make sure that wskdeploy deploys all actions prior to deploying

[GitHub] houshengbo commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing

2017-08-29 Thread git
houshengbo commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/405#issuecomment-325782197 @lzbj Strangely travis does not report this error, but it really exists when I run make test

[GitHub] daisy-ycguo closed issue #157: Add manifest for support of the data processing cloudant use case.

2017-08-29 Thread git
daisy-ycguo closed issue #157: Add manifest for support of the data processing cloudant use case. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/157 This is an automated message from the Apache Git

[GitHub] daisy-ycguo commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing

2017-08-29 Thread git
daisy-ycguo commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/405#issuecomment-325585342 @houshengbo it didn't have any issues in my laptop. I think, you can check if you have changed

[GitHub] daisy-ycguo commented on issue #157: Add manifest for support of the data processing cloudant use case.

2017-08-29 Thread git
daisy-ycguo commented on issue #157: Add manifest for support of the data processing cloudant use case. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/157#issuecomment-325599311 Close it because it is fixed

[GitHub] mrutkows commented on a change in pull request #366: Support more runtime types from bluemix host info.

2017-08-29 Thread git
mrutkows commented on a change in pull request #366: Support more runtime types from bluemix host info. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/366#discussion_r135740059 ## File path: tests/src/integration/jaraction/manifest.yaml ## @@ -1,7 +0,0

[GitHub] daisy-ycguo commented on issue #396: Deploy sequences separately other than combining with actions

2017-08-29 Thread git
daisy-ycguo commented on issue #396: Deploy sequences separately other than combining with actions URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/396#issuecomment-325588639 @pritidesai Please review again. If it runs OK in your laptop, please help to merge it.

[GitHub] daisy-ycguo commented on issue #391: Wskdeploy sometimes tries to create sequence before action

2017-08-29 Thread git
daisy-ycguo commented on issue #391: Wskdeploy sometimes tries to create sequence before action URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/391#issuecomment-325569751 @pritidesai Please make sure below environment is set to correct values. Or else, feed cannot be

[GitHub] lzbj commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing

2017-08-29 Thread git
lzbj commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/405#issuecomment-325586867 Raise the level to get some attention, since it will slow down the development.

[GitHub] lzbj commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing

2017-08-29 Thread git
lzbj commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/405#issuecomment-325586533 I got the same issue. Installing dependencies go get -d -t ./... Testing go test ./...

[GitHub] pritidesai opened a new issue #411: typo in error message

2017-08-29 Thread git
pritidesai opened a new issue #411: typo in error message URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/411 ``` log.Println("the runtime it not supported by Openwhisk platform.") ``` should be ``` log.Println("the runtime is not supported by

[GitHub] ningyougang commented on issue #2662: Add judge condition for invoker deployment

2017-08-29 Thread git
ningyougang commented on issue #2662: Add judge condition for invoker deployment URL: https://github.com/apache/incubator-openwhisk/pull/2662#issuecomment-325849967 @markusthoemmes ,what do you think about this? This is an

[GitHub] daisy-ycguo commented on issue #396: Deploy sequences separately other than combining with actions

2017-08-29 Thread git
daisy-ycguo commented on issue #396: Deploy sequences separately other than combining with actions URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/396#issuecomment-325851955 @pritidesai If you run it with `wskdeploy -i`, you will see the difference.

[GitHub] lzbj closed pull request #410: Update the README with more instructions of building binaries

2017-08-29 Thread git
lzbj closed pull request #410: Update the README with more instructions of building binaries URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/410 This is an automated message from the Apache Git Service.

[GitHub] daisy-ycguo commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing

2017-08-29 Thread git
daisy-ycguo commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/405#issuecomment-325853751 @lzbj @houshengbo interesting issue. I run under ubuntu and it works fine.

[GitHub] houshengbo commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing

2017-08-29 Thread git
houshengbo commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/405#issuecomment-325853514 @lzbj Line 25 and Line 26 put '' and "" as the values. It seems the parser does not read them

[GitHub] lzbj commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing

2017-08-29 Thread git
lzbj commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/405#issuecomment-325853042 @houshengbo , correct, so I doubt we hit a yaml lib bug or even a golang bug perhaps, need to dig deeper

[GitHub] houshengbo commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing

2017-08-29 Thread git
houshengbo commented on issue #405: Unit test of TestParseManifestForSingleLineParams failing URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/405#issuecomment-325854461 @daisy-ycguo It is valid in mac. I tried ubuntu as well, there is no issue for linux.

[GitHub] saulimus commented on issue #2313: Failure to invoke /whisk.system/utils/echo in the Windows Git Bash Shell

2017-08-29 Thread git
saulimus commented on issue #2313: Failure to invoke /whisk.system/utils/echo in the Windows Git Bash Shell URL: https://github.com/apache/incubator-openwhisk/issues/2313#issuecomment-325635744 This workaround seems to work: https://stackoverflow.com/a/34386471 Example:

[GitHub] csantanapr commented on issue #2313: Failure to invoke /whisk.system/utils/echo in the Windows Git Bash Shell

2017-08-29 Thread git
csantanapr commented on issue #2313: Failure to invoke /whisk.system/utils/echo in the Windows Git Bash Shell URL: https://github.com/apache/incubator-openwhisk/issues/2313#issuecomment-325657867 @saulimus that's great workaround we should doc it. Also there is a fix to not require

[GitHub] mdeuser opened a new issue #2670: Changes to default API name

2017-08-29 Thread git
mdeuser opened a new issue #2670: Changes to default API name URL: https://github.com/apache/incubator-openwhisk/issues/2670 The default API name is the basepath, which contains the special character `/`. Change the default API name to no longer have those special characters (remove if

[GitHub] mdeuser commented on issue #2591: User-Agent CLI/version header

2017-08-29 Thread git
mdeuser commented on issue #2591: User-Agent CLI/version header URL: https://github.com/apache/incubator-openwhisk/pull/2591#issuecomment-325701529 @drcariel New changes look good to me. Will also need a peer PR for custom client user-agent value.

[GitHub] mrutkows commented on issue #366: Support more runtime types from bluemix host info.

2017-08-29 Thread git
mrutkows commented on issue #366: Support more runtime types from bluemix host info. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/366#issuecomment-325706098 @lzbj The Travis has a failure (and reports PASS) for the new tests: ``` === RUN TestSupportProjectPath

[GitHub] dubeejw commented on a change in pull request #2591: User-Agent CLI/version header

2017-08-29 Thread git
dubeejw commented on a change in pull request #2591: User-Agent CLI/version header URL: https://github.com/apache/incubator-openwhisk/pull/2591#discussion_r135813064 ## File path: tools/cli/go-whisk/whisk/client.go ## @@ -204,6 +210,8 @@ func (c *Client)

[GitHub] dubeejw commented on a change in pull request #2591: User-Agent CLI/version header

2017-08-29 Thread git
dubeejw commented on a change in pull request #2591: User-Agent CLI/version header URL: https://github.com/apache/incubator-openwhisk/pull/2591#discussion_r135813376 ## File path: tools/cli/go-whisk/whisk/client.go ## @@ -126,6 +128,10 @@ func NewClient(httpClient

[GitHub] dubeejw commented on a change in pull request #2591: User-Agent CLI/version header

2017-08-29 Thread git
dubeejw commented on a change in pull request #2591: User-Agent CLI/version header URL: https://github.com/apache/incubator-openwhisk/pull/2591#discussion_r135812636 ## File path: tools/cli/go-whisk-cli/commands/commands.go ## @@ -60,6 +60,8 @@ func setupClientConfig(cmd

[GitHub] houshengbo closed pull request #397: Restore the integration tests

2017-08-29 Thread git
houshengbo closed pull request #397: Restore the integration tests URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/397 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] jessealva opened a new pull request #99: WIP Changes required to add service bindings to the Bluemix plugin

2017-08-29 Thread git
jessealva opened a new pull request #99: WIP Changes required to add service bindings to the Bluemix plugin URL: https://github.com/apache/incubator-openwhisk-cli/pull/99 Essentially just added some publicly exported functions, which called the private versions. This helped to have a

[GitHub] jessealva commented on issue #99: WIP Changes required to add service bindings to the Bluemix plugin

2017-08-29 Thread git
jessealva commented on issue #99: WIP Changes required to add service bindings to the Bluemix plugin URL: https://github.com/apache/incubator-openwhisk-cli/pull/99#issuecomment-325696498 @mdeuser ^^ This is an automated

[GitHub] daisy-ycguo closed issue #411: typo in error message

2017-08-29 Thread git
daisy-ycguo closed issue #411: typo in error message URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/411 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] daisy-ycguo commented on issue #411: typo in error message

2017-08-29 Thread git
daisy-ycguo commented on issue #411: typo in error message URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/411#issuecomment-325856282 Fixed and closed. This is an automated message from the Apache Git

[GitHub] daisy-ycguo commented on issue #391: Wskdeploy sometimes tries to create sequence before action

2017-08-29 Thread git
daisy-ycguo commented on issue #391: Wskdeploy sometimes tries to create sequence before action URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/391#issuecomment-325861256 Fixed with PR #396. This is an

[GitHub] mrutkows commented on issue #398: Concurrent issues when running integration tests accessing the same resources

2017-08-29 Thread git
mrutkows commented on issue #398: Concurrent issues when running integration tests accessing the same resources URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/398#issuecomment-325861245 Vincent mitigated this issue by naming each test (package) with a different name

[GitHub] daisy-ycguo closed issue #391: Wskdeploy sometimes tries to create sequence before action

2017-08-29 Thread git
daisy-ycguo closed issue #391: Wskdeploy sometimes tries to create sequence before action URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/391 This is an automated message from the Apache Git Service. To

[GitHub] mrutkows closed issue #398: Concurrent issues when running integration tests accessing the same resources

2017-08-29 Thread git
mrutkows closed issue #398: Concurrent issues when running integration tests accessing the same resources URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/398 This is an automated message from the Apache

[GitHub] daisy-ycguo opened a new issue #414: Reporting warning errors when the environment values in yaml files are not set

2017-08-29 Thread git
daisy-ycguo opened a new issue #414: Reporting warning errors when the environment values in yaml files are not set URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/414 This is an automated message from

[GitHub] pritidesai opened a new issue #415: dependent packages requires manifest.yml and doesn't support manifest.yaml

2017-08-29 Thread git
pritidesai opened a new issue #415: dependent packages requires manifest.yml and doesn't support manifest.yaml URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/415 wskdeploy does not support dependent packages which has manifest.yaml file. It only deploys dependent

[GitHub] daisy-ycguo commented on issue #416: wskdeploy doesn't work with latest code merges.

2017-08-29 Thread git
daisy-ycguo commented on issue #416: wskdeploy doesn't work with latest code merges. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/416#issuecomment-325872468 @lzbj I updated to latest wskclient, and I can build now. I deployed a cloudant-trigger test case, it

[GitHub] daisy-ycguo commented on issue #416: wskdeploy doesn't work with latest code merges.

2017-08-29 Thread git
daisy-ycguo commented on issue #416: wskdeploy doesn't work with latest code merges. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/416#issuecomment-325872468 @lzbj I updated to latest wskclient, and I can build now. I deployed a cloudant-trigger test case, it

[GitHub] pritidesai commented on issue #410: Update the README with more instructions of building binaries

2017-08-29 Thread git
pritidesai commented on issue #410: Update the README with more instructions of building binaries URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/410#issuecomment-325805303 @houshengbo please make sure to incorporate Zach's comments from issue #400

[GitHub] tleyden commented on issue #25: Not adding "api" to the URL

2017-08-29 Thread git
tleyden commented on issue #25: Not adding "api" to the URL URL: https://github.com/apache/incubator-openwhisk-client-go/issues/25#issuecomment-325812063 > Instead, credentials are now able to load in .wskprops Does it use that environment variable to find out which `.wskprops` to

[GitHub] ert78gb commented on issue #63: style: add .editorconfig, eslint and reformat js file

2017-08-29 Thread git
ert78gb commented on issue #63: style: add .editorconfig, eslint and reformat js file URL: https://github.com/apache/incubator-openwhisk-client-js/pull/63#issuecomment-325813494 @csantanapr - added `npm run lint` to travis.yml - added pre-commit hook to the project and add a few

[GitHub] mdeuser commented on issue #99: WIP Changes required to add service bindings to the Bluemix plugin

2017-08-29 Thread git
mdeuser commented on issue #99: WIP Changes required to add service bindings to the Bluemix plugin URL: https://github.com/apache/incubator-openwhisk-cli/pull/99#issuecomment-325817245 @jessealva oh.. also, you will want to submit open cli PRs against the apache/incubator-openwhisk repo

[GitHub] lzbj commented on issue #366: Support more runtime types from bluemix host info.

2017-08-29 Thread git
lzbj commented on issue #366: Support more runtime types from bluemix host info. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/366#issuecomment-325855014 sorry, my bad, I thought i was belong to runtimes, so @pritidesai , please help fix this and I'll merged your PR

[GitHub] daisy-ycguo opened a new pull request #412: fix some simple typos

2017-08-29 Thread git
daisy-ycguo opened a new pull request #412: fix some simple typos URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/412 Address issue #411 This is an automated message from the Apache Git Service. To respond

[GitHub] mrutkows closed pull request #412: fix some simple typos

2017-08-29 Thread git
mrutkows closed pull request #412: fix some simple typos URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/412 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] mrutkows closed pull request #396: Deploy sequences separately other than combining with actions

2017-08-29 Thread git
mrutkows closed pull request #396: Deploy sequences separately other than combining with actions URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/396 This is an automated message from the Apache Git

[GitHub] daisy-ycguo opened a new issue #413: Create enough sequence tests to make sure actions are created before sequences

2017-08-29 Thread git
daisy-ycguo opened a new issue #413: Create enough sequence tests to make sure actions are created before sequences URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/413 This is an automated message from

  1   2   >