[GitHub] rabbah commented on issue #3384: failing test actionContainers.PythonActionContainerTests.python3action should be able to import additional packages as installed in the image

2018-03-02 Thread GitBox
rabbah commented on issue #3384: failing test actionContainers.PythonActionContainerTests.python3action should be able to import additional packages as installed in the image URL: https://github.com/apache/incubator-openwhisk/issues/3384#issuecomment-369988142 ``` File

[GitHub] rabbah opened a new pull request #3385: Remove test for included packages in python container.

2018-03-02 Thread GitBox
rabbah opened a new pull request #3385: Remove test for included packages in python container. URL: https://github.com/apache/incubator-openwhisk/pull/3385 We don't do similar tests for other runtimes and with the separation of the runtimes into their own repos and with fewer packages

[GitHub] rabbah opened a new pull request #3386: Add PR template.

2018-03-02 Thread GitBox
rabbah opened a new pull request #3386: Add PR template. URL: https://github.com/apache/incubator-openwhisk/pull/3386 Fixes #3376. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] jthomas commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
jthomas commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-369995988 I've been testing out Codable support from the sample above in my library for wrapping Swift actions to produce binaries.

[GitHub] houshengbo opened a new pull request #3383: Add the license headers

2018-03-02 Thread GitBox
houshengbo opened a new pull request #3383: Add the license headers URL: https://github.com/apache/incubator-openwhisk/pull/3383 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] rabbah opened a new issue #3384: failing test actionContainers.PythonActionContainerTests.python3action should be able to import additional packages as installed in the image

2018-03-02 Thread GitBox
rabbah opened a new issue #3384: failing test actionContainers.PythonActionContainerTests.python3action should be able to import additional packages as installed in the image URL: https://github.com/apache/incubator-openwhisk/issues/3384 ```

[GitHub] dubeejw opened a new pull request #253: Resiliency Updates for MessageHubProduceTests

2018-03-02 Thread GitBox
dubeejw opened a new pull request #253: Resiliency Updates for MessageHubProduceTests URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/253 Add retry around polling mechanism for `Post a message with a binary value` and `Post a message with a binary key`.

[GitHub] dubeejw commented on issue #253: Resiliency Updates for MessageHubProduceTests

2018-03-02 Thread GitBox
dubeejw commented on issue #253: Resiliency Updates for MessageHubProduceTests URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/253#issuecomment-370007652 @abaruni, can you review? This is an automated

[GitHub] dubeejw closed pull request #3385: Remove test for included packages in python container.

2018-03-02 Thread GitBox
dubeejw closed pull request #3385: Remove test for included packages in python container. URL: https://github.com/apache/incubator-openwhisk/pull/3385 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] dubeejw closed issue #3384: failing test actionContainers.PythonActionContainerTests.python3action should be able to import additional packages as installed in the image

2018-03-02 Thread GitBox
dubeejw closed issue #3384: failing test actionContainers.PythonActionContainerTests.python3action should be able to import additional packages as installed in the image URL: https://github.com/apache/incubator-openwhisk/issues/3384

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-365519693 TODOs - [x] Handle when input params is empty - [x] Add tests cases for Codable

[GitHub] dubeejw commented on issue #3302: Sanitize test subjects before tests.

2018-03-02 Thread GitBox
dubeejw commented on issue #3302: Sanitize test subjects before tests. URL: https://github.com/apache/incubator-openwhisk/pull/3302#issuecomment-370027655 @rabbah, needs rebasing for PG. This is an automated message from the

[GitHub] mhamann opened a new pull request #280: Use sourceforge on HTTPS

2018-03-02 Thread GitBox
mhamann opened a new pull request #280: Use sourceforge on HTTPS URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/280 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] csantanapr opened a new issue #29: swift 4.x add support throw and handle as error field in out json

2018-03-02 Thread GitBox
csantanapr opened a new issue #29: swift 4.x add support throw and handle as error field in out json URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/29 This is feedback from @jthomas

[GitHub] dubeejw closed pull request #229: Travis local cli

2018-03-02 Thread GitBox
dubeejw closed pull request #229: Travis local cli URL: https://github.com/apache/incubator-openwhisk-cli/pull/229 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] dubeejw commented on issue #3302: Sanitize test subjects before tests.

2018-03-02 Thread GitBox
dubeejw commented on issue #3302: Sanitize test subjects before tests. URL: https://github.com/apache/incubator-openwhisk/pull/3302#issuecomment-370038091 @markusthoemmes, ``` .../open/tests/src/test/scala/limits/ThrottleTests.scala:49: Unused import import scala.util.{Failure,

[GitHub] mrutkows closed pull request #7: updating manifest files to replace package with packages

2018-03-02 Thread GitBox
mrutkows closed pull request #7: updating manifest files to replace package with packages URL: https://github.com/apache/incubator-openwhisk-test/pull/7 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] dubeejw commented on issue #3302: Sanitize test subjects before tests.

2018-03-02 Thread GitBox
dubeejw commented on issue #3302: Sanitize test subjects before tests. URL: https://github.com/apache/incubator-openwhisk/pull/3302#issuecomment-369829824 PG2 2883 ? This is an automated message from the Apache Git Service.

[GitHub] csantanapr closed pull request #253: Resiliency Updates for MessageHub Tests

2018-03-02 Thread GitBox
csantanapr closed pull request #253: Resiliency Updates for MessageHub Tests URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/253 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] dubeejw commented on issue #3302: Sanitize test subjects before tests.

2018-03-02 Thread GitBox
dubeejw commented on issue #3302: Sanitize test subjects before tests. URL: https://github.com/apache/incubator-openwhisk/pull/3302#issuecomment-370038091 @markusthoemmes, ``` .../open/tests/src/test/scala/limits/ThrottleTests.scala:49: Unused import import scala.util.{Failure,

[GitHub] dubeejw commented on issue #3302: Sanitize test subjects before tests.

2018-03-02 Thread GitBox
dubeejw commented on issue #3302: Sanitize test subjects before tests. URL: https://github.com/apache/incubator-openwhisk/pull/3302#issuecomment-370038091 @markusthoemmes, ``` .../open/tests/src/test/scala/limits/ThrottleTests.scala:49: Unused import import scala.util.{Failure,

[GitHub] dubeejw commented on issue #3302: Sanitize test subjects before tests.

2018-03-02 Thread GitBox
dubeejw commented on issue #3302: Sanitize test subjects before tests. URL: https://github.com/apache/incubator-openwhisk/pull/3302#issuecomment-370038091 @markusthoemmes, ``` .../open/tests/src/test/scala/limits/ThrottleTests.scala:49: Unused import import scala.util.{Failure,

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-365519693 TODOs - [x] Handle when input params is empty - [ ] Add tests cases for Codable

[GitHub] dubeejw commented on issue #236: Output URL when creating/updating actions with --web true

2018-03-02 Thread GitBox
dubeejw commented on issue #236: Output URL when creating/updating actions with --web true URL: https://github.com/apache/incubator-openwhisk-cli/issues/236#issuecomment-370053308 @glynnbird, @jthomas, you can use `wsk action get x --url`.

[GitHub] dubeejw commented on issue #236: Output URL when creating/updating actions with --web true

2018-03-02 Thread GitBox
dubeejw commented on issue #236: Output URL when creating/updating actions with --web true URL: https://github.com/apache/incubator-openwhisk-cli/issues/236#issuecomment-370053308 @glynnbird, you can use `wsk action get x --url`.

[GitHub] dubeejw commented on issue #253: Resiliency Updates for MessageHubProduceTests

2018-03-02 Thread GitBox
dubeejw commented on issue #253: Resiliency Updates for MessageHubProduceTests URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/253#issuecomment-370007652 @abaruni, can you review? This is an automated

[GitHub] csantanapr closed pull request #28: Add license headers

2018-03-02 Thread GitBox
csantanapr closed pull request #28: Add license headers URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/28 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] markusthoemmes commented on issue #3302: Sanitize test subjects before tests.

2018-03-02 Thread GitBox
markusthoemmes commented on issue #3302: Sanitize test subjects before tests. URL: https://github.com/apache/incubator-openwhisk/pull/3302#issuecomment-370034753 @dubeejw I added a commit and rebased This is an automated

[GitHub] houshengbo closed pull request #280: Use sourceforge on HTTPS

2018-03-02 Thread GitBox
houshengbo closed pull request #280: Use sourceforge on HTTPS URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/280 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] pritidesai opened a new pull request #764: Deprecating Application in favor of Project

2018-03-02 Thread GitBox
pritidesai opened a new pull request #764: Deprecating Application in favor of Project URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/764 Closes #696 This is an automated message from the Apache Git

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370027301 Thanks @jthomas for the review and starting the work to externalize the epilogue in to it's own library/package.

[GitHub] dubeejw commented on issue #3302: Sanitize test subjects before tests.

2018-03-02 Thread GitBox
dubeejw commented on issue #3302: Sanitize test subjects before tests. URL: https://github.com/apache/incubator-openwhisk/pull/3302#issuecomment-369829824 PG2 2883 ? This is an automated message from the Apache Git Service.

[GitHub] dubeejw commented on issue #3302: Sanitize test subjects before tests.

2018-03-02 Thread GitBox
dubeejw commented on issue #3302: Sanitize test subjects before tests. URL: https://github.com/apache/incubator-openwhisk/pull/3302#issuecomment-370035332 PG2 2884 ? This is an automated message from the Apache Git Service.

[GitHub] dubeejw commented on issue #3302: Sanitize test subjects before tests.

2018-03-02 Thread GitBox
dubeejw commented on issue #3302: Sanitize test subjects before tests. URL: https://github.com/apache/incubator-openwhisk/pull/3302#issuecomment-370035332 PG2 2885 ? This is an automated message from the Apache Git Service.

[GitHub] mrutkows closed pull request #760: WIP: rewrite deploymentreader_test.go

2018-03-02 Thread GitBox
mrutkows closed pull request #760: WIP: rewrite deploymentreader_test.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/760 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] mrutkows commented on issue #760: WIP: rewrite deploymentreader_test.go

2018-03-02 Thread GitBox
mrutkows commented on issue #760: WIP: rewrite deploymentreader_test.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/760#issuecomment-370108256 Ended up with a big mess of merge conflicts... going to start over.

[GitHub] mrutkows opened a new pull request #765: WIP: Update deploymentreader.go tests and fix bind logic.

2018-03-02 Thread GitBox
mrutkows opened a new pull request #765: WIP: Update deploymentreader.go tests and fix bind logic. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/765 This is an automated message from the Apache Git

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370027301 Thanks @jthomas for the review and starting the work to externalize the epilogue in to it's own library/package.

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370113363 Woot ! - [ ] Improved error handled to give more descriptive messages, e.g.

[GitHub] chetanmeh commented on a change in pull request #3369: Use pureconfig for CouchDbRestStore

2018-03-02 Thread GitBox
chetanmeh commented on a change in pull request #3369: Use pureconfig for CouchDbRestStore URL: https://github.com/apache/incubator-openwhisk/pull/3369#discussion_r172005583 ## File path: tests/src/test/scala/ha/ShootComponentsTests.scala ## @@ -67,13 +70,13 @@ class

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370056572 Woot ! - [x] Finish with the Codable test cases

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370056572 Woot ! - [ ] Finish with the Codable test cases

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370056572 Woot ! - [ ] Finish with the Codable test cases

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370027301 Thanks @jthomas for the review and starting the work to externalize the epilogue in to it's own library/package.

[GitHub] markusthoemmes commented on a change in pull request #3369: Use pureconfig for CouchDbRestStore

2018-03-02 Thread GitBox
markusthoemmes commented on a change in pull request #3369: Use pureconfig for CouchDbRestStore URL: https://github.com/apache/incubator-openwhisk/pull/3369#discussion_r171985206 ## File path: tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala ##

[GitHub] markusthoemmes commented on a change in pull request #3369: Use pureconfig for CouchDbRestStore

2018-03-02 Thread GitBox
markusthoemmes commented on a change in pull request #3369: Use pureconfig for CouchDbRestStore URL: https://github.com/apache/incubator-openwhisk/pull/3369#discussion_r171985779 ## File path: common/scala/src/main/scala/whisk/core/database/CouchDbStoreProvider.scala ##

[GitHub] rabbah commented on issue #3353: Fix the TLS issue with the CLI download

2018-03-02 Thread GitBox
rabbah commented on issue #3353: Fix the TLS issue with the CLI download URL: https://github.com/apache/incubator-openwhisk/pull/3353#issuecomment-370088307 @ddragosd my apologies for not merging this sooner. it looks like the new change to resolve conflicts is ``` git diff

[GitHub] hsane2001 commented on issue #3232: Making prewarm kind (and count) configurable

2018-03-02 Thread GitBox
hsane2001 commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-370061135 Hi, Thanks for this change. I am looking to be able to keep prewarmed containers spawned from custom images alive. Currently

[GitHub] markusthoemmes commented on a change in pull request #3369: Use pureconfig for CouchDbRestStore

2018-03-02 Thread GitBox
markusthoemmes commented on a change in pull request #3369: Use pureconfig for CouchDbRestStore URL: https://github.com/apache/incubator-openwhisk/pull/3369#discussion_r171985250 ## File path: tests/src/test/scala/ha/ShootComponentsTests.scala ## @@ -67,13 +70,13 @@

[GitHub] markusthoemmes commented on a change in pull request #3369: Use pureconfig for CouchDbRestStore

2018-03-02 Thread GitBox
markusthoemmes commented on a change in pull request #3369: Use pureconfig for CouchDbRestStore URL: https://github.com/apache/incubator-openwhisk/pull/3369#discussion_r171986056 ## File path: common/scala/src/main/resources/application.conf ## @@ -106,6 +106,23 @@ whisk

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370056572 Woot ! - [x] Finish with the Codable test cases This

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370056572 Woot ! - [ ] Finish with the Codable test cases This

[GitHub] rabbah commented on issue #3348: Allow wskadmin user block/unblock to accept a list of subject to block

2018-03-02 Thread GitBox
rabbah commented on issue #3348: Allow wskadmin user block/unblock to accept a list of subject to block URL: https://github.com/apache/incubator-openwhisk/pull/3348#issuecomment-370068114 > A test would be pretty nice i thought you might say that/ask ?

[GitHub] markusthoemmes closed pull request #3364: Add retries to some entity "update" tests

2018-03-02 Thread GitBox
markusthoemmes closed pull request #3364: Add retries to some entity "update" tests URL: https://github.com/apache/incubator-openwhisk/pull/3364 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] dubeejw closed issue #3136: NamespaceSpecificThrottleTests initialization error

2018-03-02 Thread GitBox
dubeejw closed issue #3136: NamespaceSpecificThrottleTests initialization error URL: https://github.com/apache/incubator-openwhisk/issues/3136 This is an automated message from the Apache Git Service. To respond to the

[GitHub] dubeejw closed pull request #3302: Sanitize test subjects before tests.

2018-03-02 Thread GitBox
dubeejw closed pull request #3302: Sanitize test subjects before tests. URL: https://github.com/apache/incubator-openwhisk/pull/3302 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] rabbah commented on a change in pull request #3232: Making prewarm kind (and count) configurable

2018-03-02 Thread GitBox
rabbah commented on a change in pull request #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#discussion_r171994225 ## File path: common/scala/src/main/resources/application.conf ## @@ -118,7 +118,11 @@

[GitHub] rabbah commented on a change in pull request #3232: Making prewarm kind (and count) configurable

2018-03-02 Thread GitBox
rabbah commented on a change in pull request #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#discussion_r171994035 ## File path: ansible/templates/whisk.properties.j2 ## @@ -35,6 +35,9 @@

[GitHub] rabbah commented on a change in pull request #3232: Making prewarm kind (and count) configurable

2018-03-02 Thread GitBox
rabbah commented on a change in pull request #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#discussion_r171994178 ## File path: common/scala/src/main/resources/application.conf ## @@ -118,7 +118,11 @@

[GitHub] rabbah commented on a change in pull request #3232: Making prewarm kind (and count) configurable

2018-03-02 Thread GitBox
rabbah commented on a change in pull request #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#discussion_r171994115 ## File path: ansible/group_vars/all ## @@ -36,6 +36,11 @@ whisk: # runtimesManifest: "{{

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370057360 Woot ! - [ ] Refresh again with latest 4.1 snapshot

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370057360 Woot ! - [x] Refresh again with latest 4.1 snapshot

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370057360 Woot ! - [ ] Refresh again with latest 4.1 snapshot

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370027301 Thanks @jthomas for the review and starting the work to externalize the epilogue in to it's own library/package.

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370058906 Woot ! - [x] Use @escaping instead for the callback

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370027301 Thanks @jthomas for the review and starting the work to externalize the epilogue in to it's own library/package.

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370058906 Woot ! - [ ] Use @escaping instead for the callback

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370058906 Woot ! - [x] Use `@escaping` instead for the callback

[GitHub] markusthoemmes commented on issue #3383: Add the license headers

2018-03-02 Thread GitBox
markusthoemmes commented on issue #3383: Add the license headers URL: https://github.com/apache/incubator-openwhisk/pull/3383#issuecomment-370068797 Please add a description, which gives context on why this is needed and link to a relevant issue in the releases repo.

[GitHub] dubeejw opened a new pull request #254: More Resiliency Updates for MessageHub Tests

2018-03-02 Thread GitBox
dubeejw opened a new pull request #254: More Resiliency Updates for MessageHub Tests URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/254 All the tests use the same MessageHub topic, this can result in a test's consumer trigger getting activation records from other

[GitHub] csantanapr closed pull request #254: More Resiliency Updates for MessageHub Tests

2018-03-02 Thread GitBox
csantanapr closed pull request #254: More Resiliency Updates for MessageHub Tests URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/254 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] csantanapr commented on issue #3386: Add PR template.

2018-03-02 Thread GitBox
csantanapr commented on issue #3386: Add PR template. URL: https://github.com/apache/incubator-openwhisk/pull/3386#issuecomment-370079024 ? ? This is an automated message from the Apache Git Service. To respond to the

[GitHub] csantanapr commented on issue #3353: Fix the TLS issue with the CLI download

2018-03-02 Thread GitBox
csantanapr commented on issue #3353: Fix the TLS issue with the CLI download URL: https://github.com/apache/incubator-openwhisk/pull/3353#issuecomment-370089728 Go ahead and patch it I?m on phone Also I had issues yesterday on my replacement temp Mac and using python3 also fixed

[GitHub] rabbah commented on issue #3302: Sanitize test subjects before tests.

2018-03-02 Thread GitBox
rabbah commented on issue #3302: Sanitize test subjects before tests. URL: https://github.com/apache/incubator-openwhisk/pull/3302#issuecomment-370062337 Thanks @markusthoemmes @dubeejw This is an automated message from the

[GitHub] rabbah commented on issue #3348: Allow wskadmin user block/unblock to accept a list of subject to block

2018-03-02 Thread GitBox
rabbah commented on issue #3348: Allow wskadmin user block/unblock to accept a list of subject to block URL: https://github.com/apache/incubator-openwhisk/pull/3348#issuecomment-370068114 > A test would be pretty nice i thought you might say that ?

[GitHub] rabbah commented on issue #3366: Adds method deleteAttachments to ArtifactStore

2018-03-02 Thread GitBox
rabbah commented on issue #3366: Adds method deleteAttachments to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/pull/3366#issuecomment-370092106 PG1/2672 ? This is an automated message from the Apache Git

[GitHub] rabbah opened a new issue #3387: Mock database service for unit testing

2018-03-02 Thread GitBox
rabbah opened a new issue #3387: Mock database service for unit testing URL: https://github.com/apache/incubator-openwhisk/issues/3387 Many of our unit tests which need to mock a database operation actually use couch and require a deployment of the couchdb playbook. Instead, we should have

[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable

2018-03-02 Thread GitBox
rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-370094992 @hsane2001 can you open an issue to discuss the desired feature. I think the approach here establishes a bit of the foundation

[GitHub] mrutkows closed pull request #764: Deprecating Application in favor of Project

2018-03-02 Thread GitBox
mrutkows closed pull request #764: Deprecating Application in favor of Project URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/764 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] mrutkows closed issue #696: Deprecate "Application" keyword (in favor of Project)

2018-03-02 Thread GitBox
mrutkows closed issue #696: Deprecate "Application" keyword (in favor of Project) URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/696 This is an automated message from the Apache Git Service. To respond

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370027301 Thanks @jthomas for the review and starting the work to externalize the epilogue in to it's own library/package.

[GitHub] csantanapr opened a new issue #30: Remove Swift 4.0, only support 4.1 and forward

2018-03-02 Thread GitBox
csantanapr opened a new issue #30: Remove Swift 4.0, only support 4.1 and forward URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/30 Swift 4.2 is already announce as the next release https://swift.org/blog/4-2-release-process/ I propose we start Swift 4

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370113609 > With now 4.2 announced 4.1 is stable, so skip/remove 4.0 support only do 4.1 for now Going to move this to a new

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370113363 Woot ! - [x] Improved error handled to give more descriptive messages, e.g.

[GitHub] csantanapr commented on issue #23: Add Codable Support for Swift 4.x

2018-03-02 Thread GitBox
csantanapr commented on issue #23: Add Codable Support for Swift 4.x URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370113952 I think I'm ready for review and final merge of this PR

[GitHub] chetanmeh commented on a change in pull request #3369: Use pureconfig for CouchDbRestStore

2018-03-02 Thread GitBox
chetanmeh commented on a change in pull request #3369: Use pureconfig for CouchDbRestStore URL: https://github.com/apache/incubator-openwhisk/pull/3369#discussion_r172005653 ## File path: common/scala/src/main/resources/application.conf ## @@ -106,6 +106,23 @@ whisk {

[GitHub] daisy-ycguo opened a new pull request #52: Add license verification document

2018-03-02 Thread GitBox
daisy-ycguo opened a new pull request #52: Add license verification document URL: https://github.com/apache/incubator-openwhisk-release/pull/52 This is an automated message from the Apache Git Service. To respond to the

[GitHub] chetanmeh commented on issue #3366: Adds method deleteAttachments to ArtifactStore

2018-03-02 Thread GitBox
chetanmeh commented on issue #3366: Adds method deleteAttachments to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/pull/3366#issuecomment-369937404 Updated PR based on review feedback This is an automated

[GitHub] houshengbo opened a new pull request #7: Add the license headers to the files missing them

2018-03-02 Thread GitBox
houshengbo opened a new pull request #7: Add the license headers to the files missing them URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/7 This is an automated message from the Apache Git Service. To

[GitHub] houshengbo opened a new pull request #19: Add the license headers

2018-03-02 Thread GitBox
houshengbo opened a new pull request #19: Add the license headers URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/19 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] jonpspri commented on issue #3363: Ansible image name overrides and bump NGinx to 1.13.9

2018-03-02 Thread GitBox
jonpspri commented on issue #3363: Ansible image name overrides and bump NGinx to 1.13.9 URL: https://github.com/apache/incubator-openwhisk/pull/3363#issuecomment-369925869 I pinned to 1.13.9 to maximize stability. If we pin to 1.13, we're vulnerable to introducing unintended changes in

[GitHub] nheidloff opened a new issue #3381: Transfer-Encoding: chunked causes error

2018-03-02 Thread GitBox
nheidloff opened a new issue #3381: Transfer-Encoding: chunked causes error URL: https://github.com/apache/incubator-openwhisk/issues/3381 Hi, I've built a Spring Boot Docker container: https://github.com/nheidloff/openwhisk-debug-java When I use the out of the box Spring

[GitHub] markusthoemmes commented on issue #3381: Transfer-Encoding: chunked causes error

2018-03-02 Thread GitBox
markusthoemmes commented on issue #3381: Transfer-Encoding: chunked causes error URL: https://github.com/apache/incubator-openwhisk/issues/3381#issuecomment-369935363 Should be supportable. This could be a valuable first step for us to get into streaming! We "just" need to make

[GitHub] rabbah commented on a change in pull request #3366: Adds method deleteAttachments to ArtifactStore

2018-03-02 Thread GitBox
rabbah commented on a change in pull request #3366: Adds method deleteAttachments to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/pull/3366#discussion_r171842936 ## File path: common/scala/src/main/scala/whisk/core/database/CouchDbRestStore.scala ##

[GitHub] rabbah commented on a change in pull request #3366: Adds method deleteAttachments to ArtifactStore

2018-03-02 Thread GitBox
rabbah commented on a change in pull request #3366: Adds method deleteAttachments to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/pull/3366#discussion_r171841899 ## File path: common/scala/src/main/scala/whisk/core/database/ArtifactStore.scala ## @@

[GitHub] akrabat commented on issue #3323: Normalize a missing body for raw actions to JsString.empty.

2018-03-02 Thread GitBox
akrabat commented on issue #3323: Normalize a missing body for raw actions to JsString.empty. URL: https://github.com/apache/incubator-openwhisk/pull/3323#issuecomment-369901194 Oh, I wasn't offended :) It wasn't until this came up that I thought about it properly, so wanted to double

[GitHub] chetanmeh commented on issue #3366: Adds method deleteAttachments to ArtifactStore

2018-03-02 Thread GitBox
chetanmeh commented on issue #3366: Adds method deleteAttachments to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/pull/3366#issuecomment-369909376 @dubeejw Can you share your feedback on the PR This is

[GitHub] mdeuser opened a new issue #237: API with back-to-back path parameters fails

2018-03-02 Thread GitBox
mdeuser opened a new issue #237: API with back-to-back path parameters fails URL: https://github.com/apache/incubator-openwhisk-cli/issues/237 Creating an API with multiple back-to-back path parameters fails ``` >bx wsk api create /dumpurl /two/{segment1}/{segment2} get showPathSegs

[GitHub] markusthoemmes commented on issue #3323: Normalize a missing body for raw actions to JsString.empty.

2018-03-02 Thread GitBox
markusthoemmes commented on issue #3323: Normalize a missing body for raw actions to JsString.empty. URL: https://github.com/apache/incubator-openwhisk/pull/3323#issuecomment-369900711 @akrabat sure, I didn't meant to say that this is the wrong thing to do. I just completely forgot that

[GitHub] csantanapr commented on issue #3323: Normalize a missing body for raw actions to JsString.empty.

2018-03-02 Thread GitBox
csantanapr commented on issue #3323: Normalize a missing body for raw actions to JsString.empty. URL: https://github.com/apache/incubator-openwhisk/pull/3323#issuecomment-369900087 Thanks Rob for the investigation ? This

  1   2   >