[GitHub] csantanapr closed pull request #35: add webhook for slack notification

2018-03-26 Thread GitBox
csantanapr closed pull request #35: add webhook for slack notification URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/35 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] ningyougang commented on issue #3413: Remove deprecated loadbalancer.

2018-03-26 Thread GitBox
ningyougang commented on issue #3413: Remove deprecated loadbalancer. URL: https://github.com/apache/incubator-openwhisk/pull/3413#issuecomment-376363899 Any progress on this patch? This is an automated message from the

[GitHub] sciabarracom commented on issue #5: The go proxy

2018-03-26 Thread GitBox
sciabarracom commented on issue #5: The go proxy URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/5#issuecomment-376077970 I removed the exec and exec.zip replacing it with a build script - however tests must be run in an environment including go now... that should not

[GitHub] markusthoemmes commented on a change in pull request #3421: Add ElasticSearch Log Store

2018-03-26 Thread GitBox
markusthoemmes commented on a change in pull request #3421: Add ElasticSearch Log Store URL: https://github.com/apache/incubator-openwhisk/pull/3421#discussion_r177029555 ## File path: common/scala/src/main/scala/whisk/core/containerpool/logging/ElasticSearchLogStore.scala

[GitHub] markusthoemmes commented on a change in pull request #3421: Add ElasticSearch Log Store

2018-03-26 Thread GitBox
markusthoemmes commented on a change in pull request #3421: Add ElasticSearch Log Store URL: https://github.com/apache/incubator-openwhisk/pull/3421#discussion_r177029293 ## File path: common/scala/src/main/scala/whisk/core/containerpool/logging/ElasticSearchLogStore.scala

[GitHub] markusthoemmes commented on a change in pull request #3421: Add ElasticSearch Log Store

2018-03-26 Thread GitBox
markusthoemmes commented on a change in pull request #3421: Add ElasticSearch Log Store URL: https://github.com/apache/incubator-openwhisk/pull/3421#discussion_r177029936 ## File path: common/scala/src/main/scala/whisk/http/PoolingRestClient.scala ## @@ -55,16 +63,18 @@

[GitHub] markusthoemmes commented on a change in pull request #3421: Add ElasticSearch Log Store

2018-03-26 Thread GitBox
markusthoemmes commented on a change in pull request #3421: Add ElasticSearch Log Store URL: https://github.com/apache/incubator-openwhisk/pull/3421#discussion_r177028472 ## File path: common/scala/src/main/scala/whisk/core/containerpool/logging/ElasticSearchLogStore.scala

[GitHub] markusthoemmes commented on a change in pull request #3485: Action time limit test cleanup

2018-03-26 Thread GitBox
markusthoemmes commented on a change in pull request #3485: Action time limit test cleanup URL: https://github.com/apache/incubator-openwhisk/pull/3485#discussion_r177022846 ## File path: tests/src/test/scala/whisk/core/limits/ActionLimitsTests.scala ## @@ -63,37 +60,154

[GitHub] markusthoemmes commented on a change in pull request #3485: Action time limit test cleanup

2018-03-26 Thread GitBox
markusthoemmes commented on a change in pull request #3485: Action time limit test cleanup URL: https://github.com/apache/incubator-openwhisk/pull/3485#discussion_r177022985 ## File path: tests/src/test/scala/whisk/core/limits/ActionLimitsTests.scala ## @@ -63,37 +60,154

[GitHub] markusthoemmes commented on a change in pull request #3421: Add ElasticSearch Log Store

2018-03-26 Thread GitBox
markusthoemmes commented on a change in pull request #3421: Add ElasticSearch Log Store URL: https://github.com/apache/incubator-openwhisk/pull/3421#discussion_r176049724 ## File path: common/scala/src/main/scala/whisk/core/containerpool/logging/ElasticSearchRestClient.scala

[GitHub] markusthoemmes commented on a change in pull request #3421: Add ElasticSearch Log Store

2018-03-26 Thread GitBox
markusthoemmes commented on a change in pull request #3421: Add ElasticSearch Log Store URL: https://github.com/apache/incubator-openwhisk/pull/3421#discussion_r177028529 ## File path: common/scala/src/main/scala/whisk/core/containerpool/logging/ElasticSearchLogStore.scala

[GitHub] markusthoemmes commented on a change in pull request #3421: Add ElasticSearch Log Store

2018-03-26 Thread GitBox
markusthoemmes commented on a change in pull request #3421: Add ElasticSearch Log Store URL: https://github.com/apache/incubator-openwhisk/pull/3421#discussion_r176050241 ## File path: common/scala/src/main/scala/whisk/core/containerpool/logging/ElasticSearchLogStore.scala

[GitHub] markusthoemmes commented on a change in pull request #3421: Add ElasticSearch Log Store

2018-03-26 Thread GitBox
markusthoemmes commented on a change in pull request #3421: Add ElasticSearch Log Store URL: https://github.com/apache/incubator-openwhisk/pull/3421#discussion_r177029998 ## File path: tests/src/test/scala/whisk/core/containerpool/logging/ElasticSearchLogStoreTests.scala

[GitHub] sven-lange-last commented on a change in pull request #3485: Action time limit test cleanup

2018-03-26 Thread GitBox
sven-lange-last commented on a change in pull request #3485: Action time limit test cleanup URL: https://github.com/apache/incubator-openwhisk/pull/3485#discussion_r177048403 ## File path: tests/src/test/scala/whisk/core/limits/ActionLimitsTests.scala ## @@ -63,37

[GitHub] chetanmeh commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats

2018-03-26 Thread GitBox
chetanmeh commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-376165014 Blocked on #3490 This is an automated

[GitHub] rabbah commented on a change in pull request #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes

2018-03-26 Thread GitBox
rabbah commented on a change in pull request #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#discussion_r177070688 ## File path: ansible/templates/whisk.properties.j2 ## @@ -33,7

[GitHub] rabbah closed pull request #3457: Ansible 2.4 deprecates ‘include’ in favor of ‘import_*’ and ‘include_tasks’

2018-03-26 Thread GitBox
rabbah closed pull request #3457: Ansible 2.4 deprecates ‘include’ in favor of ‘import_*’ and ‘include_tasks’ URL: https://github.com/apache/incubator-openwhisk/pull/3457 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] krook opened a new issue #818: FYI: Changing latest wskdeploy download URL broke some travis jobs

2018-03-26 Thread GitBox
krook opened a new issue #818: FYI: Changing latest wskdeploy download URL broke some travis jobs URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/818 FYI, if anyone had jobs (like I did, now fixed) that pulls the latest tarball at the expected latest URL, the name

[GitHub] sven-lange-last commented on issue #3485: Action time limit test cleanup

2018-03-26 Thread GitBox
sven-lange-last commented on issue #3485: Action time limit test cleanup URL: https://github.com/apache/incubator-openwhisk/pull/3485#issuecomment-376139014 * Addressed all review comments. * PG 3 / 2059 running. This is

[GitHub] rabbah commented on issue #2971: OW Controller should be more lenient about the data type of the statusCode value passed to it from the openwhisk action

2018-03-26 Thread GitBox
rabbah commented on issue #2971: OW Controller should be more lenient about the data type of the statusCode value passed to it from the openwhisk action URL: https://github.com/apache/incubator-openwhisk/issues/2971#issuecomment-376142269 Closed by

[GitHub] rabbah closed pull request #3473: Support string based status code from actions.

2018-03-26 Thread GitBox
rabbah closed pull request #3473: Support string based status code from actions. URL: https://github.com/apache/incubator-openwhisk/pull/3473 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] rabbah closed issue #2971: OW Controller should be more lenient about the data type of the statusCode value passed to it from the openwhisk action

2018-03-26 Thread GitBox
rabbah closed issue #2971: OW Controller should be more lenient about the data type of the statusCode value passed to it from the openwhisk action URL: https://github.com/apache/incubator-openwhisk/issues/2971 This is an

[GitHub] jonpspri commented on a change in pull request #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes

2018-03-26 Thread GitBox
jonpspri commented on a change in pull request #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#discussion_r177070402 ## File path: ansible/templates/whisk.properties.j2 ## @@

[GitHub] jonpspri commented on a change in pull request #3442: Add -o option to overwrite target files

2018-03-26 Thread GitBox
jonpspri commented on a change in pull request #3442: Add -o option to overwrite target files URL: https://github.com/apache/incubator-openwhisk/pull/3442#discussion_r177066581 ## File path: ansible/roles/kafka/tasks/deploy.yml ## @@ -79,7 +79,7 @@ env: "{{

[GitHub] jonpspri commented on a change in pull request #3442: Add -o option to overwrite target files

2018-03-26 Thread GitBox
jonpspri commented on a change in pull request #3442: Add -o option to overwrite target files URL: https://github.com/apache/incubator-openwhisk/pull/3442#discussion_r177066435 ## File path: ansible/roles/cli/tasks/deploy.yml ## @@ -69,5 +69,5 @@ # Use old good unzip

[GitHub] rabbah commented on a change in pull request #3340: Default activation response to empty JsObject.

2018-03-26 Thread GitBox
rabbah commented on a change in pull request #3340: Default activation response to empty JsObject. URL: https://github.com/apache/incubator-openwhisk/pull/3340#discussion_r177068675 ## File path: common/scala/src/main/scala/whisk/core/entity/WhiskActivation.scala ## @@

[GitHub] sven-lange-last commented on a change in pull request #3485: Action time limit test cleanup

2018-03-26 Thread GitBox
sven-lange-last commented on a change in pull request #3485: Action time limit test cleanup URL: https://github.com/apache/incubator-openwhisk/pull/3485#discussion_r177050029 ## File path: tests/src/test/scala/whisk/core/limits/MaxActionDurationTests.scala ## @@ -42,38

[GitHub] jonpspri commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes

2018-03-26 Thread GitBox
jonpspri commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-376146865 @dgrove-oss Hmm... so maybe we should eventually factor out an invoker-helper that runs in the

[GitHub] jasonpet commented on issue #141: Add a membership management using the discovery

2018-03-26 Thread GitBox
jasonpet commented on issue #141: Add a membership management using the discovery URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/141#issuecomment-376230255 @rabbah, @dubee , @csantanapr - someone with commit rights (which I do not have) will need to review this

[GitHub] rabbah closed pull request #3442: Add -o option to overwrite target files

2018-03-26 Thread GitBox
rabbah closed pull request #3442: Add -o option to overwrite target files URL: https://github.com/apache/incubator-openwhisk/pull/3442 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] rabbah commented on issue #3490: Move controller config to reference.conf

2018-03-26 Thread GitBox
rabbah commented on issue #3490: Move controller config to reference.conf URL: https://github.com/apache/incubator-openwhisk/pull/3490#issuecomment-376166068 LGTM but defer to @markusthoemmes and @vvraskin This is an

[GitHub] jasonpet commented on issue #141: Add a membership management using the discovery

2018-03-26 Thread GitBox
jasonpet commented on issue #141: Add a membership management using the discovery URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/141#issuecomment-376229816 @dgrove-oss - will this udp discovery work for kubernetes? I know we will be moving to kubernetes soon.

[GitHub] drcariel opened a new issue #259: For Ease of Maintenance, Update and Decide Where these Tests Should Live

2018-03-26 Thread GitBox
drcariel opened a new issue #259: For Ease of Maintenance, Update and Decide Where these Tests Should Live URL: https://github.com/apache/incubator-openwhisk-cli/issues/259 There is currently a level of manual syncing going on between duplicate test files that exist in both

[GitHub] houshengbo opened a new pull request #71: Implement the versioning for openwhisk release

2018-03-26 Thread GitBox
houshengbo opened a new pull request #71: Implement the versioning for openwhisk release URL: https://github.com/apache/incubator-openwhisk-release/pull/71 This is an automated message from the Apache Git Service. To

[GitHub] jasonpet commented on issue #141: Add a membership management using the discovery

2018-03-26 Thread GitBox
jasonpet commented on issue #141: Add a membership management using the discovery URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/141#issuecomment-376227890 @KeonHee - I think the issue I am having has to do with the fact that this requires udp for the discovery.

[GitHub] houshengbo opened a new pull request #70: Add the link to license compliace to README page

2018-03-26 Thread GitBox
houshengbo opened a new pull request #70: Add the link to license compliace to README page URL: https://github.com/apache/incubator-openwhisk-release/pull/70 Closes: #68 This is an automated message from the Apache Git

[GitHub] jonpspri closed pull request #3489: Switch 'scala' image to use OpenJDK 8

2018-03-26 Thread GitBox
jonpspri closed pull request #3489: Switch 'scala' image to use OpenJDK 8 URL: https://github.com/apache/incubator-openwhisk/pull/3489 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] jonpspri commented on issue #3489: Switch 'scala' image to use OpenJDK 8

2018-03-26 Thread GitBox
jonpspri commented on issue #3489: Switch 'scala' image to use OpenJDK 8 URL: https://github.com/apache/incubator-openwhisk/pull/3489#issuecomment-376201314 Closing for now. It appears the original issue was resolved. This

[GitHub] houshengbo commented on issue #61: tag repos with version after first release with openwhisk@1.0.0

2018-03-26 Thread GitBox
houshengbo commented on issue #61: tag repos with version after first release with openwhisk@1.0.0 URL: https://github.com/apache/incubator-openwhisk-release/issues/61#issuecomment-376194896 @csantanapr Based on what have now in config.json, we are able to define a major and a minor

[GitHub] houshengbo commented on issue #47: How can we generate the changlog and release note for each release

2018-03-26 Thread GitBox
houshengbo commented on issue #47: How can we generate the changlog and release note for each release URL: https://github.com/apache/incubator-openwhisk-release/issues/47#issuecomment-376200349 We have already got a script to generate the release note:

[GitHub] houshengbo opened a new issue #9: Package the binaries of each repo in need

2018-03-26 Thread GitBox
houshengbo opened a new issue #9: Package the binaries of each repo in need URL: https://github.com/apache/incubator-openwhisk-release/issues/9 We need to publish the binaries for the openwhisk projects, which are able to provide the binaries.

[GitHub] ScottChapman commented on issue #819: wsk deploy not picking up new target

2018-03-26 Thread GitBox
ScottChapman commented on issue #819: wsk deploy not picking up new target URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/819#issuecomment-376190885 And then it magically worked... Here is the entire transcript: > SECMacbookPro:Weather scottchapman$ wskdeploy

[GitHub] houshengbo commented on issue #63: Verify API Gateway legal NOTICE / CREDITS files ack. licenses/contribs.

2018-03-26 Thread GitBox
houshengbo commented on issue #63: Verify API Gateway legal NOTICE / CREDITS files ack. licenses/contribs. URL: https://github.com/apache/incubator-openwhisk-release/issues/63#issuecomment-376200018 @mrutkows I had a PR in the openwhisk-apigateway repo to replace and add the license

[GitHub] ScottChapman opened a new issue #819: wsk deploy not picking up new target

2018-03-26 Thread GitBox
ScottChapman opened a new issue #819: wsk deploy not picking up new target URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/819 This has actually happened to me a couple of times. I will be working in a space, wskdeploy working fine. Then I change the target with `bx

[GitHub] houshengbo commented on issue #61: tag repos with version after first release with openwhisk@1.0.0

2018-03-26 Thread GitBox
houshengbo commented on issue #61: tag repos with version after first release with openwhisk@1.0.0 URL: https://github.com/apache/incubator-openwhisk-release/issues/61#issuecomment-376194896 @csantanapr Based on what have now in config.json, we are able to define a major and a minor

[GitHub] houshengbo closed issue #21: Step 7: Upload the artifacts into staging repository for release vote

2018-03-26 Thread GitBox
houshengbo closed issue #21: Step 7: Upload the artifacts into staging repository for release vote URL: https://github.com/apache/incubator-openwhisk-release/issues/21 This is an automated message from the Apache Git

[GitHub] houshengbo commented on issue #21: Step 7: Upload the artifacts into staging repository for release vote

2018-03-26 Thread GitBox
houshengbo commented on issue #21: Step 7: Upload the artifacts into staging repository for release vote URL: https://github.com/apache/incubator-openwhisk-release/issues/21#issuecomment-376201174 This issue can be closed for now, because the code structure to upload the artifacts into

[GitHub] csantanapr opened a new issue #111: 3.14.0 release

2018-03-26 Thread GitBox
csantanapr opened a new issue #111: 3.14.0 release URL: https://github.com/apache/incubator-openwhisk-client-js/issues/111 ## release notes ### 3.14.0 (2018.03.26) - Add support to count entities with list (#109 ) ## process - `npm version patch` to bump

[GitHub] csantanapr opened a new pull request #112: update package.json and d.ts for 3.14

2018-03-26 Thread GitBox
csantanapr opened a new pull request #112: update package.json and d.ts for 3.14 URL: https://github.com/apache/incubator-openwhisk-client-js/pull/112 This is an automated message from the Apache Git Service. To respond to

[GitHub] csantanapr closed issue #29: swift 4.x add support throw for dict sync main signature and handle as error field in out json

2018-03-26 Thread GitBox
csantanapr closed issue #29: swift 4.x add support throw for dict sync main signature and handle as error field in out json URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/29 This is an automated

[GitHub] csantanapr commented on issue #29: swift 4.x add support throw for dict sync main signature and handle as error field in out json

2018-03-26 Thread GitBox
csantanapr commented on issue #29: swift 4.x add support throw for dict sync main signature and handle as error field in out json URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/29#issuecomment-376289930 This is already implemented

[GitHub] csantanapr opened a new issue #36: Fix codable escaping for result handler

2018-03-26 Thread GitBox
csantanapr opened a new issue #36: Fix codable escaping for result handler URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/36 The code will not compile if the main function calls another function that escapes. For example the following code: ```swift

[GitHub] jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo

2018-03-26 Thread GitBox
jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-376336913 @csantanapr @rabbah Please review. Moving ActionContainer and ResourceHelpers into a

[GitHub] rabbah commented on a change in pull request #3467: Remove actionControllers tests from incubator-openwhisk repo

2018-03-26 Thread GitBox
rabbah commented on a change in pull request #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#discussion_r177259895 ## File path: tests/src/test/scala/actionContainers/ActionProxyContainerTests.scala

[GitHub] rabbah commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo

2018-03-26 Thread GitBox
rabbah commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-376338579 actually I think tests/src/test/scala/actionContainers/ActionProxyContainerTests.scala can be made more

[GitHub] jonpspri commented on issue #28: Create a multi-architecture Docker image for the runtime

2018-03-26 Thread GitBox
jonpspri commented on issue #28: Create a multi-architecture Docker image for the runtime URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/28#issuecomment-376332907 Re-based and removed superfluous changes to testing processes.

[GitHub] csantanapr closed pull request #71: Implement the versioning for openwhisk release

2018-03-26 Thread GitBox
csantanapr closed pull request #71: Implement the versioning for openwhisk release URL: https://github.com/apache/incubator-openwhisk-release/pull/71 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] codecov-io commented on issue #112: update package.json and d.ts for 3.14

2018-03-26 Thread GitBox
codecov-io commented on issue #112: update package.json and d.ts for 3.14 URL: https://github.com/apache/incubator-openwhisk-client-js/pull/112#issuecomment-376303049 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/112?src=pr=h1) Report > Merging

[GitHub] jonpspri opened a new issue #3492: Add a utility main class in common to dump the config as JSON

2018-03-26 Thread GitBox
jonpspri opened a new issue #3492: Add a utility main class in common to dump the config as JSON URL: https://github.com/apache/incubator-openwhisk/issues/3492 Create a utility main class in the 'common' library to be available in controller and invoker JARs. The class should be in Java

[GitHub] jonpspri opened a new issue #3493: Validate whether 'runtimes.manifest' is still needed by tests

2018-03-26 Thread GitBox
jonpspri opened a new issue #3493: Validate whether 'runtimes.manifest' is still needed by tests URL: https://github.com/apache/incubator-openwhisk/issues/3493 The 'runtimes.manifest' variable in 'whisk.properties' and, therefore, 'whisk.properties.j2' may no longer be needed. If it is

[GitHub] dgrove-oss opened a new pull request #264: document purpose of encrypted URL

2018-03-26 Thread GitBox
dgrove-oss opened a new pull request #264: document purpose of encrypted URL URL: https://github.com/apache/incubator-openwhisk-catalog/pull/264 Should have comment explaining what the encrypted URL is doing. The PR also serves as a test that the hook is working as expected.

[GitHub] pritidesai closed issue #68: Add link to license_compliance.md under main project README

2018-03-26 Thread GitBox
pritidesai closed issue #68: Add link to license_compliance.md under main project README URL: https://github.com/apache/incubator-openwhisk-release/issues/68 This is an automated message from the Apache Git Service. To

[GitHub] pritidesai closed pull request #70: Add the link to license compliace to README page

2018-03-26 Thread GitBox
pritidesai closed pull request #70: Add the link to license compliace to README page URL: https://github.com/apache/incubator-openwhisk-release/pull/70 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of