[GitHub] markusthoemmes commented on a change in pull request #3945: Treat action code as attachments

2018-08-07 Thread GitBox
markusthoemmes commented on a change in pull request #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#discussion_r208153927 ## File path: common/scala/src/main/scala/whisk/core/entity/Exec.scala ## @@ -302,21 +309,29 @@

[GitHub] pritidesai closed pull request #283: adding comments

2018-08-07 Thread GitBox
pritidesai closed pull request #283: adding comments URL: https://github.com/apache/incubator-openwhisk-website/pull/283 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] markusthoemmes closed pull request #3924: Fix CacheConcurrencyTest cleanup.

2018-08-07 Thread GitBox
markusthoemmes closed pull request #3924: Fix CacheConcurrencyTest cleanup. URL: https://github.com/apache/incubator-openwhisk/pull/3924 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] markusthoemmes commented on issue #3924: Fix CacheConcurrencyTest cleanup.

2018-08-07 Thread GitBox
markusthoemmes commented on issue #3924: Fix CacheConcurrencyTest cleanup. URL: https://github.com/apache/incubator-openwhisk/pull/3924#issuecomment-410958811 Closing as wontfix for now. Bigger  This is an automated

[GitHub] codecov-io edited a comment on issue #3880: Modify that web action in the bound package can be accessed.

2018-08-07 Thread GitBox
codecov-io edited a comment on issue #3880: Modify that web action in the bound package can be accessed. URL: https://github.com/apache/incubator-openwhisk/pull/3880#issuecomment-405214016 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3880?src=pr=h1) Report >

[GitHub] codecov-io commented on issue #3949: don't explicitly terminate actorSystem (let CoordinatedShutdown do it…

2018-08-07 Thread GitBox
codecov-io commented on issue #3949: don't explicitly terminate actorSystem (let CoordinatedShutdown do it… URL: https://github.com/apache/incubator-openwhisk/pull/3949#issuecomment-410944548 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3949?src=pr=h1) Report >

[GitHub] codecov-io edited a comment on issue #3941: to address #3918, reuse a container on applicationError

2018-08-07 Thread GitBox
codecov-io edited a comment on issue #3941: to address #3918, reuse a container on applicationError URL: https://github.com/apache/incubator-openwhisk/pull/3941#issuecomment-410349503 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3941: to address #3918, reuse a container on applicationError

2018-08-07 Thread GitBox
codecov-io edited a comment on issue #3941: to address #3918, reuse a container on applicationError URL: https://github.com/apache/incubator-openwhisk/pull/3941#issuecomment-410349503 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3886: Proposing Lean OpenWhisk

2018-08-07 Thread GitBox
codecov-io edited a comment on issue #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#issuecomment-406254669 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=h1) Report > Merging

[GitHub] JiniousChoi commented on issue #3947: Building Invoker image failure due to ssl connection via wget

2018-08-07 Thread GitBox
JiniousChoi commented on issue #3947: Building Invoker image failure due to ssl connection via wget URL: https://github.com/apache/incubator-openwhisk/issues/3947#issuecomment-411248515 Yeah, the issue is gone. Thanks This

[GitHub] JiniousChoi closed issue #3947: Building Invoker image failure due to ssl connection via wget

2018-08-07 Thread GitBox
JiniousChoi closed issue #3947: Building Invoker image failure due to ssl connection via wget URL: https://github.com/apache/incubator-openwhisk/issues/3947 This is an automated message from the Apache Git Service. To

[GitHub] JiniousChoi commented on issue #3947: Building Invoker image failure due to ssl connection via wget

2018-08-07 Thread GitBox
JiniousChoi commented on issue #3947: Building Invoker image failure due to ssl connection via wget URL: https://github.com/apache/incubator-openwhisk/issues/3947#issuecomment-411235641 @dgrove-oss Alpine linux might have updated its docker image for this issue. I will check if the

[GitHub] tysonnorris commented on a change in pull request #3941: to address #3918, reuse a container on applicationError

2018-08-07 Thread GitBox
tysonnorris commented on a change in pull request #3941: to address #3918, reuse a container on applicationError URL: https://github.com/apache/incubator-openwhisk/pull/3941#discussion_r208404784 ## File path:

[GitHub] tysonnorris commented on a change in pull request #3941: to address #3918, reuse a container on applicationError

2018-08-07 Thread GitBox
tysonnorris commented on a change in pull request #3941: to address #3918, reuse a container on applicationError URL: https://github.com/apache/incubator-openwhisk/pull/3941#discussion_r208404838 ## File path:

[GitHub] jasonpet closed pull request #274: Remove required access to the whole couchdb database.

2018-08-07 Thread GitBox
jasonpet closed pull request #274: Remove required access to the whole couchdb database. URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/274 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] dubee commented on issue #3798: Allow for activation store to accept user and request information

2018-08-07 Thread GitBox
dubee commented on issue #3798: Allow for activation store to accept user and request information URL: https://github.com/apache/incubator-openwhisk/pull/3798#issuecomment-411175837 PG2 3475  This is an automated message

[GitHub] dubee commented on issue #3798: Allow for activation store to accept user and request information

2018-08-07 Thread GitBox
dubee commented on issue #3798: Allow for activation store to accept user and request information URL: https://github.com/apache/incubator-openwhisk/pull/3798#issuecomment-411175890 @markusthoemmes, anything else on this one?

[GitHub] rabbah commented on issue #3947: Building Invoker image failure due to ssl connection via wget

2018-08-07 Thread GitBox
rabbah commented on issue #3947: Building Invoker image failure due to ssl connection via wget URL: https://github.com/apache/incubator-openwhisk/issues/3947#issuecomment-411207687 @dgrove-oss ? This is an automated message

[GitHub] dgrove-oss commented on issue #3947: Building Invoker image failure due to ssl connection via wget

2018-08-07 Thread GitBox
dgrove-oss commented on issue #3947: Building Invoker image failure due to ssl connection via wget URL: https://github.com/apache/incubator-openwhisk/issues/3947#issuecomment-411218441 transient problem? It seems to be working just fine for me now.

[GitHub] dubee closed issue #3948: ActorSystem prematurely terminates; akka cluster nodes cannot leave gracefully

2018-08-07 Thread GitBox
dubee closed issue #3948: ActorSystem prematurely terminates; akka cluster nodes cannot leave gracefully URL: https://github.com/apache/incubator-openwhisk/issues/3948 This is an automated message from the Apache Git

[GitHub] dubee closed pull request #3949: don't explicitly terminate actorSystem (let CoordinatedShutdown do it…

2018-08-07 Thread GitBox
dubee closed pull request #3949: don't explicitly terminate actorSystem (let CoordinatedShutdown do it… URL: https://github.com/apache/incubator-openwhisk/pull/3949 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] pritidesai opened a new pull request #281: making dir openwhisk and added dir listing

2018-08-07 Thread GitBox
pritidesai opened a new pull request #281: making dir openwhisk and added dir listing URL: https://github.com/apache/incubator-openwhisk-website/pull/281 This is an automated message from the Apache Git Service. To respond

[GitHub] pritidesai closed pull request #281: making dir openwhisk and added dir listing

2018-08-07 Thread GitBox
pritidesai closed pull request #281: making dir openwhisk and added dir listing URL: https://github.com/apache/incubator-openwhisk-website/pull/281 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] pritidesai opened a new pull request #282: Redesigning OpenWhisk Website

2018-08-07 Thread GitBox
pritidesai opened a new pull request #282: Redesigning OpenWhisk Website URL: https://github.com/apache/incubator-openwhisk-website/pull/282 This is an automated message from the Apache Git Service. To respond to the

[GitHub] pritidesai opened a new pull request #283: adding comments

2018-08-07 Thread GitBox
pritidesai opened a new pull request #283: adding comments URL: https://github.com/apache/incubator-openwhisk-website/pull/283 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] Juice10 opened a new issue #284: Add code highlighting

2018-08-07 Thread GitBox
Juice10 opened a new issue #284: Add code highlighting URL: https://github.com/apache/incubator-openwhisk-website/issues/284 Add code highlighting to allow people to read the documentation much easier and scan through the code. The easiest & best syntax highlighter I could find was

[GitHub] codecov-io commented on issue #3942: make error count and percentage configurable for gatling tests

2018-08-07 Thread GitBox
codecov-io commented on issue #3942: make error count and percentage configurable for gatling tests URL: https://github.com/apache/incubator-openwhisk/pull/3942#issuecomment-411161996 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3942?src=pr=h1) Report > Merging

[GitHub] rabbah commented on a change in pull request #3941: to address #3918, reuse a container on applicationError

2018-08-07 Thread GitBox
rabbah commented on a change in pull request #3941: to address #3918, reuse a container on applicationError URL: https://github.com/apache/incubator-openwhisk/pull/3941#discussion_r208352657 ## File path:

[GitHub] pritidesai closed pull request #277: updates for index and layout on large sizes

2018-08-07 Thread GitBox
pritidesai closed pull request #277: updates for index and layout on large sizes URL: https://github.com/apache/incubator-openwhisk-website/pull/277 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] jeremiaswerner commented on issue #3942: make error count and percentage configurable for gatling tests

2018-08-07 Thread GitBox
jeremiaswerner commented on issue #3942: make error count and percentage configurable for gatling tests URL: https://github.com/apache/incubator-openwhisk/pull/3942#issuecomment-411029337 I've extended the PR to make all thresholds configurable via CLI invocation. ``` # API_KEY=

[GitHub] codecov-io edited a comment on issue #3945: Treat action code as attachments

2018-08-07 Thread GitBox
codecov-io edited a comment on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-410980593 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3945: Treat action code as attachments

2018-08-07 Thread GitBox
codecov-io edited a comment on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-410980593 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=h1) Report > Merging

[GitHub] markusthoemmes commented on a change in pull request #3945: Treat action code as attachments

2018-08-07 Thread GitBox
markusthoemmes commented on a change in pull request #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#discussion_r208197974 ## File path: common/scala/src/main/scala/whisk/core/entity/WhiskAction.scala ## @@ -333,23

[GitHub] markusthoemmes commented on a change in pull request #3942: make error count and percentage configurable for gatling tests

2018-08-07 Thread GitBox
markusthoemmes commented on a change in pull request #3942: make error count and percentage configurable for gatling tests URL: https://github.com/apache/incubator-openwhisk/pull/3942#discussion_r208202442 ## File path:

[GitHub] markusthoemmes commented on a change in pull request #3942: make error count and percentage configurable for gatling tests

2018-08-07 Thread GitBox
markusthoemmes commented on a change in pull request #3942: make error count and percentage configurable for gatling tests URL: https://github.com/apache/incubator-openwhisk/pull/3942#discussion_r208200918 ## File path: tests/performance/README.md ## @@ -101,14 +103,20

[GitHub] codecov-io edited a comment on issue #3945: Treat action code as attachments

2018-08-07 Thread GitBox
codecov-io edited a comment on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-410980593 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=h1) Report > Merging

[GitHub] chetanmeh commented on issue #3945: Treat action code as attachments

2018-08-07 Thread GitBox
chetanmeh commented on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-411022379 This PR is ready for review. One aspect which is still to be addressed is should we raise the default `max-inline-size` (defaults 16 KB)

[GitHub] markusthoemmes commented on a change in pull request #3945: Treat action code as attachments

2018-08-07 Thread GitBox
markusthoemmes commented on a change in pull request #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#discussion_r208150487 ## File path: common/scala/src/main/scala/whisk/core/entity/Exec.scala ## @@ -302,21 +309,29 @@

[GitHub] jthomas closed pull request #33: Lots and lots and lots of updates...

2018-08-07 Thread GitBox
jthomas closed pull request #33: Lots and lots and lots of updates... URL: https://github.com/apache/incubator-openwhisk-external-resources/pull/33 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] codecov-io commented on issue #3945: Treat action code as attachments

2018-08-07 Thread GitBox
codecov-io commented on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-410980593 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3945: Treat action code as attachments

2018-08-07 Thread GitBox
codecov-io edited a comment on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-410980593 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3945: Treat action code as attachments

2018-08-07 Thread GitBox
codecov-io edited a comment on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-410980593 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=h1) Report > Merging

[GitHub] csantanapr commented on a change in pull request #73: Don't override runtime npm packages when user provides their own

2018-08-07 Thread GitBox
csantanapr commented on a change in pull request #73: Don't override runtime npm packages when user provides their own URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/73#discussion_r208280639 ## File path:

[GitHub] csantanapr commented on a change in pull request #73: Don't override runtime npm packages when user provides their own

2018-08-07 Thread GitBox
csantanapr commented on a change in pull request #73: Don't override runtime npm packages when user provides their own URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/73#discussion_r208282550 ## File path: tools/travis/build.sh ## @@ -38,8 +38,16

[GitHub] codecov-io edited a comment on issue #3945: Treat action code as attachments

2018-08-07 Thread GitBox
codecov-io edited a comment on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-410980593 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=h1) Report > Merging

[GitHub] jeremiaswerner commented on issue #3942: make error count and percentage configurable for gatling tests

2018-08-07 Thread GitBox
jeremiaswerner commented on issue #3942: make error count and percentage configurable for gatling tests URL: https://github.com/apache/incubator-openwhisk/pull/3942#issuecomment-411099989 @markusthoemmes thanks for the review. I've adopted the comments.

[GitHub] csantanapr commented on a change in pull request #73: Don't override runtime npm packages when user provides their own

2018-08-07 Thread GitBox
csantanapr commented on a change in pull request #73: Don't override runtime npm packages when user provides their own URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/73#discussion_r208281086 ## File path: tools/travis/build.sh ## @@ -38,8 +38,16

[GitHub] csantanapr commented on a change in pull request #73: Don't override runtime npm packages when user provides their own

2018-08-07 Thread GitBox
csantanapr commented on a change in pull request #73: Don't override runtime npm packages when user provides their own URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/73#discussion_r208282176 ## File path:

[GitHub] sven-lange-last commented on issue #3772: Update kubectl version in invoker Dockerfile

2018-08-07 Thread GitBox
sven-lange-last commented on issue #3772: Update kubectl version in invoker Dockerfile URL: https://github.com/apache/incubator-openwhisk/pull/3772#issuecomment-411062291 @dgrove-oss which Kube version are we targetting with the invoker image? IBM Cloud Kubernetes service is on Kube 1.10

[GitHub] dgrove-oss commented on issue #3772: Update kubectl version in invoker Dockerfile

2018-08-07 Thread GitBox
dgrove-oss commented on issue #3772: Update kubectl version in invoker Dockerfile URL: https://github.com/apache/incubator-openwhisk/pull/3772#issuecomment-411060730 @bbrowning and @bwmcadams are you ok with the bump of kubectl in the invoker image to 1.8.x? If so, could you merge this

[GitHub] dgrove-oss commented on issue #3772: Update kubectl version in invoker Dockerfile

2018-08-07 Thread GitBox
dgrove-oss commented on issue #3772: Update kubectl version in invoker Dockerfile URL: https://github.com/apache/incubator-openwhisk/pull/3772#issuecomment-411065689 the open deploy-kube project nominally supports Kube 1.8, 1.9, and 1.10. The kubectl embedded in the invoker image

[GitHub] eweiter commented on issue #73: Don't override runtime npm packages when user provides their own

2018-08-07 Thread GitBox
eweiter commented on issue #73: Don't override runtime npm packages when user provides their own URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/73#issuecomment-411071728 @csantanapr This should be ready, it has the 3 tests we talked about 1) (Already

[GitHub] codecov-io edited a comment on issue #3945: Treat action code as attachments

2018-08-07 Thread GitBox
codecov-io edited a comment on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-410980593 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=h1) Report > Merging

[GitHub] chetanmeh commented on a change in pull request #3945: Treat action code as attachments

2018-08-07 Thread GitBox
chetanmeh commented on a change in pull request #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#discussion_r208257099 ## File path: common/scala/src/main/scala/whisk/core/entity/Exec.scala ## @@ -300,33 +300,28 @@

[GitHub] markusthoemmes commented on a change in pull request #3945: Treat action code as attachments

2018-08-07 Thread GitBox
markusthoemmes commented on a change in pull request #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#discussion_r208251229 ## File path: common/scala/src/main/scala/whisk/core/entity/Exec.scala ## @@ -300,33 +300,28 @@

[GitHub] codecov-io edited a comment on issue #3798: Allow for activation store to accept user and request information

2018-08-07 Thread GitBox
codecov-io edited a comment on issue #3798: Allow for activation store to accept user and request information URL: https://github.com/apache/incubator-openwhisk/pull/3798#issuecomment-399226990 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798?src=pr=h1) Report >